Hey,
On Tue, 24 Jul 2018 at 22:45, Derek Foreman
wrote:
> On 2018-07-22 05:55 AM, Daniel Stone wrote:
> > I take it the problem is that the client sets a particular surface as
> > the pointer surface, loses focus, sets the same surface as the pointer
> > surface on re-ent
Hey,
On Tue, 24 Jul 2018 at 06:43, Peter Hutterer wrote:
> Sending this out as patch even though what really matters is the
> output. Which is... here, tadaaa!
>
> https://people.freedesktop.org/~whot/libinput-rtd/
>
> Basically the motivation here is to make the user-visible documentation less
Hey Derek,
On Thu, 22 Feb 2018 at 22:16, Derek Foreman wrote:
> Keep track of what cusor image buffer is attached to the cursor
> surface and avoid re-attaching it if we don't have to.
>
> This isn't just an obviously pointless optimization, it turns all
> of toy toolkit into a test case for
Hi Marius,
On Wed, 21 Feb 2018 at 14:38, Marius Vlad wrote:
> @@ -456,6 +457,10 @@ weston_config_parse(const char *name)
> section = config_add_section(config, [1]);
> continue;
> default:
> + start_line =
Hi Greg,
On Tue, 10 Apr 2018 at 18:01, Greg V wrote:
> Happened mostly with neovim's xclip usage.
Thanks, I've merged this, updated to include more cases where it could be NULL:
67546bed0..3ea5437db 3ea5437dbd07d9a94aebbb651d8f8eeacc8765bd -> master
Cheers,
Daniel
Hi Madhurkiran,
On Wed, 21 Mar 2018 at 22:45, Madhurkiran Harikrishnan
wrote:
> + if (pbuffer_config != gr->egl_config &&
> + !gr->has_configless_context) {
> + weston_log("attempted to use a different EGL config for an "
> + "output but
Hi all,
On Wed, 27 Jun 2018 at 13:50, Emil Velikov wrote:
> On 27 June 2018 at 12:12, Emil Velikov wrote:
> > On 27 June 2018 at 12:01, Michael Tretter wrote:
> >> On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote:
> >>> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote:
> >>> > The
Hi Emre,
On Tue, 5 Jun 2018 at 09:30, Emre Ucan wrote:
> If compositor wakes up from sleep state, we have
> to trigger repaint for all outputs.
Seems trivially correct, merged with review:
280b73014..cf4113c62 cf4113c629751adcbb9904087932e12b5621219b -> master
Cheers,
Daniel
Hi,
The horribly ugly second patch fixes the autotools doc build, which
started failing after adding Meson support. The presence of
$(srcdir)/doc/doxygen/xml, created to hold meson.build, caused autotools
to believe it no longer needed to create $(builddir)/doc/doxygen/xml,
then immediately fail
The protocol spec used to live here, but it's now part of the regular
doc build. The PNG files are created as part of the doc build. Delete
the pre-generated versions.
Signed-off-by: Daniel Stone
---
spec/.gitignore | 3 ---
spec/wayland-architecture.png | Bin 29162 -> 0 by
, remove pre-pkg-config Expat
support, added missing include paths to wayland-egl and
cpp-compile-test, added GitLab CI.]
Reviewed-by: Daniel Stone
---
.gitlab-ci.yml | 24 +-
cursor/meson.build | 30 +++
doc/meson.build| 5 ++
egl/meson.build| 45
to control what's the location of the
test binaries, and fall back to the current directory if the variable is
unset.
Reviewed-by: Daniel Stone
---
tests/test-helpers.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/tests/test-helpers.c b/tests/test-helpers.c
Hi,
This is an updated version of Emmanuele's series. Notably it fixes up
the Doxygen man build, so we now correctly build and install all the man
pages.
I think this should be good to merge at this point. It is past the alpha
freeze, however getting it in a release would be a great way to get
From: Emmanuele Bassi
There are ancillary man pages not built by Doxygen that we need to
generate an install.
---
doc/man/meson.build | 64 +
doc/meson.build | 1 +
2 files changed, 65 insertions(+)
create mode 100644 doc/man/meson.build
diff
Hi Harsha,
Some small comments here, but more substantial comments in another patch.
On Thu, 28 Jun 2018 at 14:28, wrote:
> + gamma_prop_id = output->props_crtc[WDRM_CRTC_GAMMA_LUT].prop_id;
> + gamma_size_prop_id = output->props_crtc[WDRM_CRTC_GAMMA_LUT_SIZE].
> +
o-op check.
Signed-off-by: Daniel Stone
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 81cf4077..8c2fb822 100644
--- a/configure.ac
+++ b/configure.ac
@@ -109,7 +109,6 @@ if test "x$enable_libraries" = "xyes"; then
of Expat which do not ship a
pkg-config file.
Signed-off-by: Daniel Stone
---
configure.ac | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8c2fb822..0022dcda 100644
--- a/configure.ac
+++ b/configure.ac
@@ -111,16 +111,7 @@ if test &q
Hi,
Whilst going over Emmanuele's Meson series, I noticed a couple of
artifacts in the autotools build which could probably disappear; one
no-op header check, and one check for incredibly ancient Expat versions.
Cheers,
Daniel
___
wayland-devel
Shift up our calculation of the flags we use for atomic commits. We will
later use this to differentiate between test-only and full commits when
printing debug information inside drm_output_state_apply_atomic.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 25
.
Signed-off-by: Pekka Paalanen
Signed-off-by: Maniraj Devadoss
Reviewed-by: Pekka Paalanen
Reviewed-by: Daniel Stone
---
xwayland/window-manager.c | 58 ---
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git a/xwayland/window-manager.c b/xwayland
As a counterpart to weston_layer_set_mask_infinite(), returning if the
mask is the same as what is set.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 9 +
libweston/compositor.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/libweston/compositor.c b/libweston
From: Pekka Paalanen
Let users enable the compositor debug protocol on the compositor command
line. This allows weston-debug tool to work.
Signed-off-by: Pekka Paalanen
Signed-off-by: Maniraj Devadoss
Reviewed-by: Pekka Paalanen
---
compositor/main.c | 7 +++
man/weston.man| 11
timestamp
Signed-off-by: Maniraj Devadoss
Reviewed-by: Pekka Paalanen
Reviewed-by: Daniel Stone
---
compositor/main.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/compositor/main.c b/compositor/main.c
index 2f34e1115..eaf4cf381 100644
--- a/compositor/main.c
+++ b/
Add a 'drm-debug' scope which prints verbose information about the DRM
backend's repaint cycle, including the decision tree on how views are
assigned (or not) to planes.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 233 -
1 file changed, 206
-by: Maniraj Devadoss
[Pekka: fixed 'missing braces aroudn initializer' warning]
Add --list and --all arguments, using interface advertisement.
Signed-off-by: Daniel Stone
---
Makefile.am| 16 +-
clients/weston-debug.c | 453 +
man/weston-debug.man
Add a 'scene-graph' debug scope which will dump out the current set of
outputs, layers, and views and as much information as possible about how
they are rendered and composited.
Signed-off-by: Daniel Stone
---
libweston/compositor.c | 219 +
libweston
as an argument to dump_property(), but then all callers would need to be
converted to weston-debug infra in a single commit.
Therefore require the callers to provide the FILE* to print to.
Signed-off-by: Pekka Paalanen
Signed-off-by: Maniraj Devadoss
Reviewed-by: Pekka Paalanen
Reviewed-by: Daniel
-by: Daniel Stone
---
xwayland/launcher.c | 7 ++
xwayland/window-manager.c | 166 --
xwayland/xwayland.h | 3 +
3 files changed, 99 insertions(+), 77 deletions(-)
diff --git a/xwayland/launcher.c b/xwayland/launcher.c
index 0ecdb205e..c5b993851
-off-by: Pekka Paalanen
append the debug scope name along with the timestamp in
weston_debug_scope_timestamp API
Signed-off-by: Maniraj Devadoss
Reviewed-by: Pekka Paalanen
Add explicit advertisement of debug scope names.
Signed-off-by: Daniel Stone
---
Makefile.am | 2
Hi,
This patch series implements the weston-debug interface and tool, as
previously worked on by Pekka, Maniraj and Emre.
The xwm changes are unchanged from the previous series, and additionally
reviewed by myself.
The core protocol has seen the addition of a registry-like advertising
interface:
Add this for convenience, so it's easier to access when we add the DRM
backend debug scope.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index 704ac32c7..e27671437 100644
, but no planes active, which the kernel can
legitimately fail.
If we're working in renderer-only mode, just return the state we have
without trying to test it first, and let the kernel fill it in later.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 5 +
1 file changed, 5
Hi Deepak,
On Fri, 20 Jul 2018 at 12:21, Deepak Singh Rawat wrote:
> In brief the damage is in frame-buffer coordinate of attached fb to the plane.
> Unlike plane src coordinates, damage clips are not in 16.16 fixed point.
> Damage
> during page flip is helpful for some drivers like vmwgfx
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 16
1 file changed, 16 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index da9cf5e4f..e3e127a2d 100644
--- a/libweston/compositor-drm.c
+++ b/libweston/compositor-drm.c
@@ -91,26 +91,10 @@
e have had enough notice ...
For landing whenever (I'll happily take your judgement), this is:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
From: Pekka Paalanen
Taken from Pekka's wayland/wayland@630c25f4c160 and follow-ups, use
Wayland's CONTRIBUTING document as a basis for Weston.
Signed-off-by: Daniel Stone
---
CONTRIBUTING.md | 343
1 file changed, 343 insertions(+)
create
Hi,
The first two patches simply copy Pekka's CONTRIBUTING.md work, which
just landed in Wayland, into Weston.
The third patch attempts to use the power of the English language,
augmented with Markdown, to explain to people what Weston is in 2018,
and how they might go about using it. The
Hi Emilio,
On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote:
> @@ -343,17 +143,16 @@ fill_content(struct buffer *my_buf, uint64_t modifier)
> }
> else if (modifier == DRM_FORMAT_MOD_LINEAR) {
> uint8_t *pix8;
> -
Hi Emilio,
On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote:
> @@ -147,7 +147,7 @@ fill_content(struct buffer *my_buf, uint64_t modifier)
> for (y = 0; y < my_buf->height; y++) {
> pix8 = my_buf->mmap + y * my_buf->stride;
>
Hi Emilio,
On Thu, 12 Jul 2018 at 12:47, Emilio Pozuelo Monfort wrote:
> @@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry
> *registry,
> d->fshell = wl_registry_bind(registry,
> id,
>
Hi,
On Tue, 3 Jul 2018 at 11:32, Pekka Paalanen wrote:
> This is to avoid fighting around the letter of the guidelines. This is
> not a protocol spec.
Seems entirely sensible to me; thanks for writing this up!
Series is:
Reviewed-by: Daniel Stone
Cheers,
for a long time in wlroots.
Seems legitimate to me. I'd like to hear if anyone else touching
output has thoughts, but this is:
Acked-by: Daniel Stone
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesk
can't necessarily allocate suitable buffers, nor does it have to.
Don't spam the log with warnings when we fail on user buffers.
Signed-off-by: Daniel Stone
Reported-by: Pekka Paalanen
---
libweston/compositor-drm.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Hi Pekka,
On Wed, 11 Jul 2018 at 14:26, Pekka Paalanen wrote:
> On Wed, 11 Jul 2018 14:10:55 +0100 Daniel Stone wrote:
> > a0f8276fe814 ("compositor-drm: Disallow overlapping overlay planes") was
> > a little too pessimistic in rejecting occluded views. Whilst it
> &
Hi,
On Wed, 11 Jul 2018 at 14:07, Pekka Paalanen wrote:
> On Wed, 11 Jul 2018 13:16:18 +0100 Daniel Stone wrote:
> > @@ -3426,17 +3426,6 @@ drm_output_propose_state(struct weston_output
> > *output_base,
> > if (pixman_region
ndesirable: the primary/scanout plane is specified to stack
strictly below all overlay planes, so there is no need to reject a plane
from consideration for scanout due to being occluded by an overlay
plane.
Shift the check downwards so it only applies to overlay rather than
scanout planes.
Signed-off-by: Da
for
atomic by default, since we know ahead of time that our chosen plane
configuration will work.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 118 +++--
1 file changed, 86 insertions(+), 32 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston
Hi,
After a long discussion on IRC, patch 1 has been extensively rewritten.
Firstly, the handling of temporarily placing the old renderer
framebuffer has been localised to drm_output_propose_state, reducing the
damage. Secondly, the viciously ugly state_old handling in
prepare_scanout_view has
Now that we can sensibly test proposed plane configurations with atomic,
sprites are not broken.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor-drm.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/libweston
ndesirable: the primary/scanout plane is specified to stack
strictly below all overlay planes, so there is no need to reject a plane
from consideration for scanout due to being occluded by an overlay
plane.
Shift the check downwards so it only applies to overlay rather than
scanout planes.
Signed-off-by: Da
Hi Emilio,
On Wed, 11 Jul 2018 at 12:53, Emilio Pozuelo Monfort wrote:
> As for NV12 support: I tried to make gbm support that in
> backends/dri/gbm_dri.c by adding a mapping to gbm_dri_visuals_table
> from GBM_FORMAT_NV12 to __DRI_IMAGE_FOURCC_NV12 or DRM_FORMAT_NV12,
> but that didn't work.
Hi,
On Wed, 11 Jul 2018 at 12:43, Pekka Paalanen wrote:
> On Wed, 11 Jul 2018 11:41:29 +0100 Daniel Stone wrote:
> > @@ -2610,9 +2612,18 @@ drm_pending_state_apply_atomic(struct
> > drm_pending_state *pending_state,
> > case DRM_STATE_APPLY_ASYNC:
&g
Since we now incrementally test atomic state as we build it, we can
loosen restrictions on what we can do with planes, and let the kernel
tell us whether or not it's OK.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor-drm.c | 20
1 file
for
atomic by default, since we know ahead of time that our chosen plane
configuration will work.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 133 -
1 file changed, 102 insertions(+), 31 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston
Return a pointer to the plane state, rather than returning its
underlying weston_plane.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 63 +++---
1 file changed, 31 insertions(+), 32 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston
Now that we can sensibly test proposed plane configurations with atomic,
sprites are not broken.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston/compositor-drm.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/libweston
and then switch to mixed mode on the
next repaint.
This patch implements the mixed and renderer-only modes (previously
differentiated only by the sprites_are_broken flag), with the
planes-only mode being left for a later patch.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 70
by
proposing and testing potential configurations one at a time.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 56 +++---
1 file changed, 52 insertions(+), 4 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index 4bf18581b
assignment. In the
meantime, simply disallow assigning a view to an overlay, when it
overlaps another view which is already on an overlay. This ensures
stacking order is irrelevant, since the planes never intersect each
other.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston
different characteristics, so we need two passes: first,
constructing a state with only planes and testing if that succeeds,
falling back later to a mixed renderer/plane mode which tests
incrementally.
This implements the first mode, and preferentially attempts to use it.
Signed-off-by: Daniel Stone
modesetting, as we can actually test and ensure that the view is
compatible with scanout.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
Reported-by: Pekka Paalanen
---
libweston/compositor-drm.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libweston
Hi,
Another revision after Pekka's review. There is a memory leak fix in
testing atomic commits, as well as cosmetic changes inside
drm_output_propose_state.
The largest change is that if we enter drm_output_propose_state in
renderer-only mode, we no longer return early. This matches the
This will never work, so don't even try to do it.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index 65079eac0..c7ca6ef79 100644
--- a/libweston/compositor-drm.c
+++ b
Hi,
On Wed, 11 Jul 2018 at 11:20, Pekka Paalanen wrote:
> On Tue, 10 Jul 2018 18:58:44 +0100 Daniel Stone wrote:
> > @@ -2610,9 +2612,16 @@ drm_pending_state_apply_atomic(struct
> > drm_pending_state *pending_state,
> > case DRM_STATE_APPLY_ASYNC:
&g
Hi Pekka,
On Wed, 11 Jul 2018 at 10:21, Pekka Paalanen wrote:
> On Tue, 10 Jul 2018 18:58:42 +0100 Daniel Stone wrote:
> > @@ -3339,13 +3347,16 @@ drm_output_propose_state(struct weston_output
> > *output_base,
> >
On Tue, 10 Jul 2018 at 18:59, Daniel Stone wrote:
> @@ -3388,7 +3414,18 @@ drm_output_propose_state(struct weston_output
> *output_base,
> pixman_region32_fini(_region);
> pixman_region32_fini(_region);
>
> + /* Check to see if this state
Hi,
On Wed, 11 Jul 2018 at 09:16, Pekka Paalanen wrote:
> On Tue, 10 Jul 2018 17:53:15 +0200 Emilio Pozuelo Monfort
> wrote:
> > No need to write libdrm driver specific code for each supported
> > driver, we can just let GBM call the right one for us now.
> >
> > Signed-off-by: Emilio Pozuelo
for
atomic by default, since we know ahead of time that our chosen plane
configuration will work.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 133 -
1 file changed, 102 insertions(+), 31 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston
different characteristics, so we need two passes: first,
constructing a state with only planes and testing if that succeeds,
falling back later to a mixed renderer/plane mode which tests
incrementally.
This implements the first mode, and preferentially attempts to use it.
Signed-off-by: Daniel Stone
Now that we can sensibly test proposed plane configurations with atomic,
sprites are not broken.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
assignment. In the
meantime, simply disallow assigning a view to an overlay, when it
overlaps another view which is already on an overlay. This ensures
stacking order is irrelevant, since the planes never intersect each
other.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
---
libweston
This will never work, so don't even try to do it.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index f7a364837..282d6d67f 100644
--- a/libweston/compositor-drm.c
+++ b
by
proposing and testing potential configurations one at a time.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index
Since we now incrementally test atomic state as we build it, we can
loosen restrictions on what we can do with planes, and let the kernel
tell us whether or not it's OK.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 20
modesetting, as we can actually test and ensure that the view is
compatible with scanout.
Signed-off-by: Daniel Stone
Reported-by: Pekka Paalanen
---
libweston/compositor-drm.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston
Hi,
I believe this should resolve all the issues Pekka pointed out in the
(too hurried) v18. It's also been split up into a few different patches
with much more detailed commit messages, so should be much easier to
reason about and review.
Cheers,
Daniel
and then switch to mixed mode on the
next repaint.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 69 +-
1 file changed, 45 insertions(+), 24 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
Return a pointer to the plane state, rather than returning its
underlying weston_plane.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 53 ++
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/libweston
Return a pointer to the plane state, rather than indirecting via a
weston_plane.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 58 --
1 file changed, 30 insertions(+), 28 deletions(-)
diff --git a/libweston/compositor
assignment. In the
meantime, simply disallow assigning a view to an overlay, when it
overlaps another view which is already on an overlay. This ensures
stacking order is irrelevant, since the planes never intersect each
other.
Signed-off-by: Daniel Stone
Reported-by: Pekka Paalanen
---
libweston
Hi,
A couple of changes after Pekka's review of the second two patches,
including two preparatory patches pulled out.
Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
modesetting, as we can actually test and ensure that the view is
compatible with scanout.
Signed-off-by: Daniel Stone
Reported-by: Pekka Paalanen
---
libweston/compositor-drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index 2305f708f
and then switch to mixed mode on the
next repaint.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 86 +++---
1 file changed, 61 insertions(+), 25 deletions(-)
diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
Hi,
On Tue, 10 Jul 2018 at 10:06, Pekka Paalanen wrote:
> On Mon, 9 Jul 2018 14:23:15 +0100 Daniel Stone wrote:
> > @@ -3302,6 +3319,9 @@ drm_output_propose_state(struct weston_output
> > *output_base,
> > if (next_plane == NULL)
> >
Hi,
On Mon, 29 Jan 2018 at 13:59, Pekka Paalanen wrote:
> On Wed, 20 Dec 2017 12:26:55 +0000 Daniel Stone wrote:
> > @@ -1818,12 +1819,10 @@ drm_output_prepare_scanout_view(struct
> > drm_output_state *output_state,
> > drm_plane_state_coor
Hi,
On Mon, 29 Jan 2018 at 10:55, Pekka Paalanen wrote:
> On Mon, 29 Jan 2018 09:17:49 +0000 Daniel Stone wrote:
> > On 26 January 2018 at 14:04, Pekka Paalanen wrote:
> > > On Wed, 20 Dec 2017 12:26:52 +
> > > Daniel Stone wrote:
> > >&
Hi Pekka,
On Mon, 29 Jan 2018 at 15:01, Pekka Paalanen wrote:
> On Wed, 20 Dec 2017 12:26:57 +0000 Daniel Stone wrote:
> > @@ -212,6 +212,9 @@ if test x$enable_drm_compositor = xyes; then
> >PKG_CHECK_MODULES(DRM_COMPOSITOR_ATOMIC, [libdrm >= 2.4.78],
> >
Hi Pekka,
On Fri, 26 Jan 2018 at 12:45, Pekka Paalanen wrote:
> On Wed, 20 Dec 2017 12:26:51 +0000 Daniel Stone wrote:
> > @@ -3116,9 +3136,16 @@ drm_output_propose_state(struct weston_output
> > *output_base,
> > if (
() when C11 has been
explicitly requested - which we don't do - make sure to use the more
widely available _Static_assert() if that is provided.
This will be used in future patches to ensure two array lengths don't go
out of sync.
Signed-off-by: Daniel Stone
---
desktop-shell/shell.c
Move drm_assign_planes into two functions: one which proposes a plane
configuration, and another which applies that state to the Weston
internal structures. This will be used to try multiple configurations
and see which is supported.
Signed-off-by: Daniel Stone
Reviewed-by: Pekka Paalanen
When trying to assign planes, keep track of the areas which are
already occluded, and ignore views which are completely occluded. This
allows us to build a state using planes only, when there are occluded
views which cannot go into a plane behind views which can.
Signed-off-by: Daniel Stone
The atomic API can allow us to test state before we apply it, to see if
it will be valid. Add support for this, which we will later use in
assign_planes to ensure our plane configuration is valid.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 176
Now that we can sensibly test proposed plane configurations with atomic,
sprites are not broken.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/libweston/compositor
Return a pointer to the plane state, rather than indirecting via a
weston_plane.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 71 +-
1 file changed, 39 insertions(+), 32 deletions(-)
diff --git a/libweston/compositor
Add support for multiple modes: toggling whether or not the renderer
and/or planes are acceptable. This will be used to implement a smarter
plane-placement heuristic when we have support for testing output
states.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c
our existing calculation incorrect.
Though it does no harm to record incorrect information, it also does
no good as we never use it; remove it in order to avoid any confusion.
Signed-off-by: Daniel Stone
---
libweston/compositor-drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to
import multi-plane dmabufs, as well as format modifiers.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
configure.ac | 6 +-
libweston/compositor-drm.c | 201 +
2
,
this means that the gbm_bos we get from our scanout surface need to use
the extended API to query multiple planes, offsets, modifiers, etc.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
configure.ac | 3 ++
libweston/compositor-drm.c | 57
Since we now incrementally test atomic state as we build it, we can
loosen restrictions on what we can do with planes, and let the kernel
tell us whether or not it's OK.
Signed-off-by: Daniel Stone
Tested-by: Emre Ucan
---
libweston/compositor-drm.c | 21 +
1 file changed
so be used in a follow-patch, passing the list of modifiers
to GBM surface allocation to allow it to allocate more optimal buffers.
Signed-off-by: Sergi Granell
Reviewed-by: Daniel Stone
Tested-by: Emre Ucan
---
configure.ac | 3 +
libweston/compositor-d
701 - 800 of 9461 matches
Mail list logo
