Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22651
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22652
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22501#discussion_r223202914
--- Diff:
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -48,15 +48,11 @@ abstract class BenchmarkBase
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22652#discussion_r223202487
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/HashByteArrayBenchmark.scala
---
@@ -19,15 +19,23 @@ package org.apache.spark.sql
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22501#discussion_r223195740
--- Diff:
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -48,15 +48,11 @@ abstract class BenchmarkBase
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22651
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22487
What is the Hive behavior? I am thinking that `INSERT OVERWRITE LOCAL
DIRECTORY` should collect all data to the driver
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22551
@maropu `lz4 v1.8.3` is maintenance release. So the official does not
provide benchmarkï¼ https://github.com/lz4/lz4/releases/tag/v1.8.3
@srowen Yes, I think this can go in 3.0
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22652#discussion_r223187097
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/HashByteArrayBenchmark.scala
---
@@ -19,15 +19,22 @@ package org.apache.spark.sql
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22649
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22652
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22652
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22652
[SPARK-25658][SQL][TEST] Refactor HashByteArrayBenchmark to use main method
## What changes were proposed in this pull request?
Refactor `HashByteArrayBenchmark` to use main method
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22651
[SPARK-25488][SQL][TEST] Refactor HashBenchmark to use main method
## What changes were proposed in this pull request?
Refactor `HashBenchmark` to use main method.
Generate benchmark
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22632
@gatorsmile I have some confusion. Is this
https://github.com/apache/spark/blob/58c55cb4a6d72d72df908e37aa63f617b3cc5587/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22636
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22500
@dongjoon-hyun Is this ready to go?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22636
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22636
[SPARK-25629][TEST] Reduce ParquetFilterSuite: filter pushdown test time
costs in Jenkins
## What changes were proposed in this pull request?
Only these 4 writers is enough:
https
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22632
cc @gatorsmile @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22632
[SPARK-25606][TESTS] Reduce DateExpressionsSuite test time costs in Jenkins
## What changes were proposed in this pull request?
Reduce `DateExpressionsSuite.Hour` test time costs
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r222554828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class BRound(child
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22500
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22500
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22500
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22615
We can simplery this:
https://github.com/apache/spark/blob/7ad18ee9f26e75dbe038c6034700f9cd4c0e2baa/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala#L273-L295
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22488
Congratulation, @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22599
Thanks @gengliangwang I agree with you. Itâs a good change.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22488#discussion_r221780844
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -242,75 +249,22 @@ object DatasetBenchmark {
benchmark
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22488
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/22522
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22591#discussion_r221431453
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2300,6 +2300,60 @@ class Dataset[T] private[sql
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22581
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22580
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22580
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22484#discussion_r221416957
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SqlBasedBenchmark.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22587
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22522
cc @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user wangyum reopened a pull request:
https://github.com/apache/spark/pull/22522
[SPARK-25510][TEST] Create new trait replace BenchmarkWithCodegen
## What changes were proposed in this pull request?
We need create a new trait to replace `BenchmarkWithCodegen
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22484#discussion_r221397904
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SqlBasedBenchmark.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22579#discussion_r221296477
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
---
@@ -83,7 +83,7 @@ class SQLAppStatusListener
Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/22570
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22581#discussion_r221213500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -975,7 +975,7 @@ object SQLConf {
"check
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22443#discussion_r221183362
--- Diff: core/src/main/scala/org/apache/spark/util/BenchmarkBase.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22531
@HyukjinKwon @seancxmao will take it over:
[SPARK-25565](https://issues.apache.org/jira/browse/SPARK-25565
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22484
@dongjoon-hyun Other refactorings are waiting for this commit.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22579
[SPARK-25429][SQL] Use Set instead of Array to improve lookup performance
## What changes were proposed in this pull request?
Use `Set` instead of `Array` to improve
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22570
What do we do next?
1. Change `level` to `warning`and commit all changes. In this case
`dev/scalastyle` can pass, but IDEA will have a warning:
 to use
new trait
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22491
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22419
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22420
@hellodengfei Could you change the PR against `master` branch? This change
LGTM. I did a benchmark about `Set` and `Array`:
```scala
def benchmark(func: () => Unit): Long = {
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219660644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22491
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22488
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r219651627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -413,6 +413,7 @@ object Decimal {
val ROUND_HALF_EVEN
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22488
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22419
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22522
cc @cloud-fan @gengliangwang @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/22522
[SPARK-25510][TEST] Create new trait replace BenchmarkWithCodegen
## What changes were proposed in this pull request?
We need create a new trait to replace `BenchmarkWithCodegen
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22419
@ueshin Thanks a lot!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22490#discussion_r219543405
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
---
@@ -30,8 +30,13 @@ import
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22517
Do you mind close this PR. questions and help should be sent to
`u...@spark.apache.org`
```
u...@spark.apache.org is for usage questions, help, and announcements.
(subscribe) (unsubscribe
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22516
Yes. I hit this issue also.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r219490742
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -162,7 +162,8 @@ statement
tableIdentifier
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22500#discussion_r219404392
--- Diff: sql/core/benchmarks/MiscBenchmark-results.txt ---
@@ -0,0 +1,132
201 - 300 of 992 matches
Mail list logo
