Hi Krishna,
Usually these are caused by doing something on the wrong thread in my
experience. In our application we've had to be very careful about doing
things on the right thread. Mostly it's fine to create things off the app
thread and add them on the app thread, but that's not always the
On Thu, 16 Feb 2023 15:15:11 GMT, Dean Wookey wrote:
> Each time a menu would change scenes, a new set of ListChangeListeners would
> be added to the items in the menu. The bigger problem however is that these
> list change listeners have a strong reference to the scene which is
>
On Wed, 1 Mar 2023 13:36:46 GMT, Kevin Rushforth wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more comments and fixed IdentityWrapper hashcode.
>
> @arapte can you be the sec
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference
TableView).
>
> I'm looking at these issues, but I think they're dependent on this fix.
> Either I can add to this PR or I can wait to see what comes out of this and
> fix them subsequently.
Dean Wookey has updated the pull request incrementally with one additional
commit since the last re
On Wed, 22 Feb 2023 19:31:29 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Wed, 22 Feb 2023 19:21:41 GMT, Andy Goryachev wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Thu, 23 Feb 2023 09:26:29 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java
>> line 285:
>>
>>> 283: }
>>> 284:
>>> 285: private static void removeAcceleratorsFromScene(List>> MenuItem> items, Scene scene) {
Each time a menu would change scenes, a new set of ListChangeListeners would be
added to the items in the menu. The bigger problem however is that these list
change listeners have a strong reference to the scene which is potentially a
much bigger leak.
The first commit was more
On Fri, 4 Nov 2022 16:07:54 GMT, Dean Wookey wrote:
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButto
doesn't
> remove the additional instance.
>
> This pull request just removes the redundant code in the MenuButtonSkinBase.
Dean Wookey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commits:
- Implemented alternative
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
On Fri, 4 Nov 2022 19:51:53 GMT, Kevin Rushforth wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>>
On Mon, 7 Nov 2022 18:11:28 GMT, Dean Wookey wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java
>> line 154:
>>
>>> 152: sceneChangeListener = (scene, oldValue, newValue) -> {
>>> 153:
On Fri, 4 Nov 2022 21:14:20 GMT, Andy Goryachev wrote:
>> Dean Wookey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added changing scene tests for accelerator change listeners
>
> modules/javafx.contr
doesn't
> remove the additional instance.
>
> This pull request just removes the redundant code in the MenuButtonSkinBase.
Dean Wookey has updated the pull request incrementally with one additional
commit since the last revision:
Added changing scene tests for accelerator chang
When menu buttons are added and removed from the scene, an accelerator change
listener is added to each menu item in the menu. There is nothing stopping the
same change listener being added multiple times.
MenuButtonSkinBase calls the
Hi Andrea,
You can have a look at this post to see if it helps you.
https://stackoverflow.com/a/7316/4489577
Dean
On Tue, Jul 12, 2022 at 10:59 AM Andrea Vacondio
wrote:
> Hello,
> can anyone point me or tell me the current support regarding JavaFX drag
> and drop of Outlook attachments?
I'm having the same issue on Windows. I'm not really sure what's different
about my setup. Originally I thought it was failing every time, but every
now and then it gets past that and successfully builds for me. After
changing from JDK 15.0.2 to 16.0.2 it worked, but that's when I realised it
was
We would be very interested in this. We've tried to implement some of these
native behaviours ourselves, but there are plenty of holes and we only
support Windows. There are also some bugs which could potentially be
addressed by this, for example
https://bugs.openjdk.java.net/browse/JDK-810.
Hi David,
We experimented with some changes last year which we've been running. We
haven't noticed any problems and we do get some good memory and speed
enhancements.. I've been meaning to clean it up before considering a pull
request, but since this is a delicate area, I've procrastinated a bit
On Mon, 24 Feb 2020 19:36:47 GMT, Kevin Rushforth wrote:
>> This is a fix for an intermittent test failure affecting
>> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in
>> `test.javafx.scene.CssStyleHelperTest`, which was added as part of
>>
On Sat, 22 Feb 2020 15:54:16 GMT, Kevin Rushforth wrote:
>> This is a fix for an intermittent test failure affecting
>> `test.javafx.scene.layout.RegionCSSTest`. This turns out to be a test bug in
>> `test.javafx.scene.CssStyleHelperTest`, which was added as part of
>>
> Everything passes with the fix and 5 of the new tests fail without the fix.
>
> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
> movingBranchToDifferentBranchGetsNewCssVariableTest
> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
>
> Everything passes with the fix and 5 of the new tests fail without the fix.
>
> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
> movingBranchToDifferentBranchGetsNewCssVariableTest
> removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
>
On Wed, 22 Jan 2020 15:00:14 GMT, David Grieve wrote:
>> Everything passes with the fix and 5 of the new tests fail without the fix.
>>
>> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
>> movingBranchToDifferentBranchGetsNewCssVariableTest
>>
On Fri, 17 Jan 2020 18:42:34 GMT, Kevin Rushforth wrote:
>> I mentioned this in the JBS bug as well: I suspect that
>> [JDK-8234877](https://bugs.openjdk.java.net/browse/JDK-8234877) has the same
>> root cause as this one. Can you run the HelloCSS test program as described
>> in that bug with
Everything passes with the fix and 5 of the new tests fail without the fix.
removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest
movingBranchToDifferentBranchGetsNewCssVariableTest
removingThenAddingNodeToDifferentBranchGetsCorrectInheritedValue
lse if the set of styles for
> the
> new parent (line 110 or so in CssStyleHelper.java) are different.
>
> > -Original Message-
> > From: openjfx-dev On Behalf Of
> > Dean Wookey
> > Sent: Thursday, January 16, 2020 11:34 AM
> > To: openjfx-dev@open
Hi Ajit, David,
I came accross a potential issue introduced by JDK-8090462 (
https://bugs.openjdk.java.net/browse/JDK-8090462), (
https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab).
The issue is in the canReuseStyleHelper method.
On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote:
> On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote:
>
>> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote:
>>
>>> On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve
>>> wrote:
>>>
On Wed, 13 Nov 2019 19:10:45 GMT, David Grieve
wrote:
> On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote:
>
>> On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote:
>>
>>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote:
>>>
**Issue :**
Hi,
Please review the fix for JDK-8221691: CSS font caching could be improved
https://bugs.openjdk.java.net/browse/JDK-8221691
https://github.com/javafxports/openjdk-jfx/pull/424
Dean
heard nothing back. Should I create a bug report myself since I have
author status now? Should I just create a pull request on github to discuss
the implementation there, and link the bug report later?
Dean
On Fri, Jan 18, 2019 at 10:28 AM Dean Wookey wrote:
> I've only tested with our applicat
Returning a boolean in View.notifyKey may also be useful for the windows
bug: https://bugs.openjdk.java.net/browse/JDK-8089986 where, regardless of
whether the accelerator is missing or not, there is a beeping sound.
Ideally there would be a beep only if the event isn't consumed.
Dean
On Tue,
Hi,
Please review the fix for JDK-8088717: Win: UNDECORATED windows are not
minimized with the taskbar button
https://bugs.openjdk.java.net/browse/JDK-8088717
https://bugs.openjdk.java.net/browse/JDK-8089296
https://github.com/javafxports/openjdk-jfx/pull/398
Dean
Hi,
Please review the fix for JDK-8089986: Menu beeps when mnemonics is used
https://bugs.openjdk.java.net/browse/JDK-8089986
https://github.com/javafxports/openjdk-jfx/pull/397
Dean
Hi,
On Windows, a beep sound always plays when using accelerators/mnemonics
with the alt key, even if those accelerators exist. It's only supposed to
beep when no such key combination is registered.
I've found a solution which never beeps which I believe is preferable,
however I'm a bit out of
ngs
> like changing -fx-font in some parent, or setting the font property in some
> parent? What about popups? If I have a tooltip on a Label, for example,
> does the tooltip properly pick up font from the Label's style or font
> property?
> On 1/17/19 11:10 AM, Dean Wookey wrote:
>
&g
The last time the issue was discussed was in November. You can see the
thread here:
https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-November/022837.html
I too would like to see this and other performance issues addressed
(although our actual biggest priority is mobile). Right now my team
lt font down the scene-graph as styles are evaluated.
>> There are other style lookups that could benefit from this as well,
>> resolving looked-up colors for example. I believe I created a bug for this
>> a long time ago.
>>
>>
>>
>> On 4/19/18 5
Hi,
Please review the fix for JDK-8213619: Windows powershell build script
missing environment variables:
https://bugs.openjdk.java.net/browse/JDK-8213619
https://github.com/javafxports/openjdk-jfx/pull/276
Dean
Hi Johan,
Michael's build script helped me a lot. I'm on windows 10. It just runs in
powershell after installing chocolatey, (.\tools\scripts\build1.ps from the
openjdk root dir). The only environment variables I've got set are
JAVA_HOME/JDK_HOME. I did have to make some modifications however to
Hi,
I just wanted to clarify a few things about the fix. The test I showed
hints at a potentially safer way to implement the fix for this problem. One
would expect adding nodes 1 by 1 to the scene graph to be less efficient
than adding them all at once, but it's far worse to add them all at once.
Hi,
I was going to ask if it was possible to reopen JDK-8151756 (
https://bugs.openjdk.java.net/browse/JDK-8151756) since it was fixed but
reverted in JDK-8183100 (https://bugs.openjdk.java.net/browse/JDK-8183100)
after causing several regressions. I only noticed now that a followup bug
was
Hi,
I got jpackager working with OpenJDK11.0.1 after a bit of trial and error.
I'm now able to create a windows image like I had before with javapackager.
I thought I'd share some of the issues I've had in case it helps anyone out.
The first one was that you need to copy jdk.packager.jar not
Hi All,
In our application we add and remove a lot of nodes to the scene graph
regularly, and also make use of em font sizes to scale certain parts of our
application. We've noticed performance issues when adding nodes to the
scene, and it seems to be related to em sizes in our css.
As a test we
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235686#comment-16235686
]
Dean Wookey commented on LOG4J2-2058:
-
I added the same test and everything passed. I wasn't able
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dean Wookey updated LOG4J2-2058:
Description:
When using the JUL log manager, setting the java.locale.providers property to
"
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dean Wookey updated LOG4J2-2058:
Description:
When using the JUL log manager, setting the java.locale.providers property to
"
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187727#comment-16187727
]
Dean Wookey commented on LOG4J2-2058:
-
See here for why this setting is necessary:
https
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dean Wookey updated LOG4J2-2058:
Description:
When using the JUL log manager, setting the java.locale.providers property to
"
Dean Wookey created LOG4J2-2058:
---
Summary: java.locale.providers set to HOST causes Log4j2 to crash
in Java 9
Key: LOG4J2-2058
URL: https://issues.apache.org/jira/browse/LOG4J2-2058
Project: Log4j 2
[
https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dean Wookey updated LOG4J2-2058:
Description:
When using the JUL log manager, setting the java.locale.providers property to
"
56 matches
Mail list logo
