Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19966
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19966
@felixcheung @cloud-fan @vanzin @susanxhuynh @gatorsmile @ArtRand Here is
the new PR
---
-
To unsubscribe, e-mail: reviews
GitHub user Gschiavon opened a pull request:
https://github.com/apache/spark/pull/19966
Fix submission request
## What changes were proposed in this pull request?
PR closed with all the comments ->
https://github.com/apache/spark/pull/19793
It solves the prob
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19793
Hi @vanzin ! I just fixed it and pushed it to my branch but it's not
opening the PR, maybe I need to do a new one
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r154072747
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153901749
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153709924
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153415074
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153414519
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153410771
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala
---
@@ -82,6 +82,12 @@ private[mesos] class
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153410217
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolRequest.scala
---
@@ -46,6 +46,8 @@ private[rest] class
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19793
Yes @ArtRand! I think it's not documented at all, ping me when it's done
and I will review it :)
---
-
To unsubscribe
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19793
can we retest this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153131125
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19793
ping @ArtRand
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user Gschiavon opened a pull request:
https://github.com/apache/spark/pull/19793
[SPARK-22574] [Mesos] [Submit] Check submission request parameters
## What changes were proposed in this pull request?
It solving the problem when submitting a wrong
GitHub user Gschiavon opened a pull request:
https://github.com/apache/spark/pull/19205
[SPARK-21982] Set locale to US
## What changes were proposed in this pull request?
In UtilsSuite Locale was set by default to US, but at the format time it
wasn't, taking by default JVM
Github user Gschiavon closed the pull request at:
https://github.com/apache/spark/pull/19200
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19200
Ok, I got it. I will do that then.
Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user Gschiavon commented on the issue:
https://github.com/apache/spark/pull/19200
As far as I saw there are other test cases that set default locale to US.
This case is not passing when your jvm default locale value differs from &qu
GitHub user Gschiavon opened a pull request:
https://github.com/apache/spark/pull/19200
Set default Locale
## What changes were proposed in this pull request?
Get default Locale in UtilsSuite.scala in order to make it work with
different Locales than US.
## How
21 matches
Mail list logo
