This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch ARROW-17715a
in repository https://gitbox.apache.org/repos/asf/arrow.git
from 019740ad9f change LLVM version
add 145e167753 disable JEMALLOC and PLASMA
No new revisions were added
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch ARROW-17715a
in repository https://gitbox.apache.org/repos/asf/arrow.git
from 194f3f249a add CLANG_TOOLS
add 019740ad9f change LLVM version
No new revisions were added by this update
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch ARROW-17715a
in repository https://gitbox.apache.org/repos/asf/arrow.git
from 0f753003a1 disable to build COMPUTE and GANDIVA
add 194f3f249a add CLANG_TOOLS
No new revisions were added
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch ARROW-17715a
in repository https://gitbox.apache.org/repos/asf/arrow.git
at 0f753003a1 disable to build COMPUTE and GANDIVA
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to branch ARROW-17715a
in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 0f753003a1557c4e554ea879464ca001888e5c2f
Author: Kazuaki Ishizaki
AuthorDate: Mon Jan 9 04:01:38 2023 -0500
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to branch issue270
in repository https://gitbox.apache.org/repos/asf/arrow-julia.git
commit 8bc9510d21b27ebdf6d10e8bd57d553287f066b0
Author: ishizaki
AuthorDate: Mon Jan 17 16:18:06 2022 +
initial
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch issue270
in repository https://gitbox.apache.org/repos/asf/arrow-julia.git.
at 8bc9510 initial draft
This branch includes the following new commits:
new 8bc9510 initial draft
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git.
from dbb5b42 ARROW-13194: [Java][Document] Create prose document about
Java algorithms
add 3968146 ARROW-13032
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-site.git
The following commit(s) were added to refs/heads/master by this push:
new 0a542fd ARROW-13047: [Website] Add kiszk
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git.
from b81fcf7 ARROW-13068: [GLib][Dataset] Change prefix to gdataset_ from
gad_
add 5173af0 ARROW-13026: [CI] Use
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to branch Arrow-13047
in repository https://gitbox.apache.org/repos/asf/arrow-site.git
commit f4fbc497212b4ca44e5c09482187b3ba41c1d243
Author: ishizaki
AuthorDate: Fri Jun 11 07:52:43 2021 +
add
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch Arrow-13047
in repository https://gitbox.apache.org/repos/asf/arrow-site.git.
at f4fbc49 add kiszk as a committer
This branch includes the following new commits:
new f4fbc49 add
Author: kiszk
Date: Mon Aug 26 17:18:45 2019
New Revision: 35381
Log:
Update KEYS
Modified:
dev/spark/KEYS
Modified: dev/spark/KEYS
==
--- dev/spark/KEYS (original)
+++ dev/spark/KEYS Mon Aug 26 17:18:45 2019
Author: kiszk
Date: Mon Aug 26 09:54:45 2019
New Revision: 35371
Log:
Apache Spark v2.3.4-rc1 docs
[This commit notification would consist of 1447 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary
Author: kiszk
Date: Mon Aug 26 09:00:20 2019
New Revision: 35370
Log:
Apache Spark v2.3.4-rc1
Added:
dev/spark/v2.3.4-rc1-bin/
dev/spark/v2.3.4-rc1-bin/SparkR_2.3.4.tar.gz (with props)
dev/spark/v2.3.4-rc1-bin/SparkR_2.3.4.tar.gz.asc
dev/spark/v2.3.4-rc1-bin/SparkR_2.3.4
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to tag v2.3.4-rc1
in repository https://gitbox.apache.org/repos/asf/spark.git
commit 8c6f8150f3c6298ff4e1c7e06028f12d7eaf0210
Author: Kazuaki Ishizaki
AuthorDate: Sun Aug 25 14:38:17 2019 +
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/spark.git
commit 3fb9e84c7a5ed6c7bde7a6c64cdeda974734dbc5
Author: Kazuaki Ishizaki
AuthorDate: Sun Aug 25 14:38:22 2019 +
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/spark.git.
from adb5255 [SPARK-26895][CORE][2.3] prepareSubmitEnvironment should be
called within doAs for proxy users
add
This is an automated email from the ASF dual-hosted git repository.
kiszk pushed a change to tag v2.3.4-rc1
in repository https://gitbox.apache.org/repos/asf/spark.git.
at 8c6f815 (commit)
This tag includes the following new commits:
new 8c6f815 Preparing Spark release v2.3.4-rc1
Author: kiszk
Date: Mon Aug 19 18:04:54 2019
New Revision: 35304
Log:
Update KEYS
Modified:
dev/spark/KEYS
Modified: dev/spark/KEYS
==
--- dev/spark/KEYS (original)
+++ dev/spark/KEYS Mon Aug 19 18:04:54 2019
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23262
Good catch, LGTM
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23226
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23239
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23239
The change looks fine.
Do we already have tests for cases 2 and 4? We know test for case 3 is
[here](https://github.com/apache/spark/pull/23043
Github user kiszk closed the pull request at:
https://github.com/apache/spark/pull/21777
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23206
cc @viirya @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23206#discussion_r238776051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -235,10 +235,127 @@ abstract class Optimizer
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23190
LGTM excepts two comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23190#discussion_r238123212
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -24,7 +24,8 @@ import com.esotericsoftware.kryo.io.{Input
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23190
Is this follow-up of #23084?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23190
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23199
cc @maropu @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23199
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23146#discussion_r238104839
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularization.scala
---
@@ -82,7 +82,72 @@ private[ml] class L2Regularization
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238062387
--- Diff:
core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala ---
@@ -37,7 +37,7 @@ import org.apache.spark.internal.Logging
* tasks
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23194#discussion_r238062396
--- Diff:
core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala ---
@@ -28,7 +28,7 @@ import org.apache.spark.storage.memory.MemoryStore
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23194
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23194
Good catch
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23177
Sure, updated. Thanks for letting know them.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23154
LGTM cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23177
I thought that it is automatically done by `build/mvn`, as you pointed out
[before](https://github.com/apache/spark/pull/21905#issuecomment-408678119
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23177
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23176
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23176
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/23177
[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0
## What changes were proposed in this pull request?
This PR updates maven version from 3.5.4 to 3.6.0. The release note
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23124
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23154#discussion_r236919935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -258,7 +258,7 @@ case class GeneratorOuter(child
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23154#discussion_r236919395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -204,10 +204,10 @@ case class UnresolvedGenerator(name
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23154
@lcqzte10192193 I am sorry for my misunderstanding The original code in
`VectorizedRleValuesReader.java` was correct. Could you please revert you
change
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r236912228
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r236912182
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23151
Good catch
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23154
Good catch. I believe other files (e.g. `VectorizedRleValuesReader.java`,
`Expression.scala`, and `generators.scala` also have the similar problem. Can
this PR address them
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236376102
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -89,7 +89,7 @@ class DataFrameFunctionsSuite extends QueryTest
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23141
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236284636
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23137
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23135
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23135#discussion_r236104602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -43,9 +43,24 @@ import org.apache.spark.sql.types
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23135#discussion_r236103936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -43,9 +43,24 @@ import org.apache.spark.sql.types
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22512
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23022
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23102#discussion_r235975268
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -61,11 +62,12 @@ private[deploy] object DependencyUtils extends Logging
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23102
@MaxGekk This PR may change a separator for `userJar` that has `\` on
Windows. `resolveGlobPaths` is not applied to `userJar
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235952965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235950666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235950148
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235947044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r235943290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -751,171 +739,46 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23101
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23102
Would it be possible to update the PR description based on the template?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23102
Thank you for submitting a PR to fix hard coded character. Is this only one
that we have to fix regarding this hard coded character
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23101
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23101
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23084
I think that we need to take care of
`UnsafeExternalSorterSuite.testGetIterator`, too.
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23043
Do we need to consider `GenerateSafeProjection`, too? In other words, if
the generated code or runtime does not use data in `Unsafe`, this `+0.0/-0.0`
problem may still exist.
Am I correct
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23043
Is it better to update this PR title now?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23043
@srowen #21794 is what I thought.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22779#discussion_r234204540
--- Diff:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
@@ -497,6 +498,17 @@ class KryoSerializerAutoResetDisabledSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23039#discussion_r234202827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1594,6 +1594,13 @@ object SQLConf {
"WHERE, which
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r233951725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -56,17 +56,32 @@ case class BoundReference
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r233951670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -56,17 +56,32 @@ case class BoundReference
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23043
IIUC, we discussed handling `+0.0` and `-0.0` before in another PR.
@srowen do you remember the previous discussion
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23044
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22976
gentle ping @rednaxelafx
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22976
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22976
cc @cloud-fan @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22993#discussion_r232488912
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -67,6 +67,59 @@
unaligned = _unaligned
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23005
Files under `dev/deps/` should be updated, too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22954#discussion_r232453690
--- Diff: R/pkg/R/SQLContext.R ---
@@ -147,6 +147,55 @@ getDefaultSqlSource <- function() {
l[["spark.sql.sources
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22998
I have two questions.
1. Is this PR already tested with `"SPARK-25538: zero-out all bits for
decimals"`?
2. How does this PR achieve performance improvement? This PR may intro
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,50 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -133,7 +126,6 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r232443205
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -154,7 +146,6 @@ object
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22985
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22976
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231886019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231886071
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22976#discussion_r231885902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -68,57 +68,51 @@ object
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22976
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
1 - 100 of 3585 matches
Mail list logo
