Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/21849
@vanzin addressed your comments and updated the PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214110048
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java ---
@@ -17,6 +17,8 @@
package org.apache.spark.launcher
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214109949
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -46,6 +47,18 @@ public synchronized void disconnect
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r214109901
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -227,6 +220,82 @@ public void testInProcessLauncherDoesNotKillJvm
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/21849
@vanzin could you take a look? I'm not sure if the same race conditions
present in the other unit tests apply to the new ones since no `SparkContext`
is being created. For now I didn't add any
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/21849
[SPARK-24243][CORE] Expose exceptions from InProcessAppHandle
## What changes were proposed in this pull request?
Adds a new method to `SparkAppHandle` called `getError` which returns
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/20893
Wrote a test in `SparkLauncherSuite` and was able to replicate the error
from HIVE-18533, and then realized the exception is only logged and then
swallowed. From `SparkContext
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/20893#discussion_r177577783
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/20893
Ok, I'll work on writing a test for `SparkLauncherSuite`.
The test added here was meant to cover the race condition mentioned
[here|https://spark.apache.org/docs/2.3.0/sql-programming
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/20893#discussion_r177208050
--- Diff:
core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
@@ -114,10 +114,10 @@ private[spark] abstract class LauncherBackend
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/20893
[SPARK-23785][LAUNCHER] LauncherBackend doesn't check state of connection
before setting state
## What changes were proposed in this pull request?
Changed `LauncherBackend` `set
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/20815
[SPARK-23658][LAUNCHER] InProcessAppHandle uses the wrong class in getLogger
## What changes were proposed in this pull request?
Changed `Logger` in `InProcessAppHandle` to use
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/19413#discussion_r142499531
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -157,20 +157,23 @@ class HadoopRDD[K, V](
if (conf.isInstanceOf
Github user sahilTakiar commented on a diff in the pull request:
https://github.com/apache/spark/pull/19413#discussion_r142466295
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -157,20 +157,23 @@ class HadoopRDD[K, V](
if (conf.isInstanceOf
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/19413
Fixed the style check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/19413
[SPARK-20466][CORE] HadoopRDD#addLocalConfiguration throws NPE
## What changes were proposed in this pull request?
Fix for SPARK-20466, full description of the issue in the JIRA
Github user sahilTakiar closed the pull request at:
https://github.com/apache/spark/pull/17499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/17499
Sounds like we agree that if this should be done, it should be done in
Hive. We have an open JIRA (HIVE-13517) to address this.
If there are no other comments, I'll close this PR
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/17499
Thanks for taking look everyone. The original motivation for this PR comes
[HIVE-13517](https://issues.apache.org/jira/browse/HIVE-13517). It was said to
be useful for debugging HoS
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/17499
I'm not sure how the community feels about adding this to the default log4j
files, so posting this as a reference for now. Some more details are in the
JIRA, but this can improve debugabbility
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/17499
[SPARK-20161][CORE] Default log4j properties file should print thread-id in
ConversionPattern
## What changes were proposed in this pull request?
Change the default log4j properties
21 matches
Mail list logo
