Re: [I] Servicecomb 3.0.2 客户端使用 三方调用, 请求头 Authorization 好像无法远程调用传参 [servicecomb-java-chassis]

2024-05-10 Thread via GitHub
heyile commented on issue #4334: URL: https://github.com/apache/servicecomb-java-chassis/issues/4334#issuecomment-2104608513 @liubao68 宝哥, 抽空可以帮忙看下, 是不是类似场景后面, 就不要用 RPC了, 只用 REST -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat(java): support deserialization ignoreEnumDeserializeError [incubator-fury]

2024-05-10 Thread via GitHub
chaokunyang commented on code in PR #1623: URL: https://github.com/apache/incubator-fury/pull/1623#discussion_r1596751051 ## java/fury-core/src/main/java/org/apache/fury/config/Config.java: ## @@ -54,6 +54,7 @@ public class Config implements Serializable { private final

Re: [PR] KAFKA-16695: Improve expired poll logging [kafka]

2024-05-10 Thread via GitHub
lianetm commented on code in PR #15909: URL: https://github.com/apache/kafka/pull/15909#discussion_r1596716965 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -193,11 +193,12 @@ public NetworkClientDelegate.PollResult

Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]

2024-05-10 Thread via GitHub
ByteYue commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2104607522 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump logback.version from 1.3.14 to 1.5.6 [commons-logging]

2024-05-10 Thread via GitHub
garydgregory commented on PR #247: URL: https://github.com/apache/commons-logging/pull/247#issuecomment-2104607027 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Downgrade the version of Apache Curator from 5.5.0 to 5.3.0 to avoid a bug in the new version (druid)

2024-05-10 Thread via GitHub
gianm commented on PR #16425: URL: https://github.com/apache/druid/pull/16425#issuecomment-2104605453 Are there any fixes in Curator 5.4 or 5.5 for other bugs that would be important for us? I ask since if yes- we could stay with the newer Curator and work around this bug, such as by

Re: [I] `Rendered Template` link missing from `Details` tab [airflow]

2024-05-10 Thread via GitHub
tirkarthi commented on issue #39527: URL: https://github.com/apache/airflow/issues/39527#issuecomment-2104605544 It has been made as a separate section in 2.9.1 in this PR. I guess the removal was intentional. https://github.com/apache/airflow/pull/39122 cc: @bbovenzi --

Re: [PR] [fix][cdc] fix uid conflicts during multi-database synchronization. [doris-flink-connector]

2024-05-10 Thread via GitHub
JNSimba commented on code in PR #382: URL: https://github.com/apache/doris-flink-connector/pull/382#discussion_r1596749154 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -177,11 +179,20 @@ public void build() throws Exception {

Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2104606954 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[I] Servicecomb 3.0.2 客户端使用 三方调用, 请求头 Authorization 好像无法远程调用传参 [servicecomb-java-chassis]

2024-05-10 Thread via GitHub
heyile opened a new issue, #4334: URL: https://github.com/apache/servicecomb-java-chassis/issues/4334 ```java @Primary @Bean public RegistryBean thirdRegistry() { String endpoint = "rest://10.70.107.243:8004?sslEnabled=false"; String version =

Re: [PR] Create a SteadyTime type in the Manager [accumulo]

2024-05-10 Thread via GitHub
cshannon commented on code in PR #4494: URL: https://github.com/apache/accumulo/pull/4494#discussion_r1596749727 ## server/manager/src/test/java/org/apache/accumulo/manager/ManagerTimeTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [I] Explore comparing file values in requireSame [accumulo]

2024-05-10 Thread via GitHub
dlmarion commented on issue #3522: URL: https://github.com/apache/accumulo/issues/3522#issuecomment-2104604165 Closed by #4486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat(java): register old version guava collect [incubator-fury]

2024-05-10 Thread via GitHub
chaokunyang merged PR #1622: URL: https://github.com/apache/incubator-fury/pull/1622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6784: URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2104604443 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [I] Explore comparing file values in requireSame [accumulo]

2024-05-10 Thread via GitHub
dlmarion closed issue #3522: Explore comparing file values in requireSame URL: https://github.com/apache/accumulo/issues/3522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] checks the entire map, solves #3522 [accumulo]

2024-05-10 Thread via GitHub
dlmarion closed pull request #4175: checks the entire map, solves #3522 URL: https://github.com/apache/accumulo/pull/4175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] checks the entire map, solves #3522 [accumulo]

2024-05-10 Thread via GitHub
dlmarion commented on PR #4175: URL: https://github.com/apache/accumulo/pull/4175#issuecomment-2104603308 Superceded by #4486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2104603230 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [MSHARED-1393] Allow to exclude classes from verification [maven-dependency-analyzer]

2024-05-10 Thread via GitHub
garydgregory commented on PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118#issuecomment-2104602026 Hello @slawekjaranowski TY for the heads up. OK, I'll adapt when this trickles down. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-10 Thread via GitHub
potiuk commented on PR #39513: URL: https://github.com/apache/airflow/pull/39513#issuecomment-2104601029 Ok. We are down to 4 errors. The remaining issues are: * serialization `__var` issue * executor compatibility and * openlineage enablement/configuration * try_num impact

Re: [PR] Added DataFileValue to SetEqualityIterator checks in conditional mutations [accumulo]

2024-05-10 Thread via GitHub
dlmarion merged PR #4486: URL: https://github.com/apache/accumulo/pull/4486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] apr_file_pipe_create() - save more syscalls with pipe2() [apr]

2024-05-10 Thread via GitHub
notroj opened a new pull request, #56: URL: https://github.com/apache/apr/pull/56 ``` * file_io/unix/pipe.c (file_pipe_create): Use pipe2(,O_NONBLOCK) by default unless APR_FULL_BLOCK was used; unconditionally set the blocking state later. Saves two syscalls per invocation for

Re: [PR] Adding compartment id to all oci items, adding new item types [netbeans]

2024-05-10 Thread via GitHub
sdedic commented on code in PR #7371: URL: https://github.com/apache/netbeans/pull/7371#discussion_r1596698296 ## enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DownloadWalletDialog.java: ## @@ -335,6 +337,10 @@ public char[] getDbPassword() {

Re: [PR] Advoid the use of ImpactsDISI when no minimum competitive score has been set [lucene]

2024-05-10 Thread via GitHub
jpountz commented on PR #13343: URL: https://github.com/apache/lucene/pull/13343#issuecomment-2104599812 @zhongshanhao Are you still observing a speedup with the latest version of the change? I was planning on merging once you confirmed this. -- This is an automated message from the

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-10 Thread via GitHub
hadoop-yetus commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2104599790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Create a SteadyTime type in the Manager [accumulo]

2024-05-10 Thread via GitHub
cshannon commented on code in PR #4494: URL: https://github.com/apache/accumulo/pull/4494#discussion_r1596638898 ## server/manager/src/test/java/org/apache/accumulo/manager/ManagerTimeTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj opened a new pull request, #5891: URL: https://github.com/apache/hbase/pull/5891 https://issues.apache.org/jira/browse/HBASE-28576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Removing fluent interface from DROOLS kie api [incubator-kie-issues]

2024-05-10 Thread via GitHub
elguardian closed issue #1186: Removing fluent interface from DROOLS kie api URL: https://github.com/apache/incubator-kie-issues/issues/1186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Refactor AlterSQLParserRuleExecutorTest Test Case [shardingsphere]

2024-05-10 Thread via GitHub
ilyasahsan123 opened a new pull request, #31199: URL: https://github.com/apache/shardingsphere/pull/31199 Fixes #30083. Changes proposed in this pull request: - Refactor AlterSQLParserRuleExecutorTest Test Case --- Before committing this PR, I'm sure that I have

Re: [PR] [incubator-kie-issues-1186] Removing fluent interface from DROOLS kie api [incubator-kie-drools]

2024-05-10 Thread via GitHub
elguardian merged PR #5923: URL: https://github.com/apache/incubator-kie-drools/pull/5923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Create a SteadyTime type in the Manager [accumulo]

2024-05-10 Thread via GitHub
keith-turner commented on code in PR #4494: URL: https://github.com/apache/accumulo/pull/4494#discussion_r1596742581 ## server/manager/src/test/java/org/apache/accumulo/manager/ManagerTimeTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [I] [Improvement]: Improve the version info about the project [amoro]

2024-05-10 Thread via GitHub
XBaith closed issue #2813: [Improvement]: Improve the version info about the project URL: https://github.com/apache/amoro/issues/2813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [AMORO-2813] Improve the version info about the project [amoro]

2024-05-10 Thread via GitHub
XBaith merged PR #2821: URL: https://github.com/apache/amoro/pull/2821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-10 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1596742249 ## tests/listeners/class_listener.py: ## @@ -47,9 +47,7 @@ def on_task_instance_success(self, previous_state, task_instance, session):

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-10 Thread via GitHub
dsmiley commented on PR #2451: URL: https://github.com/apache/solr/pull/2451#issuecomment-2104595444 Alternatively I rather like the title here: > allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled -- This is an

Re: [PR] Bump org.apache.maven.plugins:maven-plugin-plugin from 3.12.0 to 3.13.0 [commons-build-plugin]

2024-05-10 Thread via GitHub
garydgregory merged PR #258: URL: https://github.com/apache/commons-build-plugin/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add compatibility note for Listeners [airflow]

2024-05-10 Thread via GitHub
potiuk merged PR #39544: URL: https://github.com/apache/airflow/pull/39544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48143][SQL] Use lightweight exceptions for control-flow between UnivocityParser and FailureSafeParser [spark]

2024-05-10 Thread via GitHub
cloud-fan commented on code in PR #46500: URL: https://github.com/apache/spark/pull/46500#discussion_r1596740941 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/BadRecordException.scala: ## @@ -67,16 +67,30 @@ case class PartialResultArrayException( extends

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-10 Thread via GitHub
dsmiley commented on PR #2451: URL: https://github.com/apache/solr/pull/2451#issuecomment-2104592896 Thinking of wording for CHANGES.txt: > Improved disambiguation of atomic updates from child docs for JSON based updates (not an issue for other formats). > Multiple atomic updates

Re: [PR] feat: add experimental support for QUIC transport [rocketmq-mqtt]

2024-05-10 Thread via GitHub
lizhanhui merged PR #260: URL: https://github.com/apache/rocketmq-mqtt/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [WIP][SPARK-48221][SQL] Alter string search logic for UTF8_BINARY_LCASE collation [spark]

2024-05-10 Thread via GitHub
uros-db commented on code in PR #46511: URL: https://github.com/apache/spark/pull/46511#discussion_r1596739181 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -183,6 +192,22 @@ public static int findInSet(final UTF8String

Re: [PR] [pipeline](fix) Avoid to use a freed dependency when cancelled [doris]

2024-05-10 Thread via GitHub
Gabriel39 commented on PR #34584: URL: https://github.com/apache/doris/pull/34584#issuecomment-2104591852 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump org.apache.maven.plugins:maven-plugin-plugin from 3.12.0 to 3.13.0 [commons-build-plugin]

2024-05-10 Thread via GitHub
garydgregory commented on PR #258: URL: https://github.com/apache/commons-build-plugin/pull/258#issuecomment-2104590854 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Support Java 21 [daffodil]

2024-05-10 Thread via GitHub
pkatlic merged PR #1236: URL: https://github.com/apache/daffodil/pull/1236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Buffer should support split, split_to and split_off [opendal]

2024-05-10 Thread via GitHub
Xuanwo opened a new issue, #4593: URL: https://github.com/apache/opendal/issues/4593 Buffer doesn't provide split related API makes it hard to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [WIP][SPARK-48221][SQL] Alter string search logic for UTF8_BINARY_LCASE collation [spark]

2024-05-10 Thread via GitHub
uros-db commented on code in PR #46511: URL: https://github.com/apache/spark/pull/46511#discussion_r1596738413 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,15 @@ * Utility class for collation-aware UTF8String

Re: [PR] add k8s port check [pekko-samples]

2024-05-10 Thread via GitHub
pjfanning commented on code in PR #106: URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596738046 ## pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf: ## @@ -33,4 +33,9 @@ pekko.management { example-ready =

Re: [PR] add k8s port check [pekko-samples]

2024-05-10 Thread via GitHub
Roiocam commented on code in PR #106: URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596736920 ## pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf: ## @@ -33,4 +33,9 @@ pekko.management { example-ready =

Re: [PR] Bump org.apache.maven.plugin-tools:maven-script-ant from 3.12.0 to 3.13.0 [commons-build-plugin]

2024-05-10 Thread via GitHub
garydgregory merged PR #259: URL: https://github.com/apache/commons-build-plugin/pull/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] add k8s port check [pekko-samples]

2024-05-10 Thread via GitHub
Roiocam commented on code in PR #106: URL: https://github.com/apache/pekko-samples/pull/106#discussion_r1596736920 ## pekko-sample-cluster-kubernetes-java/src/main/resources/application.conf: ## @@ -33,4 +33,9 @@ pekko.management { example-ready =

Re: [PR] Bump org.apache.maven.plugin-tools:maven-plugin-tools-ant from 3.12.0 to 3.13.0 [commons-build-plugin]

2024-05-10 Thread via GitHub
garydgregory merged PR #260: URL: https://github.com/apache/commons-build-plugin/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update standard_task_runner.py [airflow]

2024-05-10 Thread via GitHub
potiuk commented on PR #39543: URL: https://github.com/apache/airflow/pull/39543#issuecomment-2104588234 Yep. I think this is is an oportunity to send a user on a GOOD path (or at least explain various reasons and possibly send the user to some troubleshooting documentation). Otherwise

Re: [PR] NIFI-13172 deprecated nifi kafka connect components [nifi]

2024-05-10 Thread via GitHub
exceptionfactory commented on PR #8803: URL: https://github.com/apache/nifi/pull/8803#issuecomment-2104587621 Merged in https://github.com/apache/nifi/commit/cf199a6b8bcbaabaf47153572189b844bc3dade6 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] NIFI-13172 deprecated nifi kafka connect components [nifi]

2024-05-10 Thread via GitHub
exceptionfactory closed pull request #8803: NIFI-13172 deprecated nifi kafka connect components URL: https://github.com/apache/nifi/pull/8803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [WIP][SPARK-48221][SQL] Alter string search logic for UTF8_BINARY_LCASE collation [spark]

2024-05-10 Thread via GitHub
uros-db commented on code in PR #46511: URL: https://github.com/apache/spark/pull/46511#discussion_r1596735843 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,15 @@ * Utility class for collation-aware UTF8String

[PR] Remove keyboard shortcut from terminal close action [netbeans]

2024-05-10 Thread via GitHub
neilcsmith-net opened a new pull request, #7372: URL: https://github.com/apache/netbeans/pull/7372 Remove keyboard shortcut from terminal close action due to multiple conflicts. While testing the dashboard on macOS I noticed that the terminal close action shortcut clashes with the

Re: [PR] [WIP][SPARK-48221][SQL] Alter string search logic for UTF8_BINARY_LCASE collation [spark]

2024-05-10 Thread via GitHub
uros-db commented on code in PR #46511: URL: https://github.com/apache/spark/pull/46511#discussion_r1596734094 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -118,7 +118,9 @@ public static boolean execBinary(final UTF8String l,

Re: [PR] Bump slf4j.version from 2.0.12 to 2.0.13 [commons-vfs]

2024-05-10 Thread via GitHub
garydgregory merged PR #524: URL: https://github.com/apache/commons-vfs/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-13171 removed nifi-external module containing nifi kafka connect… [nifi]

2024-05-10 Thread via GitHub
exceptionfactory closed pull request #8800: NIFI-13171 removed nifi-external module containing nifi kafka connect… URL: https://github.com/apache/nifi/pull/8800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] NIFI-13205 removed legacy integration test and binary test artifacts … [nifi]

2024-05-10 Thread via GitHub
exceptionfactory closed pull request #8799: NIFI-13205 removed legacy integration test and binary test artifacts … URL: https://github.com/apache/nifi/pull/8799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Feature Request] Add `imagePullSecrets` to service account in operator helm chart [rocketmq-operator]

2024-05-10 Thread via GitHub
DavidSonoda commented on issue #221: URL: https://github.com/apache/rocketmq-operator/issues/221#issuecomment-2104584454 Any updates on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add key_shared advice to Cumulative Ack note [pulsar-site]

2024-05-10 Thread via GitHub
AlvaroStream commented on PR #895: URL: https://github.com/apache/pulsar-site/pull/895#issuecomment-2104583220 Sorry I forgot to do the `fetch upstream` and missed the new directory. Done now -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] NIFI-13193 ensure plugin versions are latest and that our minumum sup… [nifi]

2024-05-10 Thread via GitHub
exceptionfactory closed pull request #8797: NIFI-13193 ensure plugin versions are latest and that our minumum sup… URL: https://github.com/apache/nifi/pull/8797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
gvprathyusha6 commented on code in PR #5307: URL: https://github.com/apache/hbase/pull/5307#discussion_r1596623746 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java: ## @@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) { }

Re: [PR] Added DataFileValue to SetEqualityIterator checks in conditional mutations [accumulo]

2024-05-10 Thread via GitHub
dlmarion commented on code in PR #4486: URL: https://github.com/apache/accumulo/pull/4486#discussion_r1596732465 ## server/base/src/main/java/org/apache/accumulo/server/metadata/iterators/SetEncodingIterator.java: ## @@ -139,6 +161,7 @@ public boolean hasTop() { public void

Re: [PR] Bump maven.plugin.version from 3.12.0 to 3.13.0 [commons-release-plugin]

2024-05-10 Thread via GitHub
garydgregory merged PR #271: URL: https://github.com/apache/commons-release-plugin/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [TOPI] Remove `blockIdx.z` in topi sort [tvm]

2024-05-10 Thread via GitHub
tqchen merged PR #16977: URL: https://github.com/apache/tvm/pull/16977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Advoid the use of ImpactsDISI when no minimum competitive score has been set [lucene]

2024-05-10 Thread via GitHub
zhongshanhao commented on PR #13343: URL: https://github.com/apache/lucene/pull/13343#issuecomment-2104580780 @jpountz Can you help me merge the PR? I can't merge this PR because I don't have write access to this repository. :) -- This is an automated message from the Apache Git

[PR] fix nxstyle [nuttx]

2024-05-10 Thread via GitHub
simbit18 opened a new pull request, #12321: URL: https://github.com/apache/nuttx/pull/12321 ## Summary fix Relative file path does not match actual file. ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump actions/upload-artifact from 4.3.1 to 4.3.3 [commons-crypto]

2024-05-10 Thread via GitHub
garydgregory merged PR #332: URL: https://github.com/apache/commons-crypto/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [BugFix][Relax] change FuseOpsByPattern strategy to pattern-match maximal subgraph [tvm]

2024-05-10 Thread via GitHub
wrongtest-intellif merged PR #16922: URL: https://github.com/apache/tvm/pull/16922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.5 [commons-crypto]

2024-05-10 Thread via GitHub
garydgregory merged PR #335: URL: https://github.com/apache/commons-crypto/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump github/codeql-action from 3.24.10 to 3.25.4 [commons-crypto]

2024-05-10 Thread via GitHub
garydgregory merged PR #336: URL: https://github.com/apache/commons-crypto/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Enhancement](function) Support Overlay function [doris]

2024-05-10 Thread via GitHub
koarz commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2104579734 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump ossf/scorecard-action from 2.3.1 to 2.3.3 [commons-crypto]

2024-05-10 Thread via GitHub
garydgregory merged PR #337: URL: https://github.com/apache/commons-crypto/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] Kyuubi return query status (FINISH_STATE) quickly, but job still executing. [kyuubi]

2024-05-10 Thread via GitHub
XorSum commented on issue #6302: URL: https://github.com/apache/kyuubi/issues/6302#issuecomment-2104578509 We don't need real datasets in the production environment. You just need to create a fake dataset with random data that is large enough to reproduce the bug. -- This is an

Re: [PR] SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled [solr]

2024-05-10 Thread via GitHub
dsmiley commented on code in PR #2451: URL: https://github.com/apache/solr/pull/2451#discussion_r1596729680 ## solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesJsonTest.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] [Bug] quick-start-flink not working !!! ? [seatunnel]

2024-05-10 Thread via GitHub
zhouhoo opened a new issue, #6832: URL: https://github.com/apache/seatunnel/issues/6832 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened

[PHP-WEBMASTER] [web-php] master: Fix typo on supported-versions.php (#990)

2024-05-10 Thread Maciej Sobaczewski via GitHub
Author: Maciej Sobaczewski (Sobak) Committer: GitHub (web-flow) Pusher: Girgias Date: 2024-05-10T14:05:50+01:00 Commit: https://github.com/php/web-php/commit/7ec8d43cd780e71c341e0e3901392d6d3dcb524f Raw diff: https://github.com/php/web-php/commit/7ec8d43cd780e71c341e0e3901392d6d3dcb524f.diff

Re: [I] Disallow eventual scans of accumulo metadata and root tables [accumulo]

2024-05-10 Thread via GitHub
cshannon commented on issue #4528: URL: https://github.com/apache/accumulo/issues/4528#issuecomment-2104576249 This only applies to elasticity, but would we also want to disallow eventual scans on the new

Re: [PR] Refactor ContextManagerBuilderParameter [shardingsphere]

2024-05-10 Thread via GitHub
taojintianxia merged PR #31198: URL: https://github.com/apache/shardingsphere/pull/31198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [test](debug) add more log in select_with_tablets to investigate [doris]

2024-05-10 Thread via GitHub
dataroaring commented on PR #34553: URL: https://github.com/apache/doris/pull/34553#issuecomment-2104575044 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [branch-2.0](resource)fix check available fail when s3 aws_token is set and reset as, sk faild on be. [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34655: URL: https://github.com/apache/doris/pull/34655#issuecomment-2104575114 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [branch-2.0](resource)fix check available fail when s3 aws_token is set and reset as, sk faild on be. [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34655: URL: https://github.com/apache/doris/pull/34655#issuecomment-2104575177 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] include: When defining NDEBUG, assert will implement alignment standards [nuttx]

2024-05-10 Thread via GitHub
Gary-Hobson commented on PR #12303: URL: https://github.com/apache/nuttx/pull/12303#issuecomment-2104574801 > @Gary-Hobson after your modification microADB is failing here: > > ``` > if (!uv_is_active((uv_handle_t*)>read_pipe)) { > /* Restart read events */ >

[PR] Use micrometer noop classes for default meter initialization [accumulo]

2024-05-10 Thread via GitHub
EdColeman opened a new pull request, #4542: URL: https://github.com/apache/accumulo/pull/4542 - removes custom NoOpDistributionSummary - adds default initializations for other meter types -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] [YUNIKORN-2590] Handler tests should check for nil request on create [yunikorn-core]

2024-05-10 Thread via GitHub
ryankert01 opened a new pull request, #865: URL: https://github.com/apache/yunikorn-core/pull/865 ### What is this PR for? In the handler_test.go file we have an anti pattern showing a large number (40+) warnings in an IDE: 'req' might have 'nil' or other unexpected value as its

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-05-10 Thread via GitHub
GlutenPerfBot commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2104574059 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Refine memory changes logic when growCapacity [incubator-gluten]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #5690: URL: https://github.com/apache/incubator-gluten/pull/5690#issuecomment-2104573883 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][fix](function) money format [doris]

2024-05-10 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2104573266 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump github/codeql-action from 3.25.3 to 3.25.4 [commons-jexl]

2024-05-10 Thread via GitHub
garydgregory merged PR #252: URL: https://github.com/apache/commons-jexl/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump ossf/scorecard-action from 2.3.1 to 2.3.3 [commons-jexl]

2024-05-10 Thread via GitHub
garydgregory merged PR #253: URL: https://github.com/apache/commons-jexl/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump actions/checkout from 4.1.4 to 4.1.5 [commons-jexl]

2024-05-10 Thread via GitHub
garydgregory merged PR #251: URL: https://github.com/apache/commons-jexl/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Revert "use optimised ByteString.asInputStream (#539)" [pekko-http]

2024-05-10 Thread via GitHub
pjfanning opened a new pull request, #550: URL: https://github.com/apache/pekko-http/pull/550 This reverts commit 03f128907cf55ff2e1777ee0b6fc75d58c7188b9. see #549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add compatibility note for Listeners [airflow]

2024-05-10 Thread via GitHub
potiuk commented on code in PR #39544: URL: https://github.com/apache/airflow/pull/39544#discussion_r1596725025 ## docs/apache-airflow/administration-and-deployment/listeners.rst: ## @@ -110,3 +110,87 @@ Airflow defines the specification as `hookspec

Re: [PR] Bump ossf/scorecard-action from 2.3.1 to 2.3.3 [commons-csv]

2024-05-10 Thread via GitHub
garydgregory merged PR #424: URL: https://github.com/apache/commons-csv/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump actions/checkout from 4.1.4 to 4.1.5 [commons-csv]

2024-05-10 Thread via GitHub
garydgregory merged PR #425: URL: https://github.com/apache/commons-csv/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add compatibility note for Listeners [airflow]

2024-05-10 Thread via GitHub
potiuk commented on code in PR #39544: URL: https://github.com/apache/airflow/pull/39544#discussion_r1596724742 ## docs/apache-airflow/administration-and-deployment/listeners.rst: ## @@ -110,3 +110,87 @@ Airflow defines the specification as `hookspec

Re: [PR] Bump github/codeql-action from 3.25.3 to 3.25.4 [commons-csv]

2024-05-10 Thread via GitHub
garydgregory merged PR #423: URL: https://github.com/apache/commons-csv/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feature-wip](IO) Replace file writer's finalize function with async close [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34679: URL: https://github.com/apache/doris/pull/34679#issuecomment-2104569382 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   3   4   5   6   7   8   9   10   >