[clang] [llvm] [X86][Driver] Do not add `-evex512` for `-march=native` when the target doesn't support AVX512 (PR #91694)

2024-05-12 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > @tstellar Can a note be added somewhere about this? Folks upgrading to > llvm-18.1.6 will get errors unless they drop -march=native if they were on > 18.1.5 Although I agree we should add a note, I don't think this patch affects much. The problem only coccurs when

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

2024-05-12 Thread via cfe-commits
@@ -109,16 +109,16 @@ CHECK-NEXT: 0x000e: [DW_RLE_offset_pair ]: {{.*}}[0x[[RANGELIST_OFFSET_STAR CHECK-NEXT: 0x0011: [DW_RLE_end_of_list ] CHECK: .debug_names contents: -CHECK-NEX:T Name Index @ 0x0 { -CHECK-NEX:T Header { -CHECK-NEX:T Length: 0x7C

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

2024-05-12 Thread via cfe-commits
@@ -1,6 +1,6 @@ // RUN: llvm-mc -filetype=asm -triple powerpc-ibm-aix-xcoff %s | FileCheck %s -// CHECK-label: .csect .text[PR],2 klensy wrote: actual: `.csect ..text..[PR],5` https://github.com/llvm/llvm-project/pull/91854

[clang] [llvm] [X86][Driver] Do not add `-evex512` for `-march=native` when the target doesn't support AVX512 (PR #91694)

2024-05-12 Thread Mike Lothian via cfe-commits
FireBurn wrote: @tstellar Can a note be added somewhere about this? Folks upgrading to llvm-18.1.6 will get errors unless they drop -march=native if they were on 18.1.5 https://github.com/llvm/llvm-project/pull/91694 ___ cfe-commits mailing list

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

2024-05-12 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/88182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Clang][CodeGen] Start migrating away from assuming the Default AS is 0 (PR #88182)

2024-05-12 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx commented: > Please fix the commit message before you merge; otherwise LGTM For the commit message I was thinking something along the following lines: `At the moment, Clang is rather liberal in assuming that 0 (and by extension unqualified) is always a safe

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-12 Thread Oleksandr Alex Zinenko via cfe-commits
https://github.com/ftynse approved this pull request. LGTM for the MLIR part. Please seek approval from relevant reviewers for all other subprojects. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

2024-05-12 Thread via cfe-commits
@@ -382,7 +382,7 @@ void foo18() { // CHECK-NEXT: [[A:%.*a.*]] = getelementptr inbounds [[STRUCT_G]], ptr [[G]], i32 0, i32 0 // CHECK-NEXT: store i32 2, ptr [[A]], align 4 // CHECK-NEXT: [[F:%.*f.*]] = getelementptr inbounds [[STRUCT_G]], ptr [[G]], i32 0, i32 1 -//

[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

2024-05-12 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: > > It has nothing to do with OpenMP. The goal was just to get something in the > > llvm IR that we could check for. The `assume` attribute allows us to pass a > > string that we can then check in a llvm pass. > > Could you investigate whether 'annotate' would do what you

[clang] [Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer (PR #87933)

2024-05-12 Thread via cfe-commits
yronglin wrote: @zygoloid IIUC, since `CXXDefaultArgExpr` and `CXXDefaultInitExpr` were not added to CFG before and were fall back to constant evaluation in ExprEngine, they were not processed correctly in StaticAnalyzer. In CFG:

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

2024-05-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 23fe1fc6b78b7643a801ce3eb53d14b47b1dd0ff 6969f06f39363deda92d473ec14a08663c71f3b1 --

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

2024-05-12 Thread via cfe-commits
https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/91879 Depends on https://github.com/llvm/llvm-project/pull/87933 Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member

[clang] [Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer (PR #87933)

2024-05-12 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/87933 >From 9fba6da7cb1ffbc7d46b69c6ac0cfd15a89c4b56 Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 8 Apr 2024 01:38:23 +0800 Subject: [PATCH 1/6] [Clang] Support lifetime extension of temporary created by

[clang] [Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer (PR #87933)

2024-05-12 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/87933 >From 9fba6da7cb1ffbc7d46b69c6ac0cfd15a89c4b56 Mon Sep 17 00:00:00 2001 From: yronglin Date: Mon, 8 Apr 2024 01:38:23 +0800 Subject: [PATCH 1/5] [Clang] Support lifetime extension of temporary created by

[clang] [X86][vectorcall] Pass built types byval when xmm0~6 exhausted (PR #91846)

2024-05-11 Thread Phoebe Wang via cfe-commits
@@ -792,7 +792,7 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState , return ABIArgInfo::getDirect(); return ABIArgInfo::getExpand(); } -return getIndirectResult(Ty, /*ByVal=*/false, State); +return getIndirectResult(Ty,

[clang] [X86][vectorcall] Pass built types byval when xmm0~6 exhausted (PR #91846)

2024-05-11 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/91846 >From 844fb5283d654d7d9cb68c5712b338f0a70b384e Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Sat, 11 May 2024 16:07:00 +0800 Subject: [PATCH 1/2] [X86][vectorcall] Pass built types byval when xmm0~6

[clang] [clang] visit constraint of NTTP (PR #91842)

2024-05-11 Thread Qizhi Hu via cfe-commits
@@ -79,14 +79,14 @@ template struct Y2 {}; // expected-note {{partial template class U, typename... Z> struct Y3 { Y3()=delete; }; template class U, typename... Z> -struct Y3 { Y3()=delete; }; +struct Y3 { Y3()=delete; }; // expected-note {{partial specialization matches

[clang] 63224d7 - Reapply "Reapply "[clang][Interp] Create full type info for dummy pointers""

2024-05-11 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-12T07:26:03+02:00 New Revision: 63224d717108d927e998da8a67050a6cc5dd74a2 URL: https://github.com/llvm/llvm-project/commit/63224d717108d927e998da8a67050a6cc5dd74a2 DIFF: https://github.com/llvm/llvm-project/commit/63224d717108d927e998da8a67050a6cc5dd74a2.diff

[clang] [analyzer] Allow recursive functions to be trivial. (PR #91876)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91876 >From a4b877b240ede15260f08fcb4a4622dd45a13d0a Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 20:18:52 -0700 Subject: [PATCH 1/2] [analyzer] Allow recursive functions to be trivial. ---

[clang] [analyzer] Allow recursive functions to be trivial. (PR #91876)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 31774b6a8a88b435ce79f9ba048ef8bb00e2817e a4b877b240ede15260f08fcb4a4622dd45a13d0a --

[clang] [analyzer] Allow recursive functions to be trivial. (PR #91876)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/91876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Allow recurisve functions to be trivial. (PR #91876)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91876 >From a4b877b240ede15260f08fcb4a4622dd45a13d0a Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 20:18:52 -0700 Subject: [PATCH] [analyzer] Allow recursive functions to be trivial. ---

[clang] [analyzer] Allow recurisve functions to be trivial. (PR #91876)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91876.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp (+9-9) - (modified)

[clang] [analyzer] Allow recurisve functions to be trivial. (PR #91876)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91876 None >From aac9ea105506ff933d773337f3260f7770a2c5e6 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 20:18:52 -0700 Subject: [PATCH] [analyzer] Allow recurisve functions to be trivial. ---

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-11 Thread Yingwei Zheng via cfe-commits
@@ -1352,20 +1352,43 @@ static void AddParamAndFnBasicAttributes(const CallBase , auto = CalledFunction->getContext(); // Collect valid attributes for all params. - SmallVector ValidParamAttrs; + SmallVector ValidObjParamAttrs, ValidExactParamAttrs; bool

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-11 Thread Yingwei Zheng via cfe-commits
@@ -1352,20 +1352,43 @@ static void AddParamAndFnBasicAttributes(const CallBase , auto = CalledFunction->getContext(); // Collect valid attributes for all params. - SmallVector ValidParamAttrs; + SmallVector ValidObjParamAttrs, ValidExactParamAttrs; bool

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow explicit instantiation of Ref/RefPtr on call arguments. (PR #91875)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91875 >From d5a676c1cbe6d9804e6b2d3582df3c4977684188 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 16:59:27 -0700 Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow explicit

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow explicit instantiation of Ref/RefPtr on call arguments. (PR #91875)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 31774b6a8a88b435ce79f9ba048ef8bb00e2817e d5a676c1cbe6d9804e6b2d3582df3c4977684188 --

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow explicit instantiation of Ref/RefPtr on call arguments. (PR #91875)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91875.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+7) -

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow explicit instantiation of Ref/RefPtr on call arguments. (PR #91875)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91875 None >From d5a676c1cbe6d9804e6b2d3582df3c4977684188 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 16:59:27 -0700 Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Allow explicit

[clang] [clang][driver] add pointer qualifier to auto type (PR #91874)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mohammed Keyvanzadeh (VoltrexKeyva) Changes Fix an LLVM coding standards inconformity by adding pointer qualifiers to `auto`-typed variables that deduce to pointer types. See what the coding standards state

[clang] [clang][driver] add pointer qualifier to auto type (PR #91874)

2024-05-11 Thread Mohammed Keyvanzadeh via cfe-commits
https://github.com/VoltrexKeyva created https://github.com/llvm/llvm-project/pull/91874 Fix an LLVM coding standards inconformity by adding pointer qualifiers to `auto`-typed variables that deduce to pointer types. See what the coding standards state

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91873 >From 433852bd5e360bcf0dfe41e401c3aa73f29a2092 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 16:45:56 -0700 Subject: [PATCH 1/2] [analyzer] Treat break, continue, goto, and label statements as

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 31774b6a8a88b435ce79f9ba048ef8bb00e2817e 433852bd5e360bcf0dfe41e401c3aa73f29a2092 --

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/91873 >From 433852bd5e360bcf0dfe41e401c3aa73f29a2092 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 11 May 2024 16:45:56 -0700 Subject: [PATCH] [analyzer] Treat break, continue, goto, and label statements as

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes Also allow CXXBindTemporaryExpr, which creates a temporary object with a non-trivial destructor, and add a few more std and WTF functions to the explicitly allowed list. --- Full diff:

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/91873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Treat break, continue, goto, and label statements as trivial in WebKit checkers. (PR #91873)

2024-05-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/91873 Also allow CXXBindTemporaryExpr, which creates a temporary object with a non-trivial desturctor, and add a few more std and WTF functions to the explicitly allowed list. >From

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-11 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/89796 >From 662f160418c704f45e57e751168903d774b74303 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 23 Apr 2024 17:41:25 +0100 Subject: [PATCH 1/7] Add initial support for AMDGCN flavoured SPIRV. ---

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-11 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/89796 >From 662f160418c704f45e57e751168903d774b74303 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 23 Apr 2024 17:41:25 +0100 Subject: [PATCH 1/7] Add initial support for AMDGCN flavoured SPIRV. ---

[clang] [ARM][clang] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-05-11 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc updated https://github.com/llvm/llvm-project/pull/91870 >From ef08eb6e2526c5d4f97dbcc42715ae5daf74de3d Mon Sep 17 00:00:00 2001 From: Chris Copeland Date: Sat, 11 May 2024 00:15:50 -0700 Subject: [PATCH] [ARM][clang] Fix warning for VFP function calls from

[clang] [ARM][clang] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-05-11 Thread Chris Copeland via cfe-commits
chrisnc wrote: Here is an example of the existing warning in action. https://godbolt.org/z/9e84EfeYP It warns for calling a normal function, but the same function with an interrupt attribute does not warn. The `subs pc, lr, 4` in `bar_irq` goes back to `bl bar_irq`, creating an infinite loop,

[clang] 0869204 - [clang-format] Fix buildbot failures

2024-05-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-05-11T15:23:35-07:00 New Revision: 0869204cff22831d0bb19a82c99bf85e4deb4ae3 URL: https://github.com/llvm/llvm-project/commit/0869204cff22831d0bb19a82c99bf85e4deb4ae3 DIFF: https://github.com/llvm/llvm-project/commit/0869204cff22831d0bb19a82c99bf85e4deb4ae3.diff

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

2024-05-11 Thread Ivan Murashko via cfe-commits
https://github.com/ivanmurashko closed https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 91c917b - [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (#91738)

2024-05-11 Thread via cfe-commits
Author: Ivan Murashko Date: 2024-05-11T23:14:56+01:00 New Revision: 91c917b19f076b510635a6168305f6f0117e7fad URL: https://github.com/llvm/llvm-project/commit/91c917b19f076b510635a6168305f6f0117e7fad DIFF: https://github.com/llvm/llvm-project/commit/91c917b19f076b510635a6168305f6f0117e7fad.diff

[clang] [ARM][clang] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris Copeland (chrisnc) Changes This warning has two issues: - The interrupt attribute doesn't only change how volatile registers are treated; it also causes the function to return using an exception return instruction. This

[clang] [ARM][clang] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-05-11 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc created https://github.com/llvm/llvm-project/pull/91870 This warning has two issues: - The interrupt attribute doesn't only change how volatile registers are treated; it also causes the function to return using an exception return instruction. This warning

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

2024-05-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin approved this pull request. https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

2024-05-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin reopened https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

2024-05-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
e-kwsm wrote: Commit message is updated/ https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91858 >From 12e8ea6a0e104efbe130dd15d4d9051a7d86d50e Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sun, 12 May 2024 00:06:53 +0900 Subject: [PATCH] fix(python): fix comparison to True/False from PEP8

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91857 >From 7cec823d9a87b90bf8d9ae5c975f4492076e0abb Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(python): fix comparison to None from PEP8

[clang] [llvm] [CMake][Release] Enable CMAKE_POSITION_INDEPENDENT_CODE (PR #90139)

2024-05-11 Thread Tom Stellard via cfe-commits
tstellar wrote: This was merged in another PR: b7e2397c54b7cddac8fa188e68073f78e895a57a. https://github.com/llvm/llvm-project/pull/90139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [BoundsSafety] Allow 'counted_by' attribute on pointers in structs in C (PR #90786)

2024-05-11 Thread Kees Cook via cfe-commits
@@ -0,0 +1,187 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +#define __counted_by(f) __attribute__((counted_by(f))) + +struct bar; + +struct not_found { + int count; + struct bar *fam[] __counted_by(bork); // expected-error {{use of undeclared identifier 'bork'}} +}; +

[clang] [BoundsSafety] Allow 'counted_by' attribute on pointers in structs in C (PR #90786)

2024-05-11 Thread Kees Cook via cfe-commits
kees wrote: > Consider this example. It tries to illustrate why putting `__counted_by()` on > a pointer to a structs containing flexible array members doesn't make sense. > > ```c > struct HasFAM { > int count; > char buffer[] __counted_by(count); // This is OK > }; > > struct

[clang] 2b38688 - Reland: [clang] Use getDefaultArgRange instead of getDefaultArg to retrieve

2024-05-11 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-05-11T22:07:21+02:00 New Revision: 2b386888b78327db4906b12401e1a89438471548 URL: https://github.com/llvm/llvm-project/commit/2b386888b78327db4906b12401e1a89438471548 DIFF: https://github.com/llvm/llvm-project/commit/2b386888b78327db4906b12401e1a89438471548.diff

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
e-kwsm wrote: > Why do we need to make this change? The valid escape sequences in Python are listed [here](https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences): `\t`, `\n`, etc. Invalid ones fixed here seem to be used for regular expression,

[clang-tools-extra] [flang] [lld] [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91864)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld @llvm/pr-subscribers-platform-windows @llvm/pr-subscribers-flang-driver Author: Kazu Hirata (kazutakahirata) Changes I'm planning to remove StringRef::equals in favor of StringRef::operator==. - StringRef::operator==/!= outnumber StringRef::equals

[clang-tools-extra] [flang] [lld] [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91864)

2024-05-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/91864 I'm planning to remove StringRef::equals in favor of StringRef::operator==. - StringRef::operator==/!= outnumber StringRef::equals by a factor of 276 under llvm-project/ in terms of their usage. - The

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Oleksandr Alex Zinenko via cfe-commits
ftynse wrote: This should be included in the actual commit, not GitHub comments. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
e-kwsm wrote: >From [PEP8](https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with `is` or `is > not`, never the equality operators. [flake8](https://flake8.pycqa.org/en/latest/) is used here.

[clang] [Clang] Fix __is_array returning true for zero-sized arrays (PR #86652)

2024-05-11 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: @AaronBallman Any thoughts on how we should proceed here? https://github.com/llvm/llvm-project/pull/86652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-11 Thread via cfe-commits
Sirraide wrote: I’d recommend just adding the tests to wherever the `[[assume]]` attribute is already being tested; that’d be somewhere in `test/SemaCXX` https://github.com/llvm/llvm-project/pull/91841 ___ cfe-commits mailing list

[clang] [clang] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91844)

2024-05-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/91844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] deffae5 - [clang] Use StringRef::operator== instead of StringRef::equals (NFC) (#91844)

2024-05-11 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-05-11T11:38:52-07:00 New Revision: deffae5da123b32098914d8346bf4358a6792bdc URL: https://github.com/llvm/llvm-project/commit/deffae5da123b32098914d8346bf4358a6792bdc DIFF: https://github.com/llvm/llvm-project/commit/deffae5da123b32098914d8346bf4358a6792bdc.diff

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

2024-05-11 Thread Ivan Murashko via cfe-commits
ivanmurashko wrote: @dmpolukhin , the test was successfully passed on MS Windows. There is the corresponding record from the build log ``` _bk;t=1715380522596PASS: Clang :: Modules/implicit-module-no-timestamp.cpp (12618 of 20053) ``` https://github.com/llvm/llvm-project/pull/91738

[clang] 379b777 - [clang][Interp] Use pointee metadata size in isRoot()

2024-05-11 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-11T20:20:04+02:00 New Revision: 379b3cf653352f30f8c7cca393f4df9389be URL: https://github.com/llvm/llvm-project/commit/379b3cf653352f30f8c7cca393f4df9389be DIFF: https://github.com/llvm/llvm-project/commit/379b3cf653352f30f8c7cca393f4df9389be.diff

[clang] [X86][vectorcall] Pass built types byval when xmm0~6 exhausted (PR #91846)

2024-05-11 Thread Eli Friedman via cfe-commits
@@ -792,7 +792,7 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState , return ABIArgInfo::getDirect(); return ABIArgInfo::getExpand(); } -return getIndirectResult(Ty, /*ByVal=*/false, State); +return getIndirectResult(Ty,

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-11 Thread Azmat Yusuf via cfe-commits
azmat-y wrote: Would I be correct in assuming that the test would be somewhat similar to this. llvm-project/clang/test/Sema/unroll-template-value-crash.cpp ``` // RUN: %clang_cc1 -x c++ -verify %s // expected-no-diagnostics template void foo() { #pragma unroll Unroll for (int i = 0; i <

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread Tom Stellard via cfe-commits
tstellar wrote: Two questions: * Did you use a script to generate this patch? * Why do we need to make this change? https://github.com/llvm/llvm-project/pull/91856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Oleksandr Alex Zinenko via cfe-commits
ftynse wrote: Please provide a proper patch description, i.e., why the change is being made. https://github.com/llvm/llvm-project/pull/91857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91844)

2024-05-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/91844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] visit constraint of NTTP (PR #91842)

2024-05-11 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/91842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] visit constraint of NTTP (PR #91842)

2024-05-11 Thread Qizhi Hu via cfe-commits
@@ -79,14 +79,14 @@ template struct Y2 {}; // expected-note {{partial template class U, typename... Z> struct Y3 { Y3()=delete; }; template class U, typename... Z> -struct Y3 { Y3()=delete; }; +struct Y3 { Y3()=delete; }; // expected-note {{partial specialization matches

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91858.diff 18 Files Affected: - (modified) clang/tools/scan-build/bin/set-xcode-analyzer (+1-1) - (modified) clang/utils/check_cfc/check_cfc.py

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/91858 None >From 1e31186c01024c63fa4c0bd378fec7131ce84d56 Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sun, 12 May 2024 00:06:53 +0900 Subject: [PATCH] fix(python): fix comparison to True/False ---

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-pgo @llvm/pr-subscribers-compiler-rt-sanitizer Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified)

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified)

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-11 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/91857 None >From c450df191a6b96591d7c7a7454b6e15cb925520f Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(python): fix comparison to None ---

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-11 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/90574 >From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 30 Apr 2024 17:18:26 +0800 Subject: [PATCH 01/11] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20?=

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-05-11 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/90574 >From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 30 Apr 2024 17:18:26 +0800 Subject: [PATCH 01/11] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20?=

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 120.87 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91856.diff 100 Files Affected: - (modified)

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 120.87 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91856.diff 100 Files Affected: - (modified)

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread via cfe-commits
@@ -9216,14 +9216,20 @@ class Sema final : public SemaBase { /// receive true if the cause for the error is the associated constraints of /// the template not being satisfied by the template arguments. /// + /// \param PartialOrderTTP If true, assume these template

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread via cfe-commits
@@ -707,6 +707,7 @@ Bug Fixes to C++ Support initialized, rather than evaluating them as a part of the larger manifestly constant evaluated expression. - Fix a bug in access control checking due to dealyed checking of friend declaration. Fixes (#GH12361). +- When partial

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread via cfe-commits
@@ -6436,7 +6436,8 @@ bool Sema::CheckTemplateArgumentList( TemplateArgumentListInfo , bool PartialTemplateArgs, SmallVectorImpl , SmallVectorImpl , -bool UpdateArgsWithConversions, bool *ConstraintsNotSatisfied) { +bool UpdateArgsWithConversions, bool

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread via cfe-commits
https://github.com/cor3ntin commented: Looks sensible to me but let's wait a bit (I'll try to run tests on stdexec with that change) https://github.com/llvm/llvm-project/pull/91833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/91833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [test]: fix filecheck annotation typos (PR #91854)

2024-05-11 Thread via cfe-commits
@@ -109,16 +109,16 @@ CHECK-NEXT: 0x000e: [DW_RLE_offset_pair ]: {{.*}}[0x[[RANGELIST_OFFSET_STAR CHECK-NEXT: 0x0011: [DW_RLE_end_of_list ] CHECK: .debug_names contents: -CHECK-NEX:T Name Index @ 0x0 { -CHECK-NEX:T Header { -CHECK-NEX:T Length: 0x7C

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [test]: fix filecheck annotation typos (PR #91854)

2024-05-11 Thread via cfe-commits
https://github.com/klensy updated https://github.com/llvm/llvm-project/pull/91854 >From 73dc4487a8a13a13f628857334afb25dcf2aa1f4 Mon Sep 17 00:00:00 2001 From: klensy Date: Sat, 11 May 2024 14:26:52 +0300 Subject: [PATCH 1/2] llvm: fix few typos in filecheck tests clang: fix few typos in

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread Erich Keane via cfe-commits
@@ -6507,8 +6508,13 @@ bool Sema::CheckTemplateArgumentList( bool PackExpansionIntoNonPack = NewArgs[ArgIdx].getArgument().isPackExpansion() && (!(*Param)->isTemplateParameterPack() || getExpandedPackSize(*Param)); - if (PackExpansionIntoNonPack

[clang] [clang] Allow pack expansions when partial ordering against template template parameters (PR #91833)

2024-05-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/91833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add modernize-use-std-format check (PR #90397)

2024-05-11 Thread Mike Crowe via cfe-commits
mikecrowe wrote: @PiotrZSL wrote: > Once build will pass, I will land this change, and fixes could be done in > separate PR for both checks. The build seems to be passing. Please can you land this if you are happy? Thanks. https://github.com/llvm/llvm-project/pull/90397

[clang-tools-extra] Add option to exclude headers from clang-tidy analysis (PR #91400)

2024-05-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/91400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [test]: fix filecheck annotation typos (PR #91854)

2024-05-11 Thread Dhruv Chawla via cfe-commits
dc03-work wrote: Ah, looks like broken tests are being uncovered now. Awesome. https://github.com/llvm/llvm-project/pull/91854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lld] [llvm] [mlir] [test]: fix filecheck annotation typos (PR #91854)

2024-05-11 Thread Dhruv Chawla via cfe-commits
@@ -24,7 +24,7 @@ entry: } ; FIXME: Misspelled CHECK-LABEL dc03-work wrote: This FIXME can also be removed. Looking at the history of this file, looks like something like this was attempted before:

  1   2   3   4   5   6   7   8   9   10   >