Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Luke Shumaker
On Thu, 22 Feb 2018 19:27:04 -0500, Eli Schwartz wrote: > > [1 Re: [arch-projects] [dbscripts] [PATCH 1/3] test: > common.bash:__getCheckSum: Don't rely on IFS ] > [1.1 ] > On 02/22/2018 06:43 PM, Luke Shumaker wrote: > > On Thu, 22 Feb 2018 16:43:36 -0500, &

Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 06:43 PM, Luke Shumaker wrote: > On Thu, 22 Feb 2018 16:43:36 -0500, > Eli Schwartz wrote: >>> __getCheckSum() { >>> - local result=($(sha1sum $1)) >>> - echo ${result[0]} >>> + local result >>> + result="$(sha1sum "$1")" >>> + echo "${result%% *}" >> >> Why are you moving

Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Luke Shumaker
On Thu, 22 Feb 2018 16:43:36 -0500, Eli Schwartz wrote: > > __getCheckSum() { > > - local result=($(sha1sum $1)) > > - echo ${result[0]} > > + local result > > + result="$(sha1sum "$1")" > > + echo "${result%% *}" > > Why are you moving over to declaring the variable and assigning it

Re: [arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Eli Schwartz via arch-projects
On 02/22/2018 03:43 PM, Luke Shumaker wrote: > From: Luke Shumaker > > I managed to stumble across a bug in BATS where the run() function > screwed with the global IFS. The bug has been fixed in git, but isn't > in a release yet. > >

[arch-projects] [dbscripts] [PATCH 1/3] test: common.bash:__getCheckSum: Don't rely on IFS

2018-02-22 Thread Luke Shumaker
From: Luke Shumaker I managed to stumble across a bug in BATS where the run() function screwed with the global IFS. The bug has been fixed in git, but isn't in a release yet. https://github.com/sstephenson/bats/issues/89 Anyway, this bug breaks __getCheckSum().