Diff: https://reviewboard.asterisk.org/r/3573/diff/
Testing
---
Tested by me.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
(main/config.c) that makes
incorrect comparison for a category name.
Diffs
-
http://svn.asterisk.org/svn/asterisk/branches/11/main/config.c 414808
Diff: https://reviewboard.asterisk.org/r/3573/diff/
Testing
---
Tested by me.
Thanks,
zvision
difference
is no config option to maintain backwards compatibility. Maybe for branch 12,
there should be the same option as for 1.8 and 11
to be backwards compatible...
- zvision
---
This is an automatically generated e-mail. To reply, visit
+ regs.
When a 'port' column in SIP regs (I assume this also applies when using
sippeers only) is a nullable integer,
Asterisk tries to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
---
Tested with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both
allow_empty_string_in_nontext settings
to ensure no regression is introduced.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http
---
Tested by listening to various number sequences, everything seems to be fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
-08af861a6d84__res_config_pgsql.12.diff
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk
On March 23, 2014, 3:46 p.m., wdoekes wrote:
Minor nits. Still waiting for someone to test this.
Sure, no hurry:)
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346
for successful compilation. Someone needs to confirm that the patch
works fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
-50fa54e5cac9__res_config_pgsql.12.diff
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
---
Tested with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both
allow_empty_string_in_nontext settings
to ensure no regression is introduced.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http
for the seemingly random 64.)
Yes, it took me some time to figure out this mystery:)
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3375/#review11331
avoid the call for char-columns.
Also, we don't need to check tableptr, since column would be NULL if it
was false.
zvision wrote:
I also moved the check for text column to a separate inline function.
The check for tableptr is neccessary when count 63.
- zvision
with Asterisk 11 + ODBC + SIP realtime + PostgreSQL with both
allow_empty_string_in_nontext settings
to ensure no regression is introduced.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api
.
Diffs
-
http://svn.asterisk.org/svn/asterisk/branches/1.8/main/say.c 410948
Diff: https://reviewboard.asterisk.org/r/3378/diff/
Testing
---
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http
the problem and clarifies a bit other checks.
Diffs
-
http://svn.asterisk.org/svn/asterisk/branches/1.8/main/say.c 410948
Diff: https://reviewboard.asterisk.org/r/3378/diff/
Testing (updated)
---
Tested by listening to various number sequences, everything seems to be fine.
Thanks,
zvision
.
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3378/#review11308
---
On March 20, 2014, 2:37 p.m., zvision wrote
On March 17, 2014, 9:28 a.m., zvision wrote:
So, the changes look good. But that regression thing is .. not so nice.
For trunk and up, we could change the behaviour. But we can't for 1.8..12.
The options are:
- leave the bug in place, only fix in trunk
- change
On March 17, 2014, 9:28 a.m., zvision wrote:
So, the changes look good. But that regression thing is .. not so nice.
For trunk and up, we could change the behaviour. But we can't for 1.8..12.
The options are:
- leave the bug in place, only fix in trunk
- change
this also applies when using
sippeers only) is a nullable integer,
Asterisk tries to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api
is introduced.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
On March 17, 2014, 9:28 a.m., zvision wrote:
So, the changes look good. But that regression thing is .. not so nice.
For trunk and up, we could change the behaviour. But we can't for 1.8..12.
The options are:
- leave the bug in place, only fix in trunk
- change
/1.8/res/res_config_pgsql.c
410663
Diff: https://reviewboard.asterisk.org/r/3346/diff/
Testing
---
Only tested for successful compilation. Someone needs to confirm that the patch
works fine.
Thanks,
zvision
/r/3346/diff/
Testing
---
Only tested for successful compilation. Someone needs to confirm that the patch
works fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
) in
the check.
I have uploaded a patch for 1.8 branch.
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11243
: Asterisk + res_odbc + PostgreSQL backend, SIP
realtime peers + regs.
When a 'port' column in SIP regs (I assume this also applies when using
sippeers only) is a nullable integer,
Asterisk tries to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
On March 17, 2014, 9:28 a.m., zvision wrote:
So, the changes look good. But that regression thing is .. not so nice.
For trunk and up, we could change the behaviour. But we can't for 1.8..12.
The options are:
- leave the bug in place, only fix in trunk
- change
://reviewboard.asterisk.org/r/3346/diff/
Testing
---
Only tested for successful compilation. Someone needs to confirm that the patch
works fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
On March 17, 2014, 11:48 a.m., wdoekes wrote:
http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_config_pgsql.c,
line 682
https://reviewboard.asterisk.org/r/3346/diff/2/?file=56146#file56146line682
Try to limit line lengths to about 100.
Done:)
- zvision
-470a-844b-0f8fb1dd0ef6__res_config_pgsql.12.diff
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
-0f8fb1dd0ef6__res_config_pgsql.12.diff
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
.
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3346/#review11254
---
On March 17, 2014, 4:16 p.m., zvision wrote
for successful compilation. Someone needs to confirm that the patch
works fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
for successful compilation. Someone needs to confirm that the patch
works fine.
File Attachments (updated)
Patch version for branch 12
https://reviewboard.asterisk.org/media/uploaded/files/2014/03/17/743ba069-05bf-4b31-9bc9-08af861a6d84__res_config_pgsql.12.diff
Thanks,
zvision
. Use case scenario: Asterisk + res_odbc + PostgreSQL backend, SIP
realtime peers + regs.
When a 'port' column in SIP regs (I assume this also applies when using
sippeers only) is a nullable integer,
Asterisk tries to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
+ regs.
When a 'port' column in SIP regs (I assume this also applies when using
sippeers only) is a nullable integer,
Asterisk tries to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
here or should I
create a new review request?
- zvision
On March 14, 2014, 3:29 p.m., zvision wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3335
On March 14, 2014, 4:03 p.m., zvision wrote:
If I have a similar fix for branch 12, should I upload a diff here or
should I create a new review request?
Matt Jordan wrote:
Is the patch the same?
If the patches are the same - minus any syntax changes that would occur
this case only. It should not break anything, as
setting an integer column to an empty string
in PostgreSQL will fail anyway. It just makes the module to handle more cases.
- zvision
---
This is an automatically generated e-mail. To reply
.
- zvision
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3335/#review11173
---
On March 14, 2014, 4:32 p.m., zvision wrote
to confirm that the patch
works fine.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
in such that there is some confidence that the patch fixes
the reported problem.
Got it. That's why I put the explicit comment - to ensure someone interested at
this issue will give it a try and report back.
- zvision
to write an empty string here during SIP endpoint deregistration.
Thanks,
zvision
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
44 matches
Mail list logo
