Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-28 Thread zvision
On March 28, 2014, 4:15 a.m., Matt Jordan wrote: I'm going to go ahead and push this into 1.8, 11, and 12. Matt Jordan wrote: Scratch that, I'll block this on 12. I've submitted a proper patch for trunk (and 12) version here: https://reviewboard.asterisk.org/r/3335/. The only

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/#review11420 --- I'm going to go ahead and push this into 1.8, 11, and 12. -

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-27 Thread zvision
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/ --- (Updated March 27, 2014, 11:24 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-27 Thread Matt Jordan
On March 27, 2014, 11:15 p.m., Matt Jordan wrote: I'm going to go ahead and push this into 1.8, 11, and 12. Scratch that, I'll block this on 12. - Matt --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-24 Thread zvision
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/ --- (Updated March 24, 2014, 9:31 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-24 Thread zvision
On March 23, 2014, 3:26 p.m., wdoekes wrote: http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c, line 533 https://reviewboard.asterisk.org/r/3375/diff/1/?file=56218#file56218line533 Please move the (non-inline) ast_odbc function call to the back so we can

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-24 Thread zvision
On March 23, 2014, 3:26 p.m., wdoekes wrote: http://svn.asterisk.org/svn/asterisk/branches/11/res/res_config_odbc.c, line 533 https://reviewboard.asterisk.org/r/3375/diff/1/?file=56218#file56218line533 Please move the (non-inline) ast_odbc function call to the back so we can

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-24 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/#review11344 --- Ship it! Looking good. - wdoekes On March 24, 2014, 9:52

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-24 Thread zvision
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/ --- (Updated March 24, 2014, 10:14 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-23 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/#review11331 --- Looks pretty much good to go. A few remarks below. And a last

[asterisk-dev] [Code Review] 3375: [res_config_odbc/res_odbc] Fixed handling of non-text columns updates with empty values

2014-03-18 Thread zvision
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3375/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23459