Re: [Bash-completion-devel] [PATCH] Fix lvm completion related with physical volumes

2016-02-07 Thread Ville Skyttä
On Wed, Dec 16, 2015 at 5:21 AM, Liuhua Wang wrote: > There are the following problems with lvm completions: Thanks for the patch and sorry about the delay. I don't use lvm myself -- any lvm users around to review this? In any case, please add test cases for the changes to the

[Bash-completion-devel] [PATCH] Fix lvm completion related with physical volumes

2015-12-15 Thread Liuhua Wang
There are the following problems with lvm completions: 1)_lvm_physicalvolumes() only gets PVs that belong to a VG. In some cases like pvremove we can use all PVs including those not included in any VGs. solution: Add _lvm_physicalvolumes_all to get all PVs and correct all the