Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

LGTM3 On Friday, May 3, 2024 at 1:34:21 PM UTC-4 Chris Harrelson wrote: > Thanks for these mini-explainers, they clarified what is changing for me! > > LGTM2 > > On Fri, May 3, 2024 at 9:31 AM 'Akash Nadan' via blink-dev < > blin...@chromium.org> wrote: > >> Hi Alex, >> >> Thanks for the

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Thanks for these mini-explainers, they clarified what is changing for me! LGTM2 On Fri, May 3, 2024 at 9:31 AM 'Akash Nadan' via blink-dev < blink-dev@chromium.org> wrote: > Hi Alex, > > Thanks for the feedback and sorry for the initial lack of detail! We hope > the following explanations

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hi Alex, Thanks for the feedback and sorry for the initial lack of detail! We hope the following explanations (below) make each of these proposed changes more clear. We will keep the feedback in mind and make sure to include the level of detail similar to the Explainer format going forward.

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hey folks, We've talked about this in API OWNERS again, and the presentation of this set of features is...frustrating. Several of these features lack any explanation, example code, or any outline of alternative approaches that were considered and discarded. Having multiple features presented

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Thanks Akash. This is not quite the level of detail I was hoping for (I've more or less grokked that from the commits themselves), but I'm satisfied with the compat implications of always requiring the ar_debug cookie. LGTM1 On 4/26/24 5:10 PM, Akash Nadan wrote: Hi Mike, We have not

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hi Mike, We have not fully considered adding this functionality to WPT and it may be challenging due to delays and noise added by the Attribution Reporting API, but we will evaluate what is possible here. Thanks for the suggestions regarding the features. We will make sure to break apart

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hi Mike, We have not fully considered adding this functionality to WPT and it may be challenging due to delays and noise added by the Attribution Reporting API, but we will evaluate what is possible here. Thanks for the suggestions regarding the features. We will make sure to break apart

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Apologies for the delay here - it's a bit challenging to review 4 features at once. (Aside: it seems like this particular intent could have been split into 2... one for 2 debug report features, and another for rate limits?) On 4/19/24 12:51 PM, 'Akash Nadan' via blink-dev wrote: Contact

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

On 4/24/24 9:40 AM, Nan Lin wrote: These tests are for Attribution Reporting API, but not explicitly related to the features in this intent. We do expect that all the tests there will be passing. Those 3 tests involve writing to and reading from the stash, which probably causes the timeout

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hi Philip, These tests are for Attribution Reporting API, but not explicitly related to the features in this intent. We do expect that all the tests there will be passing. Those 3 tests involve writing to and reading from the stash, which probably causes the timeout flakiness. As currently the

Re: [blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Hi Akash, Are https://wpt.fyi/results/attribution-reporting all of the tests for this feature and these changes? Do you expect that all of the tests there will be passing? I see that 3 of the tests time out which make it harder to understand the status. Is it possible to make these tests fail

[blink-dev] Intent to Ship: Attribution Reporting Feature Bundle: Additional Verbose Debug Reports, Further Gating Source Verbose Debug Reports, Splitting the Attribution Rate Limit

Contact emails akashna...@google.com, lin...@chromium.org, johni...@chromium.org Explainer Attribution Reporting with event-level reports Attribution Reporting API with Aggregatable Reports