I have a couple nit-picky comments:
1. The change to src/jdk.jlink/share/classes/module-info.java is
unrelated to jpackage and should be reverted (there is only a
white-space change and a copyright date change to that file)
2. The following files have whitespace errors that will cause
A couple of questions / observations :-
1) setlocale
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/linux/native/jpackageapplauncher/launcher.cpp.html
52 int main(int argc, char *argv[]) {
53 int result = 1;
54 setlocale(LC_ALL, "en_US.utf8");
Why is this
Erik -
Looks good to me as well.
Tim
On 04/24/19 16:27, Mikael Vidstedt wrote:
Wow, so proactive of you. Ship it!
Cheers,
Mikael
On Apr 24, 2019, at 4:00 PM, Erik Joelsson wrote:
JDK-8207849 added support for extra version numbers in the java version string.
Now we need to use at least
Hi Matthias,
Thanks for the review!
On Tue, 2019-04-30 at 12:52 +, Baesken, Matthias wrote:
> Hi Severin, looks okay to me (not a reviewer however).
> In our proprietary JVM8 we hadset (on
> Linux)BUILD_LIBFDLIBM_OPTIMIZATION :=
> HIGH and FDLIBM_CFLAGS +=
Hi Severin, looks okay to me (not a reviewer however).
In our proprietary JVM8 we hadset (on Linux)
BUILD_LIBFDLIBM_OPTIMIZATION := HIGH and FDLIBM_CFLAGS +=
-ffp-contract=offfor a long time and did not observe any issues .
(but we always build with gcc 4.8.x so cannot
Hi,
Could I please get a review for this 8u backport related to fdlibm
optimization on Linux? The JDK 12 patch doesn't apply as-is as the JDK
8 build system is drastically different from JDK 11+.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210416
webrev:
Hi,
please help reviewing the backport of JDK-8210782: Upgrade HarfBuzz to the
latest 2.3.1.
This has been backported to 11.0.4-oracle already. I took the large change down
to 11u-dev. It applies quite nicely, apart from a little issue in
make/lib/Awt2dLibraries.gmk:
--- Awt2dLibraries.gmk
