Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread Quan Anh Mai
On Sat, 14 Oct 2023 03:21:52 GMT, himichael wrote: >>> my question is that this feature should improve performance several times, >>> but it doesn't look like there's much difference between open jdk 22.19 and >>> jdk 8. is there a problem with my configuration ? >> >> Hello @himichael, >>

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread himichael
On Fri, 13 Oct 2023 23:59:55 GMT, Srinivas Vamsi Parasa wrote: > > my question is that this feature should improve performance several times, > > but it doesn't look like there's much difference between open jdk 22.19 and > > jdk 8. is there a problem with my configuration ? > > Hello

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread Srinivas Vamsi Parasa
On Fri, 13 Oct 2023 10:31:14 GMT, himichael wrote: > my question is that this feature should improve performance several times, > but it doesn't look like there's much difference between open jdk 22.19 and > jdk 8. is there a problem with my configuration ? Hello @himichael, Using your code

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread Sandhya Viswanathan
On Fri, 13 Oct 2023 10:31:14 GMT, himichael wrote: >> @himichael Please refer to [this >> question](https://stackoverflow.com/questions/504103/how-do-i-write-a-correct-micro-benchmark-in-java) >> for how to correctly benchmark Java code. > >> @himichael Please refer to [this >>

Integrated: 8317970: Bump target macosx-x64 version to 11.00.00

2023-10-13 Thread Mikael Vidstedt
On Wed, 11 Oct 2023 17:49:14 GMT, Mikael Vidstedt wrote: > macOS 10.x is no longer receiving updates - the most recent/last release was > 10.15.7 back in July of 2022. It's time to bump the target macOS version > (min/max) for macosx-x64. macOS 11.x is still receiving updates. > > This change

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Mikael Vidstedt
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote: >> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This

Integrated: 8317837: Leftover FFM implementation-only changes

2023-10-13 Thread Jorn Vernee
On Tue, 10 Oct 2023 21:41:01 GMT, Jorn Vernee wrote: > Port of miscellaneous leftover implementation-only changes from the > panama-foreign repo: > > These four related to improving the performance of the internal `strlen` > implementation: > > -

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Erik Joelsson
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote: >> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Phil Race
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote: >> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Mikael Vidstedt
> macOS 10.x is no longer receiving updates - the most recent/last release was > 10.15.7 back in July of 2022. It's time to bump the target macOS version > (min/max) for macosx-x64. macOS 11.x is still receiving updates. > > This change updates the target version for macosx-x64 to 11.00.00,

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v3]

2023-10-13 Thread Mikael Vidstedt
> macOS 10.x is no longer receiving updates - the most recent/last release was > 10.15.7 back in July of 2022. It's time to bump the target macOS version > (min/max) for macosx-x64. macOS 11.x is still receiving updates. > > This change updates the target version for macosx-x64 to 11.00.00,

Integrated: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Mikael Vidstedt
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > This change bumps the

Re: RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Mikael Vidstedt
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > This change bumps the

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags

2023-10-13 Thread Vladimir Kozlov
On Fri, 13 Oct 2023 09:49:48 GMT, Emanuel Peter wrote: > @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. > https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 > > We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and > hence they

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote: >> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> -

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Jorn Vernee
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote: >> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> -

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote: >> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> -

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote: >> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> -

Re: RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Christoph Langer
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > This change bumps the

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags

2023-10-13 Thread Erik Joelsson
On Fri, 13 Oct 2023 09:49:48 GMT, Emanuel Peter wrote: > @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. > https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 > > We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and > hence they

Re: RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Magnus Ihse Bursie
On Thu, 12 Oct 2023 19:53:23 GMT, Erik Joelsson wrote: >> In GHA, the versions of macOS (note: the version used for build/test, >> **not** the target macOS version we compile for) and Xcode are starting to >> show age. It's time to update to more modern versions. >> >> This change bumps the

Re: RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Magnus Ihse Bursie
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > This change bumps the

Re: RFR: 8317837: Leftover FFM implementation-only changes

2023-10-13 Thread Jorn Vernee
On Tue, 10 Oct 2023 21:41:01 GMT, Jorn Vernee wrote: > Port of miscellaneous leftover implementation-only changes from the > panama-foreign repo: > > These four related to improving the performance of the internal `strlen` > implementation: > > -

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Maurizio Cimadamore
On Fri, 13 Oct 2023 11:32:09 GMT, Jorn Vernee wrote: >> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> -

Re: RFR: 8317837: Leftover FFM implementation-only changes [v2]

2023-10-13 Thread Jorn Vernee
> Port of miscellaneous leftover implementation-only changes from the > panama-foreign repo: > > These four related to improving the performance of the internal `strlen` > implementation: > > - https://github.com/openjdk/panama-foreign/pull/862 > -

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags

2023-10-13 Thread Magnus Ihse Bursie
On Fri, 13 Oct 2023 09:49:48 GMT, Emanuel Peter wrote: > @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. > https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 > > We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and > hence they

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread himichael
On Fri, 13 Oct 2023 08:17:58 GMT, Quan Anh Mai wrote: > @himichael Please refer to [this > question](https://stackoverflow.com/questions/504103/how-do-i-write-a-correct-micro-benchmark-in-java) > for how to correctly benchmark Java code. thanks for your reply, but I think this has nothing

RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags

2023-10-13 Thread Emanuel Peter
@vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and hence they are always considered `undefined`. Hence, all of these `ifdef`

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread Quan Anh Mai
On Fri, 13 Oct 2023 07:02:18 GMT, himichael wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 45 commits: >> >> - fix code style and formatting >> - Merge branch 'master' of

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-13 Thread himichael
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>