On Wed, 9 Aug 2023 15:26:05 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Wed, 9 Aug 2023 15:26:05 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Wed, 9 Aug 2023 15:26:05 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Wed, 9 Aug 2023 15:26:05 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Andreas Steiner has updated the pull request incrementally with one
On Wed, 9 Aug 2023 06:14:59 GMT, Andreas Steiner wrote:
> I agree to add this to the nm calls in NativeCompilation.gmk. Christoph
> mentioned this is used when static libraries are build. I tried the target
> "static-libs-image". But this isn't working on AIX, because the ar flags -rcs
> are
On Tue, 8 Aug 2023 20:50:11 GMT, Christoph Langer wrote:
> > > Looks good overall. I suggest to remove the BUILD_NM variable in this PR
> > > as well. We should then wait with a final review until some folks from
> > > the Oracle build team are back.
> >
> >
> > What is the motivation for
On Fri, 4 Aug 2023 14:37:04 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Tue, 8 Aug 2023 20:14:55 GMT, Erik Joelsson wrote:
> > Looks good overall. I suggest to remove the BUILD_NM variable in this PR as
> > well. We should then wait with a final review until some folks from the
> > Oracle build team are back.
>
> What is the motivation for removing BUILD_NM? I
On Fri, 4 Aug 2023 09:52:30 GMT, Christoph Langer wrote:
> Looks good overall. I suggest to remove the BUILD_NM variable in this PR as
> well. We should then wait with a final review until some folks from the
> Oracle build team are back.
What is the motivation for removing BUILD_NM? I
On Fri, 4 Aug 2023 14:37:04 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Fri, 4 Aug 2023 14:42:37 GMT, Andreas Steiner wrote:
> > make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid
> > the flag there? flags-other.m4 : the comment 'on AIX ...' is just stating
> > the obvious; maybe it should better mention that without -X64 we only
> >
On Fri, 4 Aug 2023 12:35:20 GMT, Matthias Baesken wrote:
> make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the
> flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the
> obvious; maybe it should better mention that without -X64 we only process
>
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Andreas Steiner has updated the pull request incrementally with one
On Fri, 4 Aug 2023 11:17:43 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Fri, 4 Aug 2023 09:50:44 GMT, Christoph Langer wrote:
>> Andreas Steiner has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove needless else
>
> make/autoconf/flags-other.m4 line 96:
>
>> 94: if test "x$OPENJDK_TARGET_OS" = xaix;
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Andreas Steiner has updated the pull request incrementally with one
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner wrote:
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Looks good apart
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner wrote:
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Looks good overall.
On AIX we need the -X64 option for NM in the build. The handling is equivalent
to the other used tools flags like AR.
This change will replace the quick fix done in
https://bugs.openjdk.org/browse/JDK-8312466.
-
Commit messages:
- JDK-8313244: NM flags handling in configure
20 matches
Mail list logo
