On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva
wrote:
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types
On Fri, 4 Aug 2023 17:29:36 GMT, Coleen Phillimore wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed field namnes to resolve error
>
> This looks good.
Thank you for the reviews @coleenp,
On Fri, 4 Aug 2023 17:05:55 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
On Fri, 4 Aug 2023 17:05:55 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types used by
> `ResolvedFieldEntry` and the method `fill_in()`. Verified
On Fri, 4 Aug 2023 09:10:48 GMT, Fei Yang wrote:
> Hello, did you check the license for libatomic.a? Is it compatible with
> libjvm.so?
When compiling with gcc or clang (which are AFAIK the only compiler supported
for Linux-RISC-V), it uses the compiler's implementation. In the case of GCC,
On Fri, 4 Aug 2023 12:35:20 GMT, Matthias Baesken wrote:
> make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the
> flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the
> obvious; maybe it should better mention that without -X64 we only process
>
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types used by
> `ResolvedFieldEntry` and the method `fill_in()`. Verified
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Andreas Steiner has updated the pull request incrementally with one
On Fri, 4 Aug 2023 11:17:43 GMT, Andreas Steiner wrote:
>> On AIX we need the -X64 option for NM in the build. The handling is
>> equivalent to the other used tools flags like AR.
>> This change will replace the quick fix done in
>> https://bugs.openjdk.org/browse/JDK-8312466.
>
> Andreas
On Fri, 4 Aug 2023 09:50:44 GMT, Christoph Langer wrote:
>> Andreas Steiner has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove needless else
>
> make/autoconf/flags-other.m4 line 96:
>
>> 94: if test "x$OPENJDK_TARGET_OS" = xaix;
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Andreas Steiner has updated the pull request incrementally with one
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner wrote:
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Looks good apart
On Fri, 4 Aug 2023 09:18:11 GMT, Aleksey Shipilev wrote:
> RISC-V is now the [official Debian
> architecture](https://lists.debian.org/debian-riscv/2023/07/msg00053.html).
> This means that the official repository is slowly building up the package
> set, while the old debian-ports repo is
On Fri, 4 Aug 2023 09:22:00 GMT, Andreas Steiner wrote:
> On AIX we need the -X64 option for NM in the build. The handling is
> equivalent to the other used tools flags like AR.
> This change will replace the quick fix done in
> https://bugs.openjdk.org/browse/JDK-8312466.
Looks good overall.
On AIX we need the -X64 option for NM in the build. The handling is equivalent
to the other used tools flags like AR.
This change will replace the quick fix done in
https://bugs.openjdk.org/browse/JDK-8312466.
-
Commit messages:
- JDK-8313244: NM flags handling in configure
RISC-V is now the [official Debian
architecture](https://lists.debian.org/debian-riscv/2023/07/msg00053.html).
This means that the official repository is slowly building up the package set,
while the old debian-ports repo is [slowly
On Thu, 3 Aug 2023 16:14:06 GMT, Aleksey Shipilev wrote:
> We don't need the fully bootable Debian installation to build against.
> Therefore, we can bootstrap with `--variant=minbase`. The sysroots are about
> 5..10% smaller then.
>
> This would also make our builds more immune to issues
On Thu, 3 Aug 2023 16:14:06 GMT, Aleksey Shipilev wrote:
> We don't need the fully bootable Debian installation to build against.
> Therefore, we can bootstrap with `--variant=minbase`. The sysroots are about
> 5..10% smaller then.
>
> This would also make our builds more immune to issues
On Wed, 2 Aug 2023 06:55:40 GMT, Ludovic Henry wrote:
> Currently, RISC-V differs from other platforms in that it requires the
> linkage to libatomic.so to support sub-word atomic operations. However,
> because it is linked dynamically, it will depend on the installation of
> libatomic.so on
On Thu, 3 Aug 2023 16:14:06 GMT, Aleksey Shipilev wrote:
> We don't need the fully bootable Debian installation to build against.
> Therefore, we can bootstrap with `--variant=minbase`. The sysroots are about
> 5..10% smaller then.
>
> This would also make our builds more immune to issues
On Thu, 3 Aug 2023 16:14:06 GMT, Aleksey Shipilev wrote:
> We don't need the fully bootable Debian installation to build against.
> Therefore, we can bootstrap with `--variant=minbase`. The sysroots are about
> 5..10% smaller then.
>
> This would also make our builds more immune to issues
On Tue, 1 Aug 2023 07:28:02 GMT, Andreas Steiner wrote:
> Add the default include location(/opt/freeware/include/) for cups on AIX.
> With this set the additional configure parameter --with-cups-include can be
> removed, which was needed on AIX.
This pull request has now been integrated.
23 matches
Mail list logo
