[clang-tools-extra] b70fbd0 - [clangd] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-06T23:50:19-08:00 New Revision: b70fbd0fd96f8ab64e44c37d8a532d58907fff6a URL: https://github.com/llvm/llvm-project/commit/b70fbd0fd96f8ab64e44c37d8a532d58907fff6a DIFF: https://github.com/llvm/llvm-project/commit/b70fbd0fd96f8ab64e44c37d8a532d58907fff6a.diff

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139505: [clang][CodeGen] Add noundef metadata to loading of references (preliminary 5 of 5)

jmciver created this revision. jmciver added reviewers: vitalybuka, jdoerfert, rjmccall, aqjune, efriedma, nikic. Herald added a project: All. jmciver retitled this revision from "[clang][CodeGen] Add noundef metadata to loading of references (item 5)" to "[clang][CodeGen] Add noundef metadata

[PATCH] D139450: Warn about unsupported ibmlongdouble

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.h:30 const llvm::opt::ArgList ) const; + bool SupportIBMLongDouble(const Driver , +const llvm::opt::ArgList ) const; New

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480775. rcvalle added a comment. Fixed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[PATCH] D139450: Warn about unsupported ibmlongdouble

nikic added a reviewer: PowerPC. nikic added a comment. Can you please upload the patch with full context (`-U9`)? The assumption here is that `libc++` is being compiled with a compiler that has the same ieeelongdouble default as the clang that is being built, right? I guess that's the

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

qiucf created this revision. qiucf added reviewers: andrew.w.kaylor, sepavloff, kpn, RKSimon, craig.topper, nemanjai, cameron.mcinally. Herald added subscribers: jeroen.dobbelaere, StephenFan, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX,

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480773. rcvalle added a comment. Added compression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst

[PATCH] D139378: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 4 or 4)

jmciver updated this revision to Diff 480767. jmciver added a comment. Updating D139378 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 4 or 4) Update vector-noundef.cpp with rvalue element being stored in lvalue vector. Repository:

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

rprichard added a comment. As an aside, it seems interesting that libcxxabi/test/forced_unwind[12].pass.cpp don't compile for ARM EHABI when used with Clang's unwind.h. AFAICT it's been that way for a long time? $ /x/clang14/bin/clang -target arm-linux-gnueabi

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

tentzen added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * lebedev.ri wrote: > efriedma wrote: > > lebedev.ri wrote: > > > tentzen wrote: > > > > lebedev.ri

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

rprichard created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. rprichard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the same approach as used in libunwind/include/unwind_arm_ehabi.h (D89570

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480760. Amir added a comment. Fixed COMPILER_LAUNCHER, perf2bolt invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#3974946 , @MaskRay wrote: > This makes `-mmcu=` available for non-AVR targets, which is not right. > Even for AVR, if this is a plain alias, is this really necessary? Usually > having more than one aliases for one

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139305/new/ https://reviews.llvm.org/D139305 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/avr-mmcu.c Index:

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480748. benshi001 retitled this revision from "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'" to "[clang][driver] Support option '-mcpu' on target AVR.". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION

[clang] 4857b6f - Revert "Store OptTable::Info::Name as a StringRef"

Author: Douglas Yung Date: 2022-12-06T19:37:05-08:00 New Revision: 4857b6f8fff614c89ed35031c298df81394459af URL: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af DIFF: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af.diff

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480739. Amir added a comment. Fix dependence between bolt-profile and clang (either instrumented or not) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files:

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 480737. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.org/D137996 Files:

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir created this revision. Amir added reviewers: bolt, phosek. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `perf` provides a faster and easier way to collect BOLT profile. Generalize CMake handling of

[PATCH] D139406: C++20] [Modules] [Serialization] Deserialize LValuePathSerializationHelper's type properly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303f20a2cab4: [C++20] [Modules] [Serialization] Deserialize (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber:

[clang] 303f20a - [C++20] [Modules] [Serialization] Deserialize

Author: Chuanqi Xu Date: 2022-12-07T10:52:02+08:00 New Revision: 303f20a2cab4554a10ec225fd853709146f8c51c URL: https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c DIFF: https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c.diff

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 updated this revision to Diff 480703. ziqingluo-90 added a comment. Addressing all the comments we have so far. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137379/new/ https://reviews.llvm.org/D137379 Files:

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480700. rcvalle retitled this revision from "Add support for integer types normalization" to "Add CFI integer types normalization". rcvalle edited the summary of this revision. rcvalle added a comment. Added documentation Repository: rG LLVM Github

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:16 +void testArraySubscripts(int *p, int **pp) { + foo(p[0], // expected-warning{{unchecked operation on raw buffer in expression}} + pp[0][0], //

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:128-130 + /// Store hierarchy information for a given record. + /// + /// This is roughly analogous to the DeclContext hierarchy for an AST Node. Misplaced comment?

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. Comment at: clang/lib/Sema/SemaInit.cpp:5947 if (TryOCLZeroOpaqueTypeInitialization(S, *this, DestType, Initializer)) return; #1/5 Coverity reported explicit null dereference of 'Initializer' Comment

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:161 + case HIF_Textual: { +assert(!DepOpts.HeaderIncludeFiltering && + "header filtering is currently always disabled when output format is" ahatanak wrote: >

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Oh, right, PS4 defaults to C99. It's okay with me if you make those two unsupported for PS4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597

[clang] 6ab6085 - Revert "DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions"

Author: David Blaikie Date: 2022-12-06T22:52:47Z New Revision: 6ab6085c77ef9bcdabf842342f63fba4291791a4 URL: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4 DIFF: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4.diff

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

dyung added a comment. @serge-sans-paille Your change is causing 24 test failures on the Linux PS4 bot, mostly with an assertion failure it seems. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/32263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Hmm, it seems the `assert` doesn't work in that location. The Linux and Windows builds both failed. It would be good to identify a simple test case for that. It seems

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139428/new/ https://reviews.llvm.org/D139428 ___ cfe-commits

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f121e85384: [clang-format] Fix an assertion failure in block parsing (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 15f121e - [clang-format] Fix an assertion failure in block parsing

Author: Owen Pan Date: 2022-12-06T14:14:20-08:00 New Revision: 15f121e853846d7c74c243a4249a069dd67ca166 URL: https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166 DIFF: https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166.diff

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. Can you rebase (preferably after landing D138402 )? Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool

[clang] 5951b0b - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-06T22:51:28+01:00 New Revision: 5951b0bb23f3265bea16f28c2af9d278b9d829c6 URL: https://github.com/llvm/llvm-project/commit/5951b0bb23f3265bea16f28c2af9d278b9d829c6 DIFF:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are still disabled by

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman updated this revision to Diff 480600. aaron.ballman added a comment. Adding some more test cases that demonstrate that you can still call these functions as you'd expect and that function pointer assignment works as expected. CHANGES SINCE LAST ACTION

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

HazardyKnusperkeks added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138373/new/ https://reviews.llvm.org/D138373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks updated this revision to Diff 480597. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138402/new/ https://reviews.llvm.org/D138402 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir created this revision. Amir added reviewers: bolt, phosek, MaskRay. Herald added subscribers: StephenFan, wenlei. Herald added a project: All. Amir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Instead of creating

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/test/CXX/class/class.compare/class.spaceship/p1.cpp:106 Cmp() <=> Cmp(), // expected-note-re {{in defaulted three-way comparison operator for '{{.*}}Cmp<{{.*}}G2>' first required here}}j - // expected-error@#cmp {{no

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 480596. ayzhao marked 3 inline comments as done. ayzhao added a comment. restore original diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[clang] fe21126 - [Windows] Convert tests to check 'target=...'

Author: Paul Robinson Date: 2022-12-06T13:15:48-08:00 New Revision: fe2112611258f9a16f101d642f3dfe7a47a161d7 URL: https://github.com/llvm/llvm-project/commit/fe2112611258f9a16f101d642f3dfe7a47a161d7 DIFF: https://github.com/llvm/llvm-project/commit/fe2112611258f9a16f101d642f3dfe7a47a161d7.diff

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. LGTM. I agree with the commentary in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c312e48f325: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions (authored by dblaikie). Changed prior to commit:

[clang] 3c312e4 - DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

Author: David Blaikie Date: 2022-12-06T21:11:08Z New Revision: 3c312e48f325c1b1ee11404ee6cfa08ee00037b0 URL: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0 DIFF: https://github.com/llvm/llvm-project/commit/3c312e48f325c1b1ee11404ee6cfa08ee00037b0.diff

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd95d7998c1d: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cd95d79 - [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

Author: Félix Cloutier Date: 2022-12-06T13:08:18-08:00 New Revision: cd95d7998c1dd30c6353aeca2686697287cb0443 URL: https://github.com/llvm/llvm-project/commit/cd95d7998c1dd30c6353aeca2686697287cb0443 DIFF:

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

dblaikie added a comment. In D137059#3973096 , @iains wrote: > In D137059#3973016 , @ben.boeckel > wrote: > >> In D137059#3934448 , @dblaikie >> wrote: >> >>> I'm still

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This minimal patch LGTM. Comment at: llvm/lib/IR/DIBuilder.cpp:159 - assert(((Lang <= dwarf::DW_LANG_Fortran08 && Lang >= dwarf::DW_LANG_C89) || + assert(((Lang <=

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a subscriber: eli.friedman. zahiraam added a comment. @eli.friedman Thanks. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 480574. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139416/new/ https://reviews.llvm.org/D139416

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:161 + case HIF_Textual: { +assert(!DepOpts.HeaderIncludeFiltering && + "header filtering is currently always disabled when output format is" jansvoboda11 wrote: >

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom created this revision. tuliom added projects: clang, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: MaskRay. When -mabi=ieeelongdouble is enabled by default, libc++ does not support

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

aaron.ballman added a comment. Generally looks correct to me. Comment at: clang/lib/AST/Interp/PrimType.h:65 +constexpr bool aligned(size_t Size) { return Size == align(Size); } +static_assert(aligned(sizeof(void *))); I think `Size` should be something more

[clang] f926826 - [SystemZ] Add "REQUIRES: systemz-registered-target" on test.

Author: Jonas Paulsson Date: 2022-12-06T13:38:48-06:00 New Revision: f926826c2e836b09cd2517775758f373bbc330bf URL: https://github.com/llvm/llvm-project/commit/f926826c2e836b09cd2517775758f373bbc330bf DIFF:

[PATCH] D139154: [clang-doc] Add template support

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:205 + + // The literal contents of the code for that specifies this template parameter + // for this declaration. Typical values will be "class T" and

[PATCH] D139154: [clang-doc] Add template support

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480560. brettw marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will be

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

aaron.ballman added a comment. Generally LGTM but I'd appreciate a second pass by @rnk in case I've missed something. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8845-8846 let CategoryName = "Inline Assembly Issue" in { + def err_asm_pmf_in_input +:

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3975223 , @Endill wrote: > @shafik does this imply that example from [over.match.best]/4 should be > included in this patch? Yes, I believe we should. We are only conforming if we get all of the cases correct.

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBlock.h:97 void invokeCtor() { -std::memset(data(), 0, getSize()); +std::memset(rawData(), 0, Desc->getAllocSize()); if (Desc->CtorFn) tbaeder wrote: > aaron.ballman

[libunwind] 8482e95 - [libunwind] Use .irp directives. NFC

Author: Fangrui Song Date: 2022-12-06T19:05:04Z New Revision: 8482e95f75d02227fbf51527680c0b5424bacb69 URL: https://github.com/llvm/llvm-project/commit/8482e95f75d02227fbf51527680c0b5424bacb69 DIFF: https://github.com/llvm/llvm-project/commit/8482e95f75d02227fbf51527680c0b5424bacb69.diff LOG:

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:17-19 +// Because the analysis revolves around variables and their types, we'll need to +// track uses of variables (aka DeclRefExprs). +using DeclUseList = SmallVector;

[PATCH] D139154: [clang-doc] Add template support

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is basically LGTM. There are a few comments I think could be phrased a bit more clearly, but otherwise are more or less fine. Comment at:

[PATCH] D105067: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jonpa marked an inline comment as done. Closed by commit rG481bb44baab5: [SystemZ] Emit a .gnu_attribute for an externally visible vector abi. (authored by jonpa).

[clang] 481bb44 - [SystemZ] Emit a .gnu_attribute for an externally visible vector abi.

Author: Jonas Paulsson Date: 2022-12-06T12:53:40-06:00 New Revision: 481bb44baab5ce7a005b7d7eee6cafbde672695c URL: https://github.com/llvm/llvm-project/commit/481bb44baab5ce7a005b7d7eee6cafbde672695c DIFF:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + lenary wrote:

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. @shafik does this imply that example from [over.match.best]/4 should be included in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc46d6e67fab: [clang][Tooling] Add support for generating #import edits (authored by dgoldman). Changed prior to commit:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51f1ae52b0c9: [clangd] Add new IncludeDirective to IncludeHeaderWithReferences (authored by dgoldman). Changed prior to commit:

[clang] fc46d6e - [clang][Tooling] Add support for generating #import edits

Author: David Goldman Date: 2022-12-06T13:47:07-05:00 New Revision: fc46d6e67fab06d54c8948ebf959d62984116bc3 URL: https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3 DIFF: https://github.com/llvm/llvm-project/commit/fc46d6e67fab06d54c8948ebf959d62984116bc3.diff

[clang] 51f1ae5 - [clangd] Add new IncludeDirective to IncludeHeaderWithReferences

Author: David Goldman Date: 2022-12-06T13:47:07-05:00 New Revision: 51f1ae52b0c92a9783e7df328d05b1f95dca74d1 URL: https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1 DIFF: https://github.com/llvm/llvm-project/commit/51f1ae52b0c92a9783e7df328d05b1f95dca74d1.diff

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + tschuett wrote:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

tschuett added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + I believe you

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have). If there are suffixes, I'll

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 480542. manas marked an inline comment as done. manas added a comment. Add more tests for complete coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added a reviewer: sdesmalen. lenary added a subscriber: sdesmalen. lenary added a comment. @sdesmalen adding you as I've moved around the custom lowering of `INTRINSIC_VOID` to be its own function, and as we need to handle it for `@llvm.arm.prefetch` all the time, it's no longer

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 2 inline comments as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1624 + if (LHS.isEmpty() || RHS.isEmpty()) +return RangeFactory.getEmptySet(); + steakhal wrote: > This branch is

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson created this revision. probinson added reviewers: uweigand, Kai. Herald added a project: All. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Part of the project to eliminate special handling for

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change: - Modifies the ACLE code to allow the new

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

hans added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:7109 + case BuiltinType::Char8: +return getIntegerRank(CharTy.getTypePtr()); + case BuiltinType::Char16: tahonermann wrote: > This should technically be `UnsignedCharTy` though it

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

hans updated this revision to Diff 480538. hans marked 2 inline comments as done. hans added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139428/new/ https://reviews.llvm.org/D139428 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/vector.cpp

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante accepted this revision. Mordante added a comment. LGTM after addressing @aaron.ballman's comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 <

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480539. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for working on this! The changes LGTM. I've been trying to figure out if there's a way we can add test coverage for this change, but I'm really not coming up with much.

[PATCH] D139429: [clang] Add test for CWG418

shafik added a subscriber: aaron.ballman. shafik added a comment. In D139429#3975028 , @Endill wrote: > I opened #59363 on bug > tracker. > What should I do about this patch then? I believe

[PATCH] D139154: [clang-doc] Add template support

brettw marked an inline comment as done. brettw added a comment. New patch up. Comment at: clang-tools-extra/test/clang-doc/single-file.cpp:19 // CHECK-NEXT:DefLocation: -// CHECK-NEXT: LineNumber: [[@LINE-8]] +// CHECK-NEXT: LineNumber: 11 //

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480536. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139436: [C2x] Relaxing requirements for va_start

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaChecking.cpp:7230 + Val && LangOpts.C2x && *Val == 0) +return false; aaron.ballman wrote: > erichkeane

[clang-tools-extra] 3c255f6 - Process: convert Optional to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-06T09:56:14-08:00 New Revision: 3c255f679c90e332fe0b38b09d5811a64db3f0f6 URL: https://github.com/llvm/llvm-project/commit/3c255f679c90e332fe0b38b09d5811a64db3f0f6 DIFF:

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman updated this revision to Diff 480533. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Update based on review feedback. - Removed code setting the return type for the builtin (it's already set elsewhere) - Added test coverage verifying the return type

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. I opened #59363 on bug tracker. What should I do about this patch then? I believe availability `no` should come with a failing test. Should I include example from [over.match.best]/4 as another example in the test?

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else cor3ntin

  1   2   3   >