This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb88eb855b531: [clang] use correct builtin type for defaulted
comparison analyzer (authored by mizvekov).
Repository:
rG LLVM Github Monorepo
mizvekov added a comment.
@rsmith what do you think of the following strategy as a follow up to this
patch:
- First step we replace the assert at line 7866 with a `deleted` result. I
don't really think it's sustainable to keep returning incorrect results /
crashing for builtin types that are
mizvekov added a comment.
Since we can still crash with user defined conversion operators for any builtin
types not supported by `getComparisonCategoryForBuiltinCmp` (many others), I
will make a follow up patch to just replace that assert with a deleted result.
Repository:
rG LLVM Github
mizvekov created this revision.
Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy,
Szelethus, a.sidorin, baloghadamsoftware.
mizvekov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes PR50591.
When
