[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for -co_await(auto i : arr) {} +co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}}

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9f3c6d86b4: [Coroutine] Warn deprecated std::experimental::coro

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Quuxplusone accepted this revision as: Quuxplusone. Quuxplusone added a comment. FWIW, the problem with SpacesInAngles: Leave ^ is that the debian builder has an outdated (or maybe just 13.x?) `clang-format`; this option is super new. I don't know what the appropriate

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu added a comment. The CI fails. But I guess it would be irrelevant with this diff: /var/lib/buildkite-agent/builds/llvm-project/libcxx/.clang-format:6:17: error: invalid boolean SpacesInAngles: Leave ^ Error reading

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387828. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Use `-Wno-coroutine` instead of `-Wno-deprectated-experimental-coroutine` to keep CI stable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for -co_await(auto i : arr) {} +co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}}

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu updated this revision to Diff 387811. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D113977 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015-11017 + "Found deprecated std::experimental::%0. Consider to update your libc++ "

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

Mordante accepted this revision. Mordante added a comment. Thanks for working on this and landing the coroutines. LGTM after applying @ldionne's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM with some suggestions, thanks for adding this notice! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:57-59 +def DeprecatedCorotuine : +

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu created this revision. ChuanqiXu added reviewers: Quuxplusone, ldionne. ChuanqiXu added projects: clang, libc++. Herald added a subscriber: lxfind. ChuanqiXu requested review of this revision. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Since