[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a68babd9973: [clang-doc] Add template support. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480979. brettw added a comment. New patch with llvm::Optional converted to std::optional (previously collided with a refactor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files:

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6dbb5f1646: [clang-doc] Add template support. (authored by brettw). Changed prior to commit: https://reviews.llvm.org/D139154?vs=480560=480960#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139154: [clang-doc] Add template support

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:205 + + // The literal contents of the code for that specifies this template parameter + // for this declaration. Typical values will be "class T" and

[PATCH] D139154: [clang-doc] Add template support

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480560. brettw marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is basically LGTM. There are a few comments I think could be phrased a bit more clearly, but otherwise are more or less fine. Comment at:

[PATCH] D139154: [clang-doc] Add template support

brettw marked an inline comment as done. brettw added a comment. New patch up. Comment at: clang-tools-extra/test/clang-doc/single-file.cpp:19 // CHECK-NEXT:DefLocation: -// CHECK-NEXT: LineNumber: [[@LINE-8]] +// CHECK-NEXT: LineNumber: 11 //

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480536. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

paulkirth added a comment. Can we also update the end-to-end tests with some relevant test cases? I think that's especially important, given that I'm not sure the unittests are running as part of the normal test suite. Overall this is mostly LGTM with some minor comments/questions.

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480251. brettw added a reviewer: paulkirth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 479772. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D139154: [clang-doc] Add template support

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Decodes the template parameters for both functions and records. For template specializations, records a