[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-23 Thread via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/89606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > @Xazax-hun WDYT? If it really takes over an hour to analyze a file in clang-18, I'd agree that this has similar severity to a crash, and I support backporting the fix. https://github.com/llvm/llvm-project/pull/89606 ___

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Balazs Benics via cfe-commits
steakhal wrote: Ah, I think rushed ahead of myself. I applied the patch to clang-17, where it of course we didn't have any issues even with this broken `isTainted`. Now that I applied the patch to our clang-18 based branch, the file analyzes in 1:40, which is still far off from the baseline

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks! The patch makes sense. Thank you for the promptly fix. I've checked and this resolves the `FFmpeg` issue. i wonder if this is serious enough to consider hangs as a crash and nominate this PR for backport to `clang-18`. Leave me no

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/89606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp approved this pull request. The suggested change make a lot of sense. Thanks. LGTM. https://github.com/llvm/llvm-project/pull/89606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (NagyDonat) Changes Previously the function ``` std::vectorSymbolRef taint::getTaintedSymbolsImpl(ProgramStateRef State, const MemRegion *Reg,

[clang] [analyzer] Fix performance of getTaintedSymbolsImpl() (PR #89606)

2024-04-22 Thread via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/89606 Previously the function ``` std::vector taint::getTaintedSymbolsImpl(ProgramStateRef State, const MemRegion *Reg,