[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98682/new/ https://reviews.llvm.org/D98682 ___ cfe-commits mailing

[clang] 6782417 - [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Author: Jim Lin Date: 2021-03-16T14:57:45+08:00 New Revision: 678241795c957b18bc473045e48abe3f2a61ff5c URL: https://github.com/llvm/llvm-project/commit/678241795c957b18bc473045e48abe3f2a61ff5c DIFF: https://github.com/llvm/llvm-project/commit/678241795c957b18bc473045e48abe3f2a61ff5c.diff LOG:

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG678241795c95: [RISCV] Dont emit #undef BUILTIN from RISCVVEmitter.cpp (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Jim updated this revision to Diff 330888. Jim added a comment. Address @craig.topper 's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98682/new/ https://reviews.llvm.org/D98682 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

balazske added a comment. Exactly the case is (I think) that the mutex goes out of scope and we have not checked if it was really destroyed. Still the program can check later if it was destroyed (like the `if` in the test case). A resource leak may be the problem (if destroy failed) so a

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 330901. curdeius marked 4 inline comments as done. curdeius added a comment. - Add test. - Remove unnecessary PrototypeScope.exit(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

uabelho added a comment. Hi, I'm seeing a problem with this. Compiling with gcc 9.3.0 the compilation of the test program works, but then when I run it I get /repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21'

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

nikic added a comment. It looks like this has caused a compile-time regression at `O0`: https://llvm-compile-time-tracker.com/compare.php?from=9341bcbdc93a251b632ffaa51a84452a7a4a5e4e=4f198b0c27b04e830a3069aaf4b39cf203eaae4a=instructions The cause is probably the computation of DomTree and

[clang-tools-extra] 3b99731 - [clangd] Turn off implicit cancellation based on client capabilities

Author: Sam McCall Date: 2021-03-16T12:27:40+01:00 New Revision: 3b99731c4e7bb844699eda6640bd99344f800c79 URL: https://github.com/llvm/llvm-project/commit/3b99731c4e7bb844699eda6640bd99344f800c79 DIFF: https://github.com/llvm/llvm-project/commit/3b99731c4e7bb844699eda6640bd99344f800c79.diff

[clang-tools-extra] 128ce70 - [CodeCompletion] Avoid spurious signature help for init-list args

Author: Sam McCall Date: 2021-03-16T12:46:40+01:00 New Revision: 128ce70eef9948b81e725fd0e2ed46a7c004a118 URL: https://github.com/llvm/llvm-project/commit/128ce70eef9948b81e725fd0e2ed46a7c004a118 DIFF: https://github.com/llvm/llvm-project/commit/128ce70eef9948b81e725fd0e2ed46a7c004a118.diff

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG128ce70eef99: [CodeCompletion] Avoid spurious signature help for init-list args (authored by sammccall). Herald added a project: clang-tools-extra.

[PATCH] D98685: [X86][AMX] Rename amx-bf16 intrinsic according to correct naming convention __tile_tdpbf16ps should be renamed with __tile_dpbf16ps

yubing created this revision. Herald added a subscriber: pengfei. yubing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98685 Files: clang/lib/Headers/amxintrin.h

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius added a comment. Thank you for the review Aaron. I hope having addressed your comments so far. I'm not sure for the prototype scope though. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1440 + } else if (getLangOpts().CPlusPlus2b) { +ParseScope

[clang] a92693d - [CodeCompletion] Don't track preferred types if code completion is disabled.

Author: Sam McCall Date: 2021-03-16T12:16:10+01:00 New Revision: a92693dac4592e7bfbd9caf09939d46756de3821 URL: https://github.com/llvm/llvm-project/commit/a92693dac4592e7bfbd9caf09939d46756de3821 DIFF: https://github.com/llvm/llvm-project/commit/a92693dac4592e7bfbd9caf09939d46756de3821.diff

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330937. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https://reviews.llvm.org/D98246 Files:

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added inline comments. Comment at: clang/lib/AST/Expr.cpp:1387 + + auto CreateDependentType = []() { +ASTContext::GetBuiltinTypeError Error; hokein wrote: > this can be removed, dependent type is a builtin type, so you could just use >

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: llvm/cmake/modules/GetErrcMessages.cmake:3-6 +# The purpose of this function is to supply those error messages to llvm-lit using the errc_messages config +# Currently supplied and needed

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius added a comment. That looks really good. Please add tests as indicated in the inline comments and fix the formatting (see clang-format warnings). Comment at: clang/include/clang/Format/Format.h:1912 +/// Keep existing empty lines after access modifiers. +///

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2628477 , @uabelho wrote: > Hi, > > I'm seeing a problem with this. Compiling with gcc 9.3.0 the compilation of > the test program works, but then when I run it I get > > >

[PATCH] D98414: [clangd] Turn off implicit cancellation based on client capabilities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b99731c4e7b: [clangd] Turn off implicit cancellation based on client capabilities (authored by sammccall). Herald added a project:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added a comment. In D93594#2628497 , @nikic wrote: > It looks like this has caused a compile-time regression at `O0`: >

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. In D98411#2628592 , @Anastasia wrote: > In D98411#2626613 , @ldrumm wrote: > >> Given this fixes a runtime crash bug, should it be backported to the >> relevant release branch? > > Sure,

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

jhenderson added a comment. In D98278#2628433 , @zero9178 wrote: > I addressed your comments in > https://reviews.llvm.org/rG4a17ac0387f078529da02e355a24df99f645d364. Hope it > should be alright now Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3683 +Style.BraceWrapping.AfterEnum; +bool isLineTooBig = (strlen(Right.TokenText.data()) + + Right.OriginalColumn) > Style.ColumnLimit; atirit

[PATCH] D98694: [-Wcalled-once-parameter] Fix false positives for cleanup attr

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Cleanup attribute allows users to attach a destructor-like functions to

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG43d0b1c9c16c: [clangd] Reject renames to non-identifier characters (authored by sammccall). Herald added a project: clang-tools-extra. Changed prior to commit:

[clang-tools-extra] 43d0b1c - [clangd] Reject renames to non-identifier characters

Author: Sam McCall Date: 2021-03-16T12:18:29+01:00 New Revision: 43d0b1c9c16c7b435ae301d0a856fc48123e08c7 URL: https://github.com/llvm/llvm-project/commit/43d0b1c9c16c7b435ae301d0a856fc48123e08c7 DIFF: https://github.com/llvm/llvm-project/commit/43d0b1c9c16c7b435ae301d0a856fc48123e08c7.diff

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! let's ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https://reviews.llvm.org/D98246

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske added reviewers: NoQ, ASDenysPetrov. balazske added a comment. Herald added a subscriber: Charusso. This patch makes one TODO less and it is possible to debug cases like in the next (in stack) change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98685: [X86][AMX] Rename amx-bf16 intrinsic according to correct naming convention

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98685/new/ https://reviews.llvm.org/D98685

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:318-319 +// calculate idxa, idxb, idxc +// %eltc = extractelement <256 x i32> %vec.c.inner.phi, i16 %idxc +// %eltcf32 = bitcast i32 %eltc to float +// %elta = extractelement

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:308 + .count()); +// FIXME(kirillbobyrev): This is not really "freshness", this is just the +// time since last index reload.

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

uabelho added a comment. In D98278#2628482 , @zero9178 wrote: > In D98278#2628477 , @uabelho wrote: > >> so perhaps there should be some additional error handling when running the >> compiled program doesn't work?

[clang-tools-extra] ca13f55 - [clangd] Add `limit` extension on completion and workspace-symbols

Author: Sam McCall Date: 2021-03-16T12:28:01+01:00 New Revision: ca13f5595ae8dc7326f29c8658de70bbc1854db0 URL: https://github.com/llvm/llvm-project/commit/ca13f5595ae8dc7326f29c8658de70bbc1854db0 DIFF: https://github.com/llvm/llvm-project/commit/ca13f5595ae8dc7326f29c8658de70bbc1854db0.diff

[PATCH] D97801: [clangd] Add `limit` extension on completion and workspace-symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca13f5595ae8: [clangd] Add `limit` extension on completion and workspace-symbols (authored by sammccall). Herald added a project: clang-tools-extra.

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added reviewers: MyDeveloperDay, HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ReleaseNotes.rst:168 +- Option

[PATCH] D98688: [-Wcalled-once-parameter] Harden analysis in terms of block use

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces a very simple inter-procedural analysis between

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

jhenderson added inline comments. Comment at: llvm/cmake/modules/GetErrcMessages.cmake:3-6 +# The purpose of this function is to supply those error messages to llvm-lit using the errc_messages config +# Currently supplied and needed error codes: ENOENT, EISDIR, EINVAL and

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

yubing added inline comments. Comment at: clang/lib/Headers/amxintrin.h:326 +__DEFAULT_FN_ATTRS_BF16 +static void __tile_tdpbf16ps(__tile1024i *dst, __tile1024i src1, + __tile1024i src2) { Should we align this with "tile_dpbssd" by

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added inline comments. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> bsmith wrote: >

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 marked 4 inline comments as done. zero9178 added a comment. I addressed your comments in https://reviews.llvm.org/rG4a17ac0387f078529da02e355a24df99f645d364. Hope it should be alright now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa92693dac459: [CodeCompletion] Dont track preferred types if code completion is disabled. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr

aaron.ballman added a comment. As far as the changes go, these seem reasonable to me, though I find it a bit odd that these are expressions without a type whereas a `ParenExpr` has a type of the underlying parenthesized expression. e.g., int x(0); // (0) has void type int y = (0); // (0)

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added a comment. In D98411#2626613 , @ldrumm wrote: > Given this fixes a runtime crash bug, should it be backported to the relevant > release branch? Sure, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 330898. yubing added a comment. just do a rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110 Files: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

jhenderson added a comment. Thanks for working on this. A couple of post-commit comments to look at, otherwise looks good. Thanks for figuring out how to do this in a portable manner! Comment at: llvm/cmake/modules/GetErrcMessages.cmake:1 + +# This function returns the

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2628527 , @uabelho wrote: > In D98278#2628482 , @zero9178 wrote: > >> In D98278#2628477 , @uabelho wrote: >> >>> so perhaps there should

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 +ELAAMS_Leave, +/// Always add empty line after access modifiers. +/// \code It does not always add, it does enforces one empty line, or am I mistaken?

[clang-tools-extra] 2772c3a - [clangd] Introduce pullDiags endpoint

Author: Kadir Cetinkaya Date: 2021-03-16T12:52:15+01:00 New Revision: 2772c3a9752289ffec473b62f84855262a22de0b URL: https://github.com/llvm/llvm-project/commit/2772c3a9752289ffec473b62f84855262a22de0b DIFF:

[clang-tools-extra] 524fe51 - [clangd] Add basic monitoring info request for remote index server

Author: Kirill Bobyrev Date: 2021-03-16T13:37:58+01:00 New Revision: 524fe515091d31e1c054fc521113a3bf2088d159 URL: https://github.com/llvm/llvm-project/commit/524fe515091d31e1c054fc521113a3bf2088d159 DIFF:

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524fe515091d: [clangd] Add basic monitoring info request for remote index server (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi accepted this revision. zibi added a comment. This revision is now accepted and ready to land. LTGM, thx for an extra mile, Abhina. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785

[clang-tools-extra] 9a5af54 - [clang-tidy] Remove readability-deleted-default

Author: Nathan James Date: 2021-03-16T14:03:33Z New Revision: 9a5af541ee058b85a92113ecf9d38a06ef2b313d URL: https://github.com/llvm/llvm-project/commit/9a5af541ee058b85a92113ecf9d38a06ef2b313d DIFF: https://github.com/llvm/llvm-project/commit/9a5af541ee058b85a92113ecf9d38a06ef2b313d.diff LOG:

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:78 +- libToolingCore and Clang-Tidy was refactored and now checks can produce + highlights (``^`` under fragments of the source code) in diagnostics. + Existing and new checks in the

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});

[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D98664#2628742 , @aaronpuchert wrote: > In D98664#2628591 , @aaron.ballman > wrote: > >> As

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

awarzynski added a comment. In D96771#2628691 , @svenvh wrote: > In D96771#2626507 , @Anastasia wrote: > >> I had a second thought about the extension name and I realized that the >> reason why I initially wanted

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added a comment. In D96771#2626507 , @Anastasia wrote: > I had a second thought about the extension name and I realized that the > reason why I initially wanted to use `clcpp` is that it aligns better with > `clc++` which is used in `-cl-std`.

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330952. abhina.sreeskantharajan added a comment. Sorry Zibi, I misunderstood your comment. I updated the patch to switch around the Flag and Mode defaults in createUniqueFile because the flags was set explicitly more often than mode. I also

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

aaron.ballman added a comment. I think this seems reasonable, but one question I have is: do we want to accept lambdas without parens in older C++ modes as an extension (with suitable compatibility warnings)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98665: Correct Doxygen syntax for inline code

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I wonder if this is something our `-Wdocumentation` should warn about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

ldrumm created this revision. ldrumm added reviewers: Anastasia, bader. ldrumm added a project: clang. Herald added a subscriber: yaxunl. ldrumm requested review of this revision. Herald added a subscriber: cfe-commits. CodeGenFunction::EmitRuntimeCall automatically sets the right calling │

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Herald added a project: clang-tools-extra. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 ___ cfe-commits mailing list

[PATCH] D98665: Correct Doxygen syntax for inline code

aaronpuchert added a comment. In D98665#2628851 , @aaron.ballman wrote: > LGTM! I wonder if this is something our `-Wdocumentation` should warn about? Interestingly we warn about the opposite problem: /// @endcode int x; produces "warning:

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:771 +TempPath, fd, TempPath, +llvm::sys::fs::all_read | llvm::sys::fs::all_write, +Binary ?

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Herald added a project: clang-tools-extra. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list

[PATCH] D98665: Correct Doxygen syntax for inline code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cb15b10ea37: Correct Doxygen syntax for inline code (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1cb15b1 - Correct Doxygen syntax for inline code

Author: Aaron Puchert Date: 2021-03-16T15:17:45+01:00 New Revision: 1cb15b10ea370178871769929ff9690f461191fc URL: https://github.com/llvm/llvm-project/commit/1cb15b10ea370178871769929ff9690f461191fc DIFF: https://github.com/llvm/llvm-project/commit/1cb15b10ea370178871769929ff9690f461191fc.diff

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

azabaznov added a comment. I have one more though. I like the idea of turning `opencl-c.h` into the test: as it is already in the repo and is already being used for quite a while we can assume it as a mainline for now. I think the first step should be to test that `-fdeclare-oprencl-builtins`

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 330954. tbaeder added a comment. Dropped the `FORCE` stuff since we can just set the variable directly and that shouldn't make a difference as far was I know. And the warning now only appears if either LTO or LLD are enabled. CHANGES SINCE LAST ACTION

[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr

aaronpuchert added a comment. In D98664#2628591 , @aaron.ballman wrote: > As far as the changes go, these seem reasonable to me, though I find it a bit > odd that these are expressions without a type whereas a `ParenExpr` has a > type of the underlying

[PATCH] D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

steakhal created this revision. steakhal added reviewers: a.sidorin, shafik, martong, balazske. Herald added subscribers: teemperor, rnkovacs. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After the import, we did not copy the

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

awarzynski updated this revision to Diff 330978. awarzynski added a comment. Switch back from `-fdebug-dump-symbols-sources` to `-fget-symbols-sources` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98191/new/ https://reviews.llvm.org/D98191

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

awarzynski added a comment. In D98191#2611694 , @tskeith wrote: > `-fget-symbols-sources` is not a debug option, it's intended for integrating > with IDEs like vscode. So I think the original name is better. Unlike the > "dump" options it actually is an

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith updated this revision to Diff 330951. bsmith added a comment. - Remove `SDTFPRoundEvenOp` as it's not a correct mirror of `SDTFPRoundOp` since that is not for `ISD::FROUND`. - Fix comments in `include/llvm/Target/TargetSelectionDAG.td` for `SDTFPRoundOp` and `SDTFPExtendOp`.

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330968. arnamoy10 added a comment. Adding the test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330973. arnamoy10 added a comment. Moving -std to non-dialect option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz added a comment. I'm super sorry to be popping in so late on this. Is this really the direction we should take? If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the configuration and logging a message seems like the wrong move when the only way to get into that state is

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:54 + "reverse_iterator", + "reverse_const_iterator"}); +

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder added a comment. In D89942#2629146 , @beanz wrote: > If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the > configuration and logging a message seems like the wrong move when the only > way to get into that state is to

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

foad created this revision. foad added reviewers: rampitec, kzhuravl, b-sumner. Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, arsenm. foad requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 331009. arnamoy10 added a comment. Updating to use available option from `Options.td` instead of creating a new option for `-Werror` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files:

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98705/new/ https://reviews.llvm.org/D98705

[clang] 440f6bd - [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall

Author: Luke Drummond Date: 2021-03-16T16:22:19Z New Revision: 440f6bdf34f4ce3ac3435d650f5296dcc0102488 URL: https://github.com/llvm/llvm-project/commit/440f6bdf34f4ce3ac3435d650f5296dcc0102488 DIFF: https://github.com/llvm/llvm-project/commit/440f6bdf34f4ce3ac3435d650f5296dcc0102488.diff

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

ychen added a comment. Herald added a project: clang-tools-extra. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/ https://reviews.llvm.org/D98110 ___ cfe-commits mailing list

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true", arsenm wrote: > I'm not sure where the "7" is coming from It's the next number after 6. I don't

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM. Thanks Jay! Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true",

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev added a comment. If a fix will be in ModuleManager and only for ModuleCache the problem with symlinks and path will not affect it as ModuleCache is managed by clang and we can rely on it. I agree that using `FileMgr.getBypassFile` is not the best way to solve this problem, we need

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330989. abhina.sreeskantharajan added a comment. NFC edit: Fix formatting/lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files:

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

beanz added a comment. In D89942#2629184 , @tbaeder wrote: > But that's not true. The `3-stage-base.cmake` sets > `BOOTSTRAP_LLVM_ENABLE_LTO` to `ON`, which doesn't work on SystemZ. This is > the initial problem I had. I was not interested in having LTO

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG440f6bdf34f4: [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

paulwalker-arm accepted this revision. paulwalker-arm added a comment. Mainly focused on the SVE side of things, which looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng updated this revision to Diff 331024. kito-cheng added a comment. Address jrtc27's and luismarques comment ChangeLogs - Move all new test to clang/test/Driver/riscv-toolchain-gcc-multilib.c - I don't found good way to test that on windows, since ExecuteAndWait only allow to

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM, if no one else has comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:481 + + assert(TargetIdx.hasValue() && "Matched, but didn't find index?"); + TargetParams[PassedParamOfThisFn].insert( I *think*

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

lebedev.ri added a comment. Some thoughts Comment at: clang/lib/CodeGen/CGStmt.cpp:796 + bool EmitBoolCondBranch = !C || !C->isOne(); + bool CondIsConst = C; const SourceRange = S.getSourceRange(); I think, if we really want to give this a name, perhaps

[PATCH] D33029: [clang-format] add option for dangling parenthesis

FelixBenning added a comment. If I understood it correctly there is a `BraceWrapping` group where `BraceWrappingAfterControlStatementStyle AfterControlStatement` is quite similar. It has a `Never`, `MultiLine`, and `Always` options. There is also a `bool AfterFunction` option which is

[PATCH] D98717: [AMDGPU] Split dot2-insts feature

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:511 +def FeatureDot7Insts : SubtargetFeature<"dot7-insts", + "HasDot7Insts", + "true", I'm not sure where the "7" is coming from Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   >