[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:20 +#undef BUILTIN Can you undef TARGET_BUILTIN here too? I missed that when I added it on line 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Jim created this revision. Jim added reviewers: khchen, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

ChuanqiXu added a comment. It looks like there are two things this patch wants to do: 1. Don't put the temporary generated by symmetric-transfer on the coroutine frame. 2. Offer a mechanism to force some values (it is easy to extend Alloca to Value) to put in the stack instead of the coroutine

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc12a64ecc71: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES

[clang] fc12a64 - [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

Author: Pushpinder Singh Date: 2021-03-16T04:58:14Z New Revision: fc12a64ecc71bf6789b3ca67d3cda77acc8785f9 URL: https://github.com/llvm/llvm-project/commit/fc12a64ecc71bf6789b3ca67d3cda77acc8785f9 DIFF: https://github.com/llvm/llvm-project/commit/fc12a64ecc71bf6789b3ca67d3cda77acc8785f9.diff

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn updated this revision to Diff 330865. hjelmn added a comment. One more issue with the test. Made a mistake with whether there is a space before the colon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f198b0c27b0: [X86] Pass to transform amx intrinsics to scalar operation. (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330860. atirit added a comment. Fixed remote build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

Re: [clang] 774b707 - Revert "Workaround a -Wmisleading-indentation warning"

Would be great to include details of why the patch was reverted - helps folks understand if this patch will address any issues they're seeing, or help avoid someone causing the same problem with a similar patch in the future. On Wed, Mar 10, 2021 at 3:36 PM Stephen Kelly via cfe-commits <

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov added a comment. I don't know what is going on with the clang-format linux failure here. The patch it suggests looks awful... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn updated this revision to Diff 330834. hjelmn added a comment. Fixed a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

efriedma added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + aaron.ballman wrote: > efriedma wrote:

[PATCH] D98665: Correct Doxygen syntax for inline code

aaronpuchert created this revision. aaronpuchert added reviewers: george.karpenkov, gribozavr2. Herald added subscribers: dexonsmith, martong. Herald added a reviewer: aaron.ballman. aaronpuchert requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

rsmith added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + aaron.ballman wrote: > efriedma wrote: >

[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr

aaronpuchert added inline comments. Comment at: clang/test/AST/ast-dump-templates.cpp:71-73 +template constexpr T var(0); +// DUMP: VarDecl {{.*}} col:35 var 'const T' constexpr callinit +// DUMP-NEXT: ParenListExpr {{.*}} 'void' This is what's currently

[PATCH] D98664: Fix crash on dumping AST containing constant initializer with ParenListExpr

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, riccibruno, rsmith. Herald added a subscriber: kristof.beyls. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The crash was introduced by D83183

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5352dd9dab1: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms. (authored by akhuang). Repository: rG LLVM Github Monorepo

[clang] f5352dd - Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

Author: Amy Huang Date: 2021-03-15T15:30:55-07:00 New Revision: f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2 URL: https://github.com/llvm/llvm-project/commit/f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2 DIFF: https://github.com/llvm/llvm-project/commit/f5352dd9dab1ee8a2ae19a3fca3111c8b5de8ce2.diff

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

akhuang updated this revision to Diff 330826. akhuang marked an inline comment as done. akhuang added a comment. add CHECK line to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98472/new/ https://reviews.llvm.org/D98472 Files:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330823. arnamoy10 added a comment. Adding one more update that is probably required in semanticContext (inspired by f18), also updated test case to require flang-driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

aaron.ballman added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + efriedma wrote: > aaron.ballman

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore… (authored by DiggerLin). Repository: rG LLVM

[clang] d1f1bff - [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

Author: diggerlin Date: 2021-03-15T17:33:02-04:00 New Revision: d1f1bff81bd9909fcfdb4d97af9e3ab5d827b529 URL: https://github.com/llvm/llvm-project/commit/d1f1bff81bd9909fcfdb4d97af9e3ab5d827b529 DIFF: https://github.com/llvm/llvm-project/commit/d1f1bff81bd9909fcfdb4d97af9e3ab5d827b529.diff

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Agreed that the right fix is to remove/replace the inode-based cache, but it's not safe to just drop it. Consider the following filesystem layout: /dir/file.h

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

efriedma added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + aaron.ballman wrote: > efriedma wrote:

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty accepted this revision. daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s DiggerLin

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfd301ec8b5: [SystemZ] Test for isinf and isfinite in testFPKind(). (authored by jonpa). Herald added a project: clang. Repository: rG LLVM

[clang] 9cfd301 - [SystemZ] Test for isinf and isfinite in testFPKind().

Author: Jonas Paulsson Date: 2021-03-15T15:02:39-06:00 New Revision: 9cfd301ec8b5ed6eb49bcc4b85e6f2af1a90b305 URL: https://github.com/llvm/llvm-project/commit/9cfd301ec8b5ed6eb49bcc4b85e6f2af1a90b305 DIFF:

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:687 + +unsigned Skew = 0; +if (HasMaskedOffOperand) ``` unsigned Skew = HasMaskedOffOperand ? 1 : 0; ``` unless this needs to get more complicated in a future patch?

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM (with the equal sign form as @daltenty requested if it works). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

hjelmn updated this revision to Diff 330800. hjelmn edited the summary of this revision. hjelmn added a comment. Updated change log and added a test to cover range based for with initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/

[PATCH] D97119: [flang][driver] Add options for -std=f2018

tskeith added inline comments. Comment at: flang/test/Driver/std2018.f90:9 +! RUN: %flang_fc1 -pedantic %s 2>&1 | FileCheck %s --check-prefix=GIVEN +! RUN: not %flang_fc1 -std=90 %s 2>&1 | FileCheck %s --check-prefix=WRONG + You need to make sure these work

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

daltenty added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s dunno if this is also accepted, but I think we

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +// SEW +Builder.defineMacro("__rvv_e8", "0"); I'm not sure if it makes sense to expose these from the compiler. Should we define them in the header instead? They

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

DiggerLin created this revision. DiggerLin added reviewers: hubert.reinterpretcast, jasonliu, sfertile, daltenty. Herald added a subscriber: arphaman. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. because we enable

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97901/new/ https://reviews.llvm.org/D97901 ___ cfe-commits mailing list

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:308 + .count()); +// FIXME(kirillbobyrev): This is not really "freshness", this is just the +// time since last index reload.

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330791. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Address comments, rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:547 + // there is no syntax I could find that would allow it). However, the option + // is handled properly on a real

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 330786. aaron.ballman added a comment. Update based on review feedback to gate use of -sycl-std on use of -fsycl-is-device or -fsycl-is-host. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330785. arnamoy10 added a comment. Adding the dummy modules CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

aaron.ballman added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + efriedma wrote: > aaron.ballman

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Hi, could someone please take a look at this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm w nit Comment at: clang/test/CodeGen/wmemchr.c:7 +const wchar_t *wmemchr_test(const wchar_t *s, const wchar_t c, size_t n) { + // CHECK: [[S:%.*]] = load + // CHECK:

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG86f2a3d17878: [PowerPC] Add __PCREL__ when PC Relative is enabled. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98546/new/

[clang] 86f2a3d - [PowerPC] Add __PCREL__ when PC Relative is enabled.

Author: Stefan Pintilie Date: 2021-03-15T15:13:02-05:00 New Revision: 86f2a3d17878e430109be209fdb013fb3f4716ee URL: https://github.com/llvm/llvm-project/commit/86f2a3d17878e430109be209fdb013fb3f4716ee DIFF:

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, SouraVX, tskeith, AMDChirag, sscalpone, bryanpkc. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bcf0eff99a0: [clangd] Optionally add reflection for clangd-index-server (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 9bcf0ef - [clangd] Optionally add reflection for clangd-index-server

Author: Kirill Bobyrev Date: 2021-03-15T21:07:25+01:00 New Revision: 9bcf0eff99a01094c685ff375a42e3f5a9166094 URL: https://github.com/llvm/llvm-project/commit/9bcf0eff99a01094c685ff375a42e3f5a9166094 DIFF:

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330775. mizvekov added a comment. broken bot rebuild repush Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330772. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files:

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

efriedma added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + aaron.ballman wrote: > Doesn't this

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf2796c76d2f: [test] Add ability to get error messages from CMake for errc substitution (authored by zero9178). Herald added a project: clang.

[clang] af2796c - [test] Add ability to get error messages from CMake for errc substitution

Author: Markus Böck Date: 2021-03-15T20:56:08+01:00 New Revision: af2796c76d2ff4b73165ed47959afd35a769beee URL: https://github.com/llvm/llvm-project/commit/af2796c76d2ff4b73165ed47959afd35a769beee DIFF: https://github.com/llvm/llvm-project/commit/af2796c76d2ff4b73165ed47959afd35a769beee.diff

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/MonitoringService.proto:17 + optional uint64 uptime = 1; + // Time since the index was built on the indexing machine. + optional uint64 freshness = 3; mention the units in here

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. FYI the testing of headers functionality is now being discussed in https://reviews.llvm.org/D97869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92004/new/ https://reviews.llvm.org/D92004

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2617063 , @svenvh wrote: > In D97869#2616772 , @Anastasia wrote: > >> Regarding 2 and 4 I think we should drive towards deprecation of >> `opencl-c.h` as it is a maintenance

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330762. arnamoy10 added a comment. 1. Update the test case to only test `flang-new -fc1` 2. Updated help text 3. Clang-formatted and also removed redundant code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield abandoned this revision. JonChesterfield added a comment. I'm going to abandon this. I'm not confident that a cuda toolkit that is newer than the compiler will work with it correctly and would prefer it take some jury rigging on the end users part to put the two together. I get

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:771 +TempPath, fd, TempPath, +llvm::sys::fs::all_read | llvm::sys::fs::all_write, +Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text); The `

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

anirudhp added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98622: [-Wcalled-once-parameter] Let escapes overwrite MaybeCalled states

vsavchenko updated this revision to Diff 330760. vsavchenko added a comment. Unify the way we deal with escapes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98622/new/ https://reviews.llvm.org/D98622 Files:

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:24 +; RVC-NEXT: c.jr ra +; CHECK: .section __patchable_function_entries,"awo",@progbits,f1{{$}} +; 32: .p2align 2 jrtc27 wrote: > Is there a

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay updated this revision to Diff 330759. MaskRay marked 5 inline comments as done. MaskRay added a comment. Change check prefixes from 32/64 to RV32/RV64 Rebase and use `MCInst getNop` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98610/new/

[PATCH] D94355: [Passes] Add relative lookup table converter pass

lebedev.ri added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:390-391 + +if (!TM.getTargetTriple().isArch64Bit()) + return false; + 1. But all tests are using `x86_64` triple? 2. This is somewhat backwards. if the target wants

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa updated this revision to Diff 330753. jonpa added a comment. > This "invert" logic doesn't look correct. "isfinite" and "isinf" both need to > return false on NaNs. I think you should just drop the invert logic and use a > TDC mask of 0xFC0 (zero, normal, or subnormal) to implement

[PATCH] D94355: [Passes] Add relative lookup table converter pass

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM pending a few more comments. Should also give some time to let others respond if they have feedback. Comment at:

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added a comment. In D97785#2626427 , @zibi wrote: > LGTM, I just wonder if we can make an extra parameter to be default. I notice > some places that is a default parameter

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 330747. abhina.sreeskantharajan added a comment. Removing llvm::Triple variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files:

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CMakeLists.txt:190 option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support for Clangd" OFF)

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:53 +void RISCVInstrInfo::getNoop(MCInst ) const { + if (STI.getFeatureBits()[RISCV::FeatureStdExtC]) MaskRay wrote: > jrtc27 wrote: > > I will forever wonder why TII didn't

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

aaron.ballman added inline comments. Comment at: clang/test/Sema/vla.c:134 + // expected-warning@+1{{variable length array folded to constant array as an extension}} + char (*a9)[] = (char[2][ksize]) {{1,2,3,4},{4,3,2,1}}; + Doesn't this violate the

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:53 +void RISCVInstrInfo::getNoop(MCInst ) const { + if (STI.getFeatureBits()[RISCV::FeatureStdExtC]) jrtc27 wrote: > I will forever wonder why TII didn't make it `MCInst

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

sammccall added a comment. Herald added a project: clang-tools-extra. Is this entirely obsoleted by the approach in D98499 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D97555

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay updated this revision to Diff 330744. MaskRay marked 8 inline comments as done. MaskRay added a comment. Mention supported targets in clang/include/clang/Basic/AttrDocs.td Use 4 llc RUN lines and --riscv-no-aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98498: [clangd] Enable modules to contribute tweaks.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. Should we have a test somewhere that tweaks defined in modules actually work? Comment at:

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

aaron.ballman added a comment. In D98635#2626485 , @whisperity wrote: > In D98635#2626464 , @whisperity > wrote: > >> Strange because I specifically ran both `check-clang` **and** >> `check-clang-tools` locally,

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330738. atirit added a comment. Implemented requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

whisperity updated this revision to Diff 330737. whisperity edited the summary of this revision. whisperity added a subscriber: compositeprimes. whisperity added a comment. Fixed a test file that I originally missed to align with the changes. CHANGES SINCE LAST ACTION

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13319 AllmanBraceStyle.BreakBeforeBraces = FormatStyle::BS_Allman; + AllmanBraceStyle.AllowShortEnumsOnASingleLine = false; HazardyKnusperkeks wrote: > curdeius wrote: > > That

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:1-3 +;; Test the function attribute "patchable-function-entry". +; RUN: llc -mtriple=riscv32 < %s | FileCheck %s --check-prefixes=CHECK,32 +; RUN: llc -mtriple=riscv64 < %s | FileCheck

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVMCInstLower.cpp:247 } + return false; } jrtc27 wrote: > true, surely? false. We want to call `EmitToStreamer(*OutStreamer, TmpInst);` If a

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab86edbc88fa: [AArch64] Implement __rndr, __rndrrs intrinsics (authored by stelios-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ab86edb - [AArch64] Implement __rndr, __rndrrs intrinsics

Author: Stelios Ioannou Date: 2021-03-15T17:51:48Z New Revision: ab86edbc88fa41e9cb9c6b43d99b69278c9c5040 URL: https://github.com/llvm/llvm-project/commit/ab86edbc88fa41e9cb9c6b43d99b69278c9c5040 DIFF: https://github.com/llvm/llvm-project/commit/ab86edbc88fa41e9cb9c6b43d99b69278c9c5040.diff

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

lxfind created this revision. Herald added subscribers: ChuanqiXu, hoy, modimo, wenlei, hiraditya. lxfind requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. One of the challenges with the alloca analysis in

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. Given this fixes a runtime crash bug, should it be backported to the relevant release branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411

[PATCH] D97846: Allow __ieee128 as an alias to __float128 on ppc

serge-sans-paille added a comment. Thanks @hubert.reinterpretcast , @jwakely and @hubert.reinterpretcast for the feedback on that review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97846/new/ https://reviews.llvm.org/D97846

[PATCH] D97846: Allow __ieee128 as an alias to __float128 on ppc

This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa510be78a7: Allow __ieee128 as an alias to __float128 on ppc (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 4aa510b - Allow __ieee128 as an alias to __float128 on ppc

Author: serge-sans-paille Date: 2021-03-15T18:28:26+01:00 New Revision: 4aa510be78a75a4da82657fe433016f00dad0784 URL: https://github.com/llvm/llvm-project/commit/4aa510be78a75a4da82657fe433016f00dad0784 DIFF:

[PATCH] D98637: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9628cb1feef6: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer (authored by serge-sans-paille). Herald added a

[clang] 9628cb1 - [NFC] Use higher level constructs to check for whitespace/newlines in the lexer

Author: serge-sans-paille Date: 2021-03-15T18:27:19+01:00 New Revision: 9628cb1feef63d764c57fd0652016f9188000e2f URL: https://github.com/llvm/llvm-project/commit/9628cb1feef63d764c57fd0652016f9188000e2f DIFF:

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcfd3fda7190: [OpenCL] Respect calling convention for builtin (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

ronlieb accepted this revision. ronlieb added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769 ___ cfe-commits mailing list

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. Abandon CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. This has been merged, closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330711. arnamoy10 added a comment. Clang-formatting and addressing reviewers' comments: Moved the default directory append to `setFortranOpts()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files:

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Agreed. Lack of save temps is causing grief when debugging, so I keep on applying this patch locally. Let's go with this for now. and change to something better when we

  1   2   >