[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114120/new/ https://reviews.llvm.org/D114120 ___ cfe-commits

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

wenlei added inline comments. Comment at: clang/include/clang/Driver/Options.td:5058-5061 + CodeGenOpts<"CXXCtorDtorAliases">, + DefaultFalse, + PosFlag, + NegFlag, nit: use two lines for consistency. check `sanitize_stats`, `sanitize_cfi_cross_dso` and

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

manojgupta added a reviewer: morehouse. manojgupta added a comment. Matt, do you think you can review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112091/new/ https://reviews.llvm.org/D112091 ___

[clang] 6113ea8 - [X86][Driver] Add X86 target option to avoid fail to other targets. NFC

Author: Phoebe Wang Date: 2021-11-18T12:37:36+08:00 New Revision: 6113ea8124d7db8620d392c85f96d78784918306 URL: https://github.com/llvm/llvm-project/commit/6113ea8124d7db8620d392c85f96d78784918306 DIFF: https://github.com/llvm/llvm-project/commit/6113ea8124d7db8620d392c85f96d78784918306.diff

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc added a comment. Thanks for the detailed comments. I moved the patch into the clangd callsite. I also added a couple ObjC tests for CallHierarchy (I basically parameterized two of the existing tests). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388101. sheldonneuberger-sc added a comment. - fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388100. sheldonneuberger-sc added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388099. sheldonneuberger-sc added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. - move change to clangd callsite - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9fba2be35db: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a9fba2b - [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

Author: Phoebe Wang Date: 2021-11-18T12:31:08+08:00 New Revision: a9fba2be35db674971382e38b99a31403444d9bf URL: https://github.com/llvm/llvm-project/commit/a9fba2be35db674971382e38b99a31403444d9bf DIFF: https://github.com/llvm/llvm-project/commit/a9fba2be35db674971382e38b99a31403444d9bf.diff

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MarcusJohnson91 added a comment. Not trying to take over this patch, because I've got a ton of patches I need to be finishing up myself. but I think the problematic code is in UnwrappedLineParser.cpp:1900 if (FormatTok->Tok.getKind() == ClosingBraceKind) { if (IsEnum &&

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#2849582 , @vsavchenko wrote: > In D104550#2849561 , @DavidSpickett > wrote: > >> @vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: >>

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MarcusJohnson91 added a comment. In D93938#2832825 , @Userbla wrote: > I applied this fix locally to a branch based off llvm 11.x and the > `FormatTest.FormatsTypedefEnum` test now fails. I'm running into this bug too. typedef enum Blah { One =

[PATCH] D112404: [SPIR-V] Add translator tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG49682f14bf3f: [SPIR-V] Add translator tool (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/

[clang] 49682f1 - [SPIR-V] Add translator tool

Author: Henry Linjamäki Date: 2021-11-18T03:41:24+03:00 New Revision: 49682f14bf3fb8db5e2721d9896b27bb4c2bd635 URL: https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635 DIFF:

[clang] 7411560 - [clang] Use range-based for loops with llvm::reverse (NFC)

Author: Kazu Hirata Date: 2021-11-17T19:40:48-08:00 New Revision: 74115602e82d0e758f8e311d545e127ce0a48cd7 URL: https://github.com/llvm/llvm-project/commit/74115602e82d0e758f8e311d545e127ce0a48cd7 DIFF: https://github.com/llvm/llvm-project/commit/74115602e82d0e758f8e311d545e127ce0a48cd7.diff

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei added a comment. Thanks for the review! Comment at: llvm/test/CodeGen/X86/no-ret-in-x87-reg.ll:147-150 +; NOX87-NEXT:fldt {{[0-9]+}}(%esp) +; NOX87-NEXT:fldt {{[0-9]+}}(%esp) +; NOX87-NEXT:faddp %st, %st(1) +; NOX87-NEXT:fstpt (%esp)

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGde34a940ae72: [X86] Add -mskip-rax-setup support to align with GCC (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112413/new/

[clang] de34a94 - [X86] Add -mskip-rax-setup support to align with GCC

Author: Phoebe Wang Date: 2021-11-18T11:20:32+08:00 New Revision: de34a940ae72dfa6425a025538484f9505ca1d42 URL: https://github.com/llvm/llvm-project/commit/de34a940ae72dfa6425a025538484f9505ca1d42 DIFF: https://github.com/llvm/llvm-project/commit/de34a940ae72dfa6425a025538484f9505ca1d42.diff

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei added a comment. Thanks @nickdesaulniers for the review! I found another problem with `SimpleMFlag`, to which `MarshallingInfoFlag` cannot be assigned separately. I'll land it as is then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay added a comment. Then please also update `docs/ClangPlugins.rst` to use driver option instead of CC1 `-plugin-arg` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. The idea LGTM. You need a test in `test/Driver` checking how the driver option maps to the CC1 option. You may check whether `REQUIRES: plugins, examples` is needed.

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. Thanks for @rjmccall 's summary and @scanon 's information. They are exactly the backgrounds I know for the requirment. Sorry I didn't and couldn't say it clearly in this way. @zahiraam , I took `__fp16` for example to illustrate the case for `a + b + c`, but didn't

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

rjmccall added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:372 + // Turn on _float16 for x86 (feature sse+) + HasFloat16 = SSELevel >= SSE2; pengfei wrote: > rjmccall wrote: > > Out of curiosity, why SSE2? SSE2 adds double-precision, but we

[clang] 4a9523c - PR52537: When performing a no-op TreeTransform of a rewritten binary

Author: Richard Smith Date: 2021-11-17T18:19:46-08:00 New Revision: 4a9523c55fa11d85a4edbf24abc2c17bb3849fbc URL: https://github.com/llvm/llvm-project/commit/4a9523c55fa11d85a4edbf24abc2c17bb3849fbc DIFF: https://github.com/llvm/llvm-project/commit/4a9523c55fa11d85a4edbf24abc2c17bb3849fbc.diff

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

This revision was automatically updated to reflect the committed changes. Closed by commit rG062ef8f6b472: [Driver][Android] Remove unneeded isNoExecStackDefault (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113840/new/

[clang] 062ef8f - [Driver][Android] Remove unneeded isNoExecStackDefault

Author: Fangrui Song Date: 2021-11-17T18:15:24-08:00 New Revision: 062ef8f6b472a71685941391ab93bfd68ce93d71 URL: https://github.com/llvm/llvm-project/commit/062ef8f6b472a71685941391ab93bfd68ce93d71 DIFF: https://github.com/llvm/llvm-project/commit/062ef8f6b472a71685941391ab93bfd68ce93d71.diff

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:371 } + // Turn on _float16 for x86 (feature sse+) + HasFloat16 = SSELevel >= SSE2; sse2? Comment at: clang/lib/Basic/Targets/X86.cpp:372 + // Turn on _float16

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for -co_await(auto i : arr) {} +co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}}

[PATCH] D113977: [Coroutine] Warn deprecated 'std::experimental::coro' uses

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9f3c6d86b4: [Coroutine] Warn deprecated std::experimental::coro

[clang] af9f3c6 - [Coroutine] Warn deprecated 'std::experimental::coro' uses

Author: Chuanqi Xu Date: 2021-11-18T09:41:01+08:00 New Revision: af9f3c6d86b4afc93fb0a29ee430fc42f593800f URL: https://github.com/llvm/llvm-project/commit/af9f3c6d86b4afc93fb0a29ee430fc42f593800f DIFF: https://github.com/llvm/llvm-project/commit/af9f3c6d86b4afc93fb0a29ee430fc42f593800f.diff

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

modimo created this revision. Herald added subscribers: jeroen.dobbelaere, hoy, wenlei, lxfind, dang. modimo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114130 Files:

[PATCH] D113107: Support of expression granularity for _Float16.

scanon added a comment. In D113107#3138671 , @rjmccall wrote: >> Basically agree with everything John said, with a note that #3 is not quite >> FP_CONTRACT, which allows evaluating an expression as if intermediate steps >> were infinitely-precise, but

[PATCH] D114059: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb9dc0c78f97: [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114059/new/

[clang] eb9dc0c - [X86] add 3 missing intrinsics: _mm_(mask/maskz)_cvtpbh_ps

Author: Freddy Ye Date: 2021-11-18T08:48:19+08:00 New Revision: eb9dc0c78f97984ed1ef08feb33422e2c7463cac URL: https://github.com/llvm/llvm-project/commit/eb9dc0c78f97984ed1ef08feb33422e2c7463cac DIFF: https://github.com/llvm/llvm-project/commit/eb9dc0c78f97984ed1ef08feb33422e2c7463cac.diff

[PATCH] D114093: [clang][lex] Refactor check for the first file include

vsapsai added a comment. Have just a few little tweaks, otherwise looks good. And we've discussed that it's possible we don't really need the first time lexing check anymore. But that's a separate issue and I support your decision to preserve the existing behavior and not to increase the scope

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

rjmccall added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:242 HasAVX512FP16 = true; - HasFloat16 = true; } else if (Feature == "+avx512pf") { We should probably be setting `HasLegalHalfType` here. Comment at:

[clang] 5a6dac6 - LiteralSupport: Don't assert() on invalid input

Author: Daan De Meyer Date: 2021-11-17T23:51:30Z New Revision: 5a6dac66db67225e2443f4e61dfe9d2f96780611 URL: https://github.com/llvm/llvm-project/commit/5a6dac66db67225e2443f4e61dfe9d2f96780611 DIFF: https://github.com/llvm/llvm-project/commit/5a6dac66db67225e2443f4e61dfe9d2f96780611.diff

[PATCH] D114124: [clang][ARM] only check -mtp=cp15 for non-asm sources

nickdesaulniers created this revision. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diagnostic is really to highlight lack of support for hard thread pointers in post-RA

[PATCH] D114036: Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa340a491b255: Add Android test case for -Wpartial-availability. Also update Android… (authored by jamesfarrell). Repository: rG LLVM Github

[clang] a340a49 - Add Android test case for -Wpartial-availability. Also update Android availability tests to match on the whole string, so we can distinguish between "Android 16" and "Android 16.0.0"

Author: James Farrell Date: 2021-11-17T22:45:23Z New Revision: a340a491b2550b24539adced79ffefd3ec2e13bf URL: https://github.com/llvm/llvm-project/commit/a340a491b2550b24539adced79ffefd3ec2e13bf DIFF: https://github.com/llvm/llvm-project/commit/a340a491b2550b24539adced79ffefd3ec2e13bf.diff

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1409 return BindableMatcher( - makeAllOfComposite(InnerMatchers).template dynCastTo()); + makeAllOfComposite(InnerMatchers).template dynCastTo(), +

[PATCH] D113943: Add `withTag` matcher.

jcking1034 updated this revision to Diff 388045. jcking1034 added a comment. Change `getMatcherName` to `getName` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113943/new/ https://reviews.llvm.org/D113943 Files:

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 updated this revision to Diff 388041. jcking1034 added a comment. Add tests, rename `getMatcherName` to `getName`, update `makeAllOfComposite` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113917/new/ https://reviews.llvm.org/D113917

[PATCH] D113505: [NFC][clang] Inclusive language: replace masterPort with mainPort

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113505/new/ https://reviews.llvm.org/D113505

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. This contained a bug in that I didn't change CompilerInvocation::GenerateCodeGenArgs() to serialize the new flag correctly, so in build configs that do roundtripping the test failed. I fixed the marshalling in

[clang] 7a8c794 - [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

Author: Nathan Ridge Date: 2021-11-17T16:56:46-05:00 New Revision: 7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411 URL: https://github.com/llvm/llvm-project/commit/7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411 DIFF: https://github.com/llvm/llvm-project/commit/7a8c7946fc3aa75beac6fb5e7cd7b15f1a69d411.diff

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a8c7946fc3a: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing (authored by nridge). Repository: rG LLVM Github

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

dexonsmith added a comment. SGTM; I'll let @jansvoboda11 confirm though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114120/new/ https://reviews.llvm.org/D114120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114073: [clang-format][NFC] Add a default value to parseBlock()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe852cc0d5a8f: [clang-format][NFC] Add a default value to parseBlock() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. > Basically agree with everything John said, with a note that #3 is not quite > FP_CONTRACT, which allows evaluating an expression as if intermediate steps > were infinitely-precise, but rather FLT_EVAL_METHOD == 32 as defined in > ISO/IEC TS 18661-3: "evaluate

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

thakis created this revision. thakis added reviewers: dexonsmith, jansvoboda11. Herald added a subscriber: mgorny. thakis requested review of this revision. This removes the ability to disable roundtripping in assert builds. (Roundtripping happens by default in assert builds both before and after

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:109 + // Generic processor model is for testing only. + return A >= CudaArch::GFX600 && A <= CudaArch::GFX1035; } can we use A < CudaArch::Generic instead? to avoid updating this line

[clang] ccd729f - [NFC] Update comments to refer to unique_ptr instead of raw pointers.

Author: Yitzhak Mandelbaum Date: 2021-11-17T21:08:09Z New Revision: ccd729faa5d46a2656fa2b889f4339d399fca070 URL: https://github.com/llvm/llvm-project/commit/ccd729faa5d46a2656fa2b889f4339d399fca070 DIFF: https://github.com/llvm/llvm-project/commit/ccd729faa5d46a2656fa2b889f4339d399fca070.diff

[clang] 3623163 - [clang] Fix typo in 36873fb768dbe

Author: Nico Weber Date: 2021-11-17T16:06:27-05:00 New Revision: 3623163ae83799933bbeabe2cb3060537250c4b3 URL: https://github.com/llvm/llvm-project/commit/3623163ae83799933bbeabe2cb3060537250c4b3 DIFF: https://github.com/llvm/llvm-project/commit/3623163ae83799933bbeabe2cb3060537250c4b3.diff

[PATCH] D112915: [clang][modules] Track number of includes per submodule

dexonsmith added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:399 + /// include information. + llvm::StringMap> SubmoduleIncludedFiles; + jansvoboda11 wrote: > dexonsmith wrote: > > Each StringMapEntry is going to have a pretty

[clang] 36873fb - [clang] Try to fix test more after ae98182cf7341181e

Author: Nico Weber Date: 2021-11-17T15:59:23-05:00 New Revision: 36873fb768dbedeb3e9167117d3bb63b3720d214 URL: https://github.com/llvm/llvm-project/commit/36873fb768dbedeb3e9167117d3bb63b3720d214 DIFF: https://github.com/llvm/llvm-project/commit/36873fb768dbedeb3e9167117d3bb63b3720d214.diff

[PATCH] D114092: [clang][lex] NFC: Remove unused HeaderFileInfo member

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114092/new/ https://reviews.llvm.org/D114092 ___ cfe-commits mailing list

[PATCH] D114096: [clang][lex][modules] Stop tracking number of includes

dexonsmith added a comment. I have a couple of nits inline, but otherwise LGTM if you squash with https://reviews.llvm.org/D114095. Comment at: clang/include/clang/Lex/Preprocessor.h:1230-1232 /// Increment the count for the number of times the specified FileEntry has

[PATCH] D114095: [clang][lex][modules] Move number of includes from HeaderFileInfo to Preprocessor

dexonsmith added a comment. I'm not sure this commit stands on its own, since it introduces a (temporary) regression in `.pcm` size; I suggest squashing with the follow-up, https://reviews.llvm.org/D114096. Comment at: clang/include/clang/Lex/HeaderSearch.h:55 + // TODO:

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Fine by me if this is the default for LLD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113840/new/ https://reviews.llvm.org/D113840

[PATCH] D114093: [clang][lex] Refactor check for the first file include

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM with one nit inline. Comment at: clang/include/clang/Lex/Lexer.h:140-141 + /// True if this is the first time we're lexing the input file. + bool

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3138415 , @rjmccall wrote: > In D113107#3137921 , @zahiraam > wrote: > >> In D113107#3136464 , @rjmccall >> wrote: >> >>> Does GCC

[PATCH] D113107: Support of expression granularity for _Float16.

scanon added a comment. In D113107#3138415 , @rjmccall wrote: > I think we keep dancing around this in this review, so let me go back and > start from the basics. There are four approaches I know of for evaluating a > homogeneous `_Float16` expression

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 marked 4 inline comments as done. jansvoboda11 added a comment. In D112915#3136492 , @vsapsai wrote: > Didn't go in-depth for serialization/deserialization. When we add tracking > `isImport` on per-submodule basis, do you think AST

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. In D112915#3122340 , @dexonsmith wrote: > Implementation looks a lot cleaner! > > I'd still like to drop NumIncludes first if possible because I think it'll be > easier to

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Isolated example: template struct span {}; auto make_span() { using T = int; return span(); } void WontCompile() { span s1 = make_span(); } https://godbolt.org/z/rjd6Y6f9d testcc:9:13: error: no viable conversion from 'span' to 'span'

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3137375 , @hans wrote: >> I am not sure how to reproduce this. > > Attaching preprocessed source. With Clang built at > 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: > > $ clang++ -c

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3137921 , @zahiraam wrote: > In D113107#3136464 , @rjmccall > wrote: > >> Does GCC actually change the formal types of expressions to `float`, or is >> it doing this "no

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for ARMv6 non-thumb cases

nickdesaulniers created this revision. nickdesaulniers added reviewers: ardb, peter.smith, ostannard, DavidSpickett. Herald added a subscriber: kristof.beyls. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass the --compress-debug-sections=zlib argument to the linker when the use of

[clang] a11d27f - [clang] Try to fix test after ae98182cf7341181e

Author: Nico Weber Date: 2021-11-17T14:30:08-05:00 New Revision: a11d27f4ff3bd4e3d2d987cd2bb0dcd7d7c230e3 URL: https://github.com/llvm/llvm-project/commit/a11d27f4ff3bd4e3d2d987cd2bb0dcd7d7c230e3 DIFF: https://github.com/llvm/llvm-project/commit/a11d27f4ff3bd4e3d2d987cd2bb0dcd7d7c230e3.diff

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

NeHuang added a comment. - Comment at: clang/lib/Headers/altivec.h:19050 +} + +static __inline__ long __bcdcmpeq(vector unsigned char __a, Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not used. Comment at:

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. @steakhal Please, read the discussion started from here D104285#2943449 . It's directly relates to this patch and what we've been arguing about. I'm still hesitating about this patch. On one hand we have the fact that

[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

mtrofin added inline comments. Herald added subscribers: ormris, jdoerfert. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:856 + // Add use-sample-profile value. + if (!CGM.getCodeGenOpts().SampleProfileFile.empty()) MaskRay wrote: > The code self

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. https://reviews.llvm.org/rGb1ad813b474a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 ___ cfe-commits mailing list

[clang] b1ad813 - [clang] Address review comments on https://reviews.llvm.org/D113707

Author: Nico Weber Date: 2021-11-17T14:04:16-05:00 New Revision: b1ad813b474ab7935b2c40d84c99c2b59cd67f79 URL: https://github.com/llvm/llvm-project/commit/b1ad813b474ab7935b2c40d84c99c2b59cd67f79 DIFF: https://github.com/llvm/llvm-project/commit/b1ad813b474ab7935b2c40d84c99c2b59cd67f79.diff

[PATCH] D114102: [OpenMP] Add version macro support for 5.1 and 5.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG69f35f896912: [OpenMP] Add version macro support for 5.1 and 5.2 (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 69f35f8 - [OpenMP] Add version macro support for 5.1 and 5.2

Author: Mike Rice Date: 2021-11-17T10:51:08-08:00 New Revision: 69f35f89691255eeed0dac26b2b642fea5c7db93 URL: https://github.com/llvm/llvm-project/commit/69f35f89691255eeed0dac26b2b642fea5c7db93 DIFF: https://github.com/llvm/llvm-project/commit/69f35f89691255eeed0dac26b2b642fea5c7db93.diff

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis marked 3 inline comments as done. thakis added a comment. Derp, I landed this without replying to the comments. I'll do a follow-up commit for them right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

michaelrj added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:39 +// intercepted. +static const char *FUNCTIONS_TO_IGNORE_NAMESPACE[] = { +"__errno_location", "malloc", "calloc", "realloc", "free"}; sivachandra

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

alexfh added a comment. In D113148#3127646 , @ymandel wrote: > This looks really good. An impressive effort! Just a few changes. Also, > please ping Alex to get his opinion on the high level issue. Since this check focuses really well on the issue of

[clang] ae98182 - [clang] Make -masm=intel affect inline asm style

Author: Nico Weber Date: 2021-11-17T13:41:59-05:00 New Revision: ae98182cf7341181e4aa815c372a072dec82779f URL: https://github.com/llvm/llvm-project/commit/ae98182cf7341181e4aa815c372a072dec82779f DIFF: https://github.com/llvm/llvm-project/commit/ae98182cf7341181e4aa815c372a072dec82779f.diff

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae98182cf734: [clang] Make -masm=intel affect inline asm style (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp updated this revision to Diff 387990. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Reverting change to `Protocol.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114100/new/

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:141 /// the server can send `null` to indicate that the version is known and the - /// content on disk is the master (as speced with document content

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info-block-helper.m

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch replaces master with controller in `debug-info-block-helper.m`.

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. I'll separate them later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://reviews.llvm.org/D102449 ___ cfe-commits mailing list

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

ABataev added a comment. In D102449#3137713 , @carlo.bertolli wrote: > This is already a lot of code with parse+sema. I wonder if we should split > the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ? > It should simplify maintenance of the

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/no-ret-in-x87-reg.ll:147-150 +; NOX87-NEXT:fldt {{[0-9]+}}(%esp) +; NOX87-NEXT:fldt {{[0-9]+}}(%esp) +; NOX87-NEXT:faddp %st, %st(1) +; NOX87-NEXT:

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:141 /// the server can send `null` to indicate that the version is known and the - /// content on disk is the master (as speced with document content ownership). + /// content on disk is the

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, alexfh, hokein, JonasToth, courbet, ymandel. Herald added subscribers: carlosgalvezp, martong, rnkovacs, kbarton, kristof.beyls, xazax.hun, nemanjai. steakhal requested review of this revision. Herald added a

[PATCH] D113390: [clangd] Dont include file version in task name

This revision was automatically updated to reflect the committed changes. Closed by commit rGe76e5729896c: [clangd] Dont include file version in task name (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113390/new/

[clang-tools-extra] e76e572 - [clangd] Dont include file version in task name

Author: Kadir Cetinkaya Date: 2021-11-17T19:10:09+01:00 New Revision: e76e5729896c4a62f1f5ccbf784a59de96f74cbd URL: https://github.com/llvm/llvm-project/commit/e76e5729896c4a62f1f5ccbf784a59de96f74cbd DIFF:

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the feature. I'd still prefer to see `SimpleMFlag` used, but it's not a big deal to me. Comment at: clang/include/clang/Driver/Options.td:3193

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:504 bool TraverseDecl(Decl *X) { -if (X && isa(X)) +if (isa_and_nonnull(X)) return

[PATCH] D113642: [PowerPC] Provide XL-compatible vec_round implementation

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113642/new/ https://reviews.llvm.org/D113642

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114088/new/ https://reviews.llvm.org/D114088

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3136464 , @rjmccall wrote: > Does GCC actually change the formal types of expressions to `float`, or is it > doing this "no intermediate casts thing" as some sort of fp_contract-style > custom emission of trees of

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. quinnp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch

  1   2   >