[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf0da91ba5e1: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length… (authored by bsmith). Repository: rG LLVM Github

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

paulwalker-arm accepted this revision. paulwalker-arm added a comment. Mainly focused on the SVE side of things, which looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM, if no one else has comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith updated this revision to Diff 330951. bsmith added a comment. - Remove `SDTFPRoundEvenOp` as it's not a correct mirror of `SDTFPRoundOp` since that is not for `ISD::FROUND`. - Fix comments in `include/llvm/Target/TargetSelectionDAG.td` for `SDTFPRoundOp` and `SDTFPExtendOp`.

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added inline comments. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> bsmith wrote: >

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added inline comments. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> dmgreen wrote: >

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added a comment. Thanks. This looks sensible, from what I can tell. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>,

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith updated this revision to Diff 330629. bsmith added a comment. Herald added a subscriber: dexonsmith. - Add AutoUpgrade code to convert aarch64.neon.frintn to roundeven - Add test for above AutoUpgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:476 - // intrinsic. - def int_aarch64_neon_frintn : AdvSIMD_1FloatArg_Intrinsic; - If you are removing the old intrinsic (which is great), then it will need some AutoUpgrade

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

paulwalker-arm added a comment. In D98487#2625673 , @bsmith wrote: >> Why is this patch only changing int_aarch64_neon_frintn and not >> int_aarch64_sve_frintn? >> Is there a particular reason to do so? > > Things are done slightly differently for SVE in

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added a comment. > Why is this patch only changing int_aarch64_neon_frintn and not > int_aarch64_sve_frintn? > Is there a particular reason to do so? Things are done slightly differently for SVE in this regard, in principal yes, we could emit roundeven instead of frintn from the ACLE

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

CarolineConcatto added a comment. Hi @ bsmith, Thank you for adding me as a reviewer, although I don't think I am the more qualified to approve or not this patch. But I have a question: Why is this patch only changing int_aarch64_neon_frintn and not int_aarch64_sve_frintn? Is there a

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, joechrisellis, CarolineConcatto, dmgreen. Herald added subscribers: hiraditya, kristof.beyls, tschuett. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: