Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-05-02 Thread Alexander Zvegintsev
On Wed, 1 May 2024 22:44:41 GMT, Sergey Bylokhov wrote: >> Do we really need an additional click on the title in this case? >> Just `toFront` should be enough on all platforms. > > `toFront()` is known to be broken on some versions of metacity/gnome, not > sure it was fixed or not, that was a

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-05-01 Thread Sergey Bylokhov
On Tue, 30 Apr 2024 16:49:49 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/Focus/6981400/Test1.java line 186: >> >>> 184: Util.clickOnComp(compToClick, robot); >>> 185: >>> 186: if (Platform.isOnWayland()) { >> >> If the goal is just to move the window to the front

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-30 Thread Harshitha Onkar
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-30 Thread Alexander Zvegintsev
On Tue, 30 Apr 2024 05:47:05 GMT, Sergey Bylokhov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/Focus/6981400/Test1.java line 186: > >> 184:

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Sergey Bylokhov
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
On Tue, 30 Apr 2024 02:02:30 GMT, Alexander Zvegintsev wrote: >> Some tests try to get the focus of a window by clicking on its title bar. >> >> On XWayland, however, emulating mouse clicks with XTEST currently only >> affects the XWayland server, not the window decorations, so trying to

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
On Mon, 29 Apr 2024 21:08:28 GMT, Harshitha Onkar wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/regtesthelpers/Util.java line 674: > >> 672: return

Re: RFR: 8280988: [XWayland] Click on title to request focus test failures [v2]

2024-04-29 Thread Alexander Zvegintsev
> Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click > on the window title will have no effect. > > So the solution is