On Thu, 2 May 2024 07:02:01 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Nimbus property name update
>
> Marked as reviewed by psadhukhan (Reviewer).
> @prsadhuk Updated the test
On Fri, 3 May 2024 05:10:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Sat, 13 Apr 2024 18:22:07 GMT, Phil Race wrote:
> Where are we with this ? Is there a consensus yet ?
I guess I have added my explanations in the PR as to why the test should be
removed...You can take a call and provide your decision.
We have several unresolved bugs in JDK and most, if not
On Thu, 4 Apr 2024 05:34:18 GMT, Prasanta Sadhukhan
wrote:
> Test issue shows the End and Start buttons are not placed as per instructions
> due to ComponentOrientation RTL was not honoured, as with `getContentPane()`
> being removed from `add` call of JFrame, it was also additionally removed
On Fri, 3 May 2024 04:38:07 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unselected tab background property added
>
> test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56:
>
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the
On Fri, 3 May 2024 03:31:22 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the
On Thu, 2 May 2024 15:07:30 GMT, Tejesh R wrote:
>> `unselectedBackground` color is used to render the unselected tabs. What
>> else you want me to check?
>
> I don't see the rendering code in `installDefaults()`, can you recheck that.
`unselectedBackground` was not defined in GTKLookAndFeel
On Thu, 2 May 2024 21:53:34 GMT, Andy Goryachev wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8331591
>
> src/java.desktop/share/classes/sun/font/CodePointIterator.java line 65:
>
>> 63: }
>> 64:
>> 65:
>
>
On Thu, 2 May 2024 22:01:03 GMT, Phil Race wrote:
>> Delete an internal class that has been around for 20 years but never been
>> used.
>> Verified that is true at least as far back as JDK7
>> All platforms build. Tests pass.
>
> Phil Race has updated the pull request incrementally with one
On Thu, 2 May 2024 21:58:21 GMT, Phil Race wrote:
>> Delete an internal class that has been around for 20 years but never been
>> used.
>> Verified that is true at least as far back as JDK7
>> All platforms build. Tests pass.
>
> Phil Race has updated the pull request incrementally with one
> Delete an internal class that has been around for 20 years but never been
> used.
> Verified that is true at least as far back as JDK7
> All platforms build. Tests pass.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8331591
Delete an internal class that has been around for 20 years but never been used.
Verified that is true at least as far back as JDK7
All platforms build. Tests pass.
-
Commit messages:
- 8331591
Changes: https://git.openjdk.org/jdk/pull/19072/files
Webrev:
On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev
wrote:
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so trying to click
>
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote:
> Change GPL+CP -> GPL as required for all tests.
This pull request has now been integrated.
Changeset: 99654ec3
Author:Phil Race
URL:
https://git.openjdk.org/jdk/commit/99654ec3fb2c2e7c8d5bf5965aaf45aeb4b88c61
Stats: 4 lines in
On Thu, 2 May 2024 13:01:12 GMT, Alexander Zvegintsev
wrote:
>> Some tests try to get the focus of a window by clicking on its title bar.
>>
>> On XWayland, however, emulating mouse clicks with XTEST currently only
>> affects the XWayland server, not the window decorations, so trying to click
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote:
> Change GPL+CP -> GPL as required for all tests.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19068#pullrequestreview-2036784210
On Thu, 2 May 2024 18:45:54 GMT, Phil Race wrote:
> Change GPL+CP -> GPL as required for all tests.
Confirmed updated license matches the GPL template:
https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header
-
Marked as reviewed by iris (Reviewer).
PR
On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Thu, 2 May 2024 18:30:23 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
Change GPL+CP -> GPL as required for all tests.
-
Commit messages:
- 8331516
Changes: https://git.openjdk.org/jdk/pull/19068/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19068=00
Issue: https://bugs.openjdk.org/browse/JDK-8331516
Stats: 4 lines in 1 file changed: 0
> The fix adds new public `OutputBin` print attribute class which allow to set
> a printer output bin in a `PrinterJob` class. The corresponding internal
> `CustomOutputBin` class is added as well.
>
> - Constants used in `OutputBin` class are based on [Internet Printing
> Protocol (IPP):
On Mon, 29 Apr 2024 23:24:19 GMT, Harshitha Onkar wrote:
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
This pull request has now been integrated.
Changeset: 6f98d8f5
Author:
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
This pull request has now been integrated.
Changeset: 6969a9e0
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/6969a9e0b2143eee5a7cfa02460a8ab6dfa08cda
> For the following manual test, more instructions are added as to what to
> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
> clarity.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
row count change
On Thu, 2 May 2024 14:46:24 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
>> line 128:
>>
>>> 126: private Color selectColor;
>>> 127: // Background color for unselected tabs
>>> 128: private Color unselectedBackground;
On Thu, 2 May 2024 09:39:26 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Nimbus property name update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
> line 128:
On Tue, 30 Apr 2024 20:38:06 GMT, Harshitha Onkar wrote:
>> For the following manual test, more instructions are added as to what to
>> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for
>> clarity.
>
> Harshitha Onkar has updated the pull request incrementally with one
> Some tests try to get the focus of a window by clicking on its title bar.
>
> On XWayland, however, emulating mouse clicks with XTEST currently only
> affects the XWayland server, not the window decorations, so trying to click
> on the window title will have no effect.
>
> So the solution is
On Wed, 1 May 2024 22:44:41 GMT, Sergey Bylokhov wrote:
>> Do we really need an additional click on the title in this case?
>> Just `toFront` should be enough on all platforms.
>
> `toFront()` is known to be broken on some versions of metacity/gnome, not
> sure it was fixed or not, that was a
On Thu, 25 Apr 2024 11:52:35 GMT, Alexander Zvegintsev
wrote:
> This fix adds missing doPrivileged calls in TokenStorage, which is used to
> help take screenshots in Wayland.
This pull request has now been integrated.
Changeset: 9912abf5
Author:Alexander Zvegintsev
URL:
On Wed, 3 Apr 2024 02:38:21 GMT, Julian Waters wrote:
>> Bumping
>
>> @TheShermanTanker I tried to help you get this done. I added fixes to a copy
>> of your branch on my personal fork, but then it turned out I could not push
>> them to your branch. :-(
>>
>> It ended up with me creating a
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejesh R has updated the
On Tue, 23 Apr 2024 07:51:59 GMT, Tejesh R wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>>
On Thu, 25 Apr 2024 10:21:57 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> Default time out may not be sufficient to test, can be increased.
@kumarabhi006 I've updated the
On Thu, 2 May 2024 07:01:34 GMT, Prasanta Sadhukhan
wrote:
>> There are properties without nimbus prepended as well... e.g.
>> textInactiveText, activeCaption etc.
>> Anyways Updated with the suggested name.
>
> ok..In that case, this property should have been put after those and not in
>
On Thu, 2 May 2024 06:34:52 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86:
>>
>>> 84: >> hueOffset="0.0" saturationOffset="0.0" brightnessOffset="0.0"
>>> alphaOffset="0"/>
>>> 85:
>>> 86:
>>
>> One more thing
>>
On Thu, 2 May 2024 06:40:20 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 2 May 2024 06:20:28 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Instruction and jtreg tag update
>
> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 86:
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 2 May 2024 06:05:08 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the
46 matches
Mail list logo
