lukasz-antoniak commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2135352720
Good work @ajweave, sorry to keep you waiting. Two things to consider from
my end. Feel free to disagree since both are more of coding style category.
In
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596024998
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596015592
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
* @param
adutra commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1595217254
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param
ajweave commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101654238
Sorry for the delay. I will get this done tomorrow. I appreciate the
attention here.
--
This is an automated message from the Apache Git Service.
To respond to the
SiyaoIsHiding commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101624573
May you please merge apache/4.x to your branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1594781483
##
core/src/main/java/com/datastax/dse/driver/internal/core/cql/continuous/ContinuousRequestHandlerBase.java:
##
@@ -1590,18 +1597,20 @@ private
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1587797662
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
*
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1586980425
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
*
absurdfarce commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2087323844
Ping @SiyaoIsHiding for (hopefully) another review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vanditsramblings commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1995012337
+1 , this would be a great addition , allowing more granular access to
execution metrics.
--
This is an automated message from the Apache Git Service.
To
ajweave commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1838710385
@hhughes , @absurdfarce , gentle reminder to review these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ajweave commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1802288303
Now that the donation to Apache is complete, I'd like to move forward with
this change. @hhughes , @absurdfarce , please take a look.
--
This is an automated message
13 matches
Mail list logo
