[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-09-10 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193628#comment-17193628 ] Marcus Eriksson commented on CASSANDRA-15393: - +1 assuming clean test run and Calebs

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-09-09 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193067#comment-17193067 ] Caleb Rackliffe commented on CASSANDRA-15393: - Read through the last raft of commits,

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-09-08 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192414#comment-17192414 ] Blake Eggleston commented on CASSANDRA-15393: - Pushed up a new branch

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-09-02 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189237#comment-17189237 ] Marcus Eriksson commented on CASSANDRA-15393: - First pass done, LGTM in general, I'll

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-28 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186875#comment-17186875 ] Caleb Rackliffe commented on CASSANDRA-15393: - [~bdeggleston] There are the [items

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Josh McKenzie (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186177#comment-17186177 ] Josh McKenzie commented on CASSANDRA-15393: --- I think it was the "perf improvements are

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186021#comment-17186021 ] Blake Eggleston commented on CASSANDRA-15393: - That's reasonable, I'll ping the dev

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186017#comment-17186017 ] Michael Semb Wever commented on CASSANDRA-15393: [~bdeggleston], a patch with 208

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186013#comment-17186013 ] Blake Eggleston commented on CASSANDRA-15393: - [~mck], this ticket was been triaged to

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185997#comment-17185997 ] Michael Semb Wever commented on CASSANDRA-15393: {quote}Is there's a big difference

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185886#comment-17185886 ] Caleb Rackliffe commented on CASSANDRA-15393: - {quote}The 4.0.x line is going to be

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-27 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185732#comment-17185732 ] Michael Semb Wever commented on CASSANDRA-15393: We have been strict on the 4.0

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-26 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185510#comment-17185510 ] Caleb Rackliffe commented on CASSANDRA-15393: - bq. The idea of combining the byte array

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-26 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185506#comment-17185506 ] Caleb Rackliffe commented on CASSANDRA-15393: - bq. I'd done something sort of along

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-26 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185499#comment-17185499 ] Caleb Rackliffe commented on CASSANDRA-15393: - bq. I'm inclined to go the other way, and

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-26 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185489#comment-17185489 ] Caleb Rackliffe commented on CASSANDRA-15393: - bq. I'd prefer that we keep the

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-24 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183659#comment-17183659 ] David Capwell commented on CASSANDRA-15393: --- bq. It might have been less of an issue, if

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-24 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183621#comment-17183621 ] Blake Eggleston commented on CASSANDRA-15393: - Thanks for the excellent review

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-12 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176410#comment-17176410 ] Caleb Rackliffe commented on CASSANDRA-15393: - bq. I disagree with the idea that we

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-11 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175656#comment-17175656 ] Blake Eggleston commented on CASSANDRA-15393: - bq. I'm sorry, if my objections sound

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-11 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175390#comment-17175390 ] Benedict Elliott Smith commented on CASSANDRA-15393: {quote}This one compiles

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-11 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175291#comment-17175291 ] Robert Stupp commented on CASSANDRA-15393: -- This one compiles without errors just by

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-10 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175221#comment-17175221 ] Caleb Rackliffe commented on CASSANDRA-15393: - In terms of the higher level question of

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-10 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175217#comment-17175217 ] Caleb Rackliffe commented on CASSANDRA-15393: - While we continue to hash out the more

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-10 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175119#comment-17175119 ] Blake Eggleston commented on CASSANDRA-15393: - bq. The split of ByteBuffer into a pair

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-07 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173037#comment-17173037 ] Benedict Elliott Smith commented on CASSANDRA-15393: {quote}But introducing an

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-07 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173009#comment-17173009 ] Robert Stupp commented on CASSANDRA-15393: -- Thanks for tackling this! Heap pressure induced

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-06 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172676#comment-17172676 ] Caleb Rackliffe commented on CASSANDRA-15393: - There is a fair number of unit test

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-06 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172612#comment-17172612 ] Caleb Rackliffe commented on CASSANDRA-15393: - [~bdeggleston] I made a pass at a rebase,

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2020-08-05 Thread Caleb Rackliffe (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171803#comment-17171803 ] Caleb Rackliffe commented on CASSANDRA-15393: - [~marcuse] [~samt] I'm going to make a

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-12-02 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986441#comment-16986441 ] Blake Eggleston commented on CASSANDRA-15393: - [~benedict], I’d like your opinion on

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-11-04 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967116#comment-16967116 ] Blake Eggleston commented on CASSANDRA-15393: - Here's a rough initial pass at converting

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964309#comment-16964309 ] Blake Eggleston commented on CASSANDRA-15393: - {quote}Yes, remove it entirely from the

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964284#comment-16964284 ] Benedict Elliott Smith commented on CASSANDRA-15393: Thanks - I now see that

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964279#comment-16964279 ] Blake Eggleston commented on CASSANDRA-15393: - The row for this patch measures the delta

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964278#comment-16964278 ] Benedict Elliott Smith commented on CASSANDRA-15393: Yes, remove it entirely

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964267#comment-16964267 ] Blake Eggleston commented on CASSANDRA-15393: - > Would the local-read benefits be better

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964251#comment-16964251 ] Benedict Elliott Smith commented on CASSANDRA-15393: Would the local-read

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964231#comment-16964231 ] Blake Eggleston commented on CASSANDRA-15393: - No, but the local read path also benefits

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964228#comment-16964228 ] Benedict Elliott Smith commented on CASSANDRA-15393: This shouldn't ever be used

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964227#comment-16964227 ] Blake Eggleston commented on CASSANDRA-15393: - The only exception I'm aware of is the

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964215#comment-16964215 ] Benedict Elliott Smith commented on CASSANDRA-15393: So first we would have to

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964202#comment-16964202 ] Blake Eggleston commented on CASSANDRA-15393: - I had not, this group of changes was

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963950#comment-16963950 ] Benedict Elliott Smith commented on CASSANDRA-15393: Have we considered, for

[jira] [Commented] (CASSANDRA-15393) Add byte array backed cells

2019-10-31 Thread Benedict Elliott Smith (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963872#comment-16963872 ] Benedict Elliott Smith commented on CASSANDRA-15393: We have to be careful here,