[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193628#comment-17193628
]
Marcus Eriksson commented on CASSANDRA-15393:
-
+1 assuming clean test run and Calebs
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193067#comment-17193067
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
Read through the last raft of commits,
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192414#comment-17192414
]
Blake Eggleston commented on CASSANDRA-15393:
-
Pushed up a new branch
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189237#comment-17189237
]
Marcus Eriksson commented on CASSANDRA-15393:
-
First pass done, LGTM in general, I'll
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186875#comment-17186875
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
[~bdeggleston] There are the [items
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186177#comment-17186177
]
Josh McKenzie commented on CASSANDRA-15393:
---
I think it was the "perf improvements are
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186021#comment-17186021
]
Blake Eggleston commented on CASSANDRA-15393:
-
That's reasonable, I'll ping the dev
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186017#comment-17186017
]
Michael Semb Wever commented on CASSANDRA-15393:
[~bdeggleston], a patch with 208
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186013#comment-17186013
]
Blake Eggleston commented on CASSANDRA-15393:
-
[~mck], this ticket was been triaged to
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185997#comment-17185997
]
Michael Semb Wever commented on CASSANDRA-15393:
{quote}Is there's a big difference
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185886#comment-17185886
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
{quote}The 4.0.x line is going to be
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185732#comment-17185732
]
Michael Semb Wever commented on CASSANDRA-15393:
We have been strict on the 4.0
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185510#comment-17185510
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
bq. The idea of combining the byte array
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185506#comment-17185506
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
bq. I'd done something sort of along
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185499#comment-17185499
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
bq. I'm inclined to go the other way, and
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185489#comment-17185489
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
bq. I'd prefer that we keep the
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183659#comment-17183659
]
David Capwell commented on CASSANDRA-15393:
---
bq. It might have been less of an issue, if
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183621#comment-17183621
]
Blake Eggleston commented on CASSANDRA-15393:
-
Thanks for the excellent review
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176410#comment-17176410
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
bq. I disagree with the idea that we
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175656#comment-17175656
]
Blake Eggleston commented on CASSANDRA-15393:
-
bq. I'm sorry, if my objections sound
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175390#comment-17175390
]
Benedict Elliott Smith commented on CASSANDRA-15393:
{quote}This one compiles
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175291#comment-17175291
]
Robert Stupp commented on CASSANDRA-15393:
--
This one compiles without errors just by
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175221#comment-17175221
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
In terms of the higher level question of
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175217#comment-17175217
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
While we continue to hash out the more
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175119#comment-17175119
]
Blake Eggleston commented on CASSANDRA-15393:
-
bq. The split of ByteBuffer into a pair
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173037#comment-17173037
]
Benedict Elliott Smith commented on CASSANDRA-15393:
{quote}But introducing an
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173009#comment-17173009
]
Robert Stupp commented on CASSANDRA-15393:
--
Thanks for tackling this! Heap pressure induced
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172676#comment-17172676
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
There is a fair number of unit test
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172612#comment-17172612
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
[~bdeggleston] I made a pass at a rebase,
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171803#comment-17171803
]
Caleb Rackliffe commented on CASSANDRA-15393:
-
[~marcuse] [~samt] I'm going to make a
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986441#comment-16986441
]
Blake Eggleston commented on CASSANDRA-15393:
-
[~benedict], I’d like your opinion on
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967116#comment-16967116
]
Blake Eggleston commented on CASSANDRA-15393:
-
Here's a rough initial pass at converting
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964309#comment-16964309
]
Blake Eggleston commented on CASSANDRA-15393:
-
{quote}Yes, remove it entirely from the
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964284#comment-16964284
]
Benedict Elliott Smith commented on CASSANDRA-15393:
Thanks - I now see that
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964279#comment-16964279
]
Blake Eggleston commented on CASSANDRA-15393:
-
The row for this patch measures the delta
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964278#comment-16964278
]
Benedict Elliott Smith commented on CASSANDRA-15393:
Yes, remove it entirely
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964267#comment-16964267
]
Blake Eggleston commented on CASSANDRA-15393:
-
> Would the local-read benefits be better
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964251#comment-16964251
]
Benedict Elliott Smith commented on CASSANDRA-15393:
Would the local-read
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964231#comment-16964231
]
Blake Eggleston commented on CASSANDRA-15393:
-
No, but the local read path also benefits
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964228#comment-16964228
]
Benedict Elliott Smith commented on CASSANDRA-15393:
This shouldn't ever be used
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964227#comment-16964227
]
Blake Eggleston commented on CASSANDRA-15393:
-
The only exception I'm aware of is the
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964215#comment-16964215
]
Benedict Elliott Smith commented on CASSANDRA-15393:
So first we would have to
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964202#comment-16964202
]
Blake Eggleston commented on CASSANDRA-15393:
-
I had not, this group of changes was
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963950#comment-16963950
]
Benedict Elliott Smith commented on CASSANDRA-15393:
Have we considered, for
[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963872#comment-16963872
]
Benedict Elliott Smith commented on CASSANDRA-15393:
We have to be careful here,
45 matches
Mail list logo