On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote:
> 8281874: Can't unpack msi installers from
> test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
> test
Marked as reviewed by almatvee (Reviewer).
-
PR:
On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote:
> Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
> test parameter.
> Fix the code to handle the case when installers are not created and there is
> nothing to verify in the test.
Marked as reviewed by
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
On Tue, 15 Feb 2022 22:32:29 GMT, David Holmes wrote:
> Technically a constructor is not a Member either, but the reflection API can
> get away with lumping constructors in with methods.
>
> The JLS definition of Member comes from 8.1.6 and 8.2 - the key definition
> being in 8.1.6:
>
> "A
On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>>
>>> 593: divisor = (Long) divisors.get(++compactDataIndex);
>>> 594: iPart = getIntegerPart(number, divisor);
>>> 595: }
On Tue, 15 Feb 2022 22:31:47 GMT, Naoto Sato wrote:
>> Fixing an issue in `CompactNumberFormat` which was caused by
>> BigDecimal.divide() that incremented the number in the resulting format
>> string. Also fixing some typos by taking this opportunity.
>
> Naoto Sato has updated the pull
On Tue, 15 Feb 2022 23:05:30 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes from feedback.
>>
>> - Copyright dates fixed
>> - IllegalCallerException thrown for no caller frame, and
On Tue, 15 Feb 2022 22:17:53 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes from feedback.
>
> -
8281874: Can't unpack msi installers from
test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
test
-
Commit messages:
- 8281874: Can't unpack msi installers from
On Tue, 15 Feb 2022 21:59:42 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>
>> 593:
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last
Add explicit discussion of array types to Class.getCanonicalName, no change in
behavior.
I didn't see any existing regression tests for the various "getFooName" methods
of Class so I created a new test file for a handful of test cases.
Please also review the corresponding CSR:
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Copyright dates fixed
- IllegalCallerException thrown for no caller
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
Marked as reviewed by joehw (Reviewer).
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
On Tue, 15 Feb 2022 09:04:02 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 55:
>>
>>> 53: */
>>> 54: @SuppressWarnings("doclint:reference") // cross-module link
>>> 55: public enum AccessFlag {
>>
>> I think there is missing SUPER ACC_SUPER 0x0020
On Tue, 15 Feb 2022 07:17:12 GMT, Adam Sotona wrote:
> I would also recommend to sort access flags by the mask value. Sorted flags
> will match the specification and it will also make more deterministic all
> operations crawling through all the flags. This AccessFlag enum is very
> useful
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Tue, 15 Feb 2022 19:59:11 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line
>> 427:
>>
>>> 425: new ConcurrentHashMap<>();
>>> 426:
>>> 427: static void acquireNativeLibraryLock(String libraryName) {
>>
>> Note sure about
On Tue, 15 Feb 2022 09:48:21 GMT, Maurizio Cimadamore
wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove the coupling of RawNativeLibraries with JNI library loading
>
>
> This patch removes the restriction in the raw library loading mechanism that
> does not allow mix-n-match of loading a library as a JNI library and as a raw
> library.
>
> The raw library loading mechanism is designed for panama to load native
> library essentially equivalent to
On Sat, 5 Feb 2022 15:34:08 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch implements the unsigned upcast intrinsics in x86, which are used
> in vector lane-wise reinterpreting operations.
>
> Thank you very much.
This pull request has now been integrated.
Changeset: 0af356bb
Author:Quan
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
9072610: HashMap copy constructor and putAll can over-allocate table
-
Changes:
- all:
On Tue, 15 Feb 2022 00:10:44 GMT, Tim Prinzing wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove excess description
Looks good.
It's a time-honored tradition in naming bikesheds to pick and choose the
precedents you want to be "consistent" with, and I think that's what's
going on here with your preference for "Ordered" over "Sequenced". But
in an ecosystem as large as Java, you can always find conflicting
precedents
On Wed, 9 Feb 2022 16:37:00 GMT, Christian Stein wrote:
> A number of modules declare that the "provide" ToolProvider.
>
> These modules now specify the "name" of the argument used by
> `ToolProvider.findFirst` to access an instance of the tool provider within
> the description part of a
Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
test parameter.
Fix the code to handle the case when installers are not created and there is
nothing to verify in the test.
-
Commit messages:
- 8281170: Test
On Tue, 15 Feb 2022 16:58:49 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 9072610: HashMap.putAll can cause redundant space
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
9072610: HashMap.putAll can cause redundant space waste
-
Changes:
- all:
> 8281631: HashMap.putAll can cause redundant space waste
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
9072610: HashMap.putAll can cause redundant space waste
-
Changes:
- all:
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Tue, 15 Feb 2022 06:40:57 GMT, Christian Stein wrote:
>> A number of modules declare that the "provide" ToolProvider.
>>
>> These modules now specify the "name" of the argument used by
>> `ToolProvider.findFirst` to access an instance of the tool provider within
>> the description part of
On Tue, 15 Feb 2022 11:20:55 GMT, Lutz Schmidt wrote:
> Well, with the existing implementations for ppc and s390, I do not see a
> complexity advantage with a relaxed spec. The code would have to be there
> anyway.
Same for x86, but we could avoid going into and checking the tail on a
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote:
>> I'm requesting comments and, hopefully, some help with this patch to replace
>> `StringCoding.hasNegatives` with `countPositives`. The new method does a
>> very similar pass, but alters the intrinsic to return the number of leading
>>
On Tue, 15 Feb 2022 06:40:57 GMT, Christian Stein wrote:
>> A number of modules declare that the "provide" ToolProvider.
>>
>> These modules now specify the "name" of the argument used by
>> `ToolProvider.findFirst` to access an instance of the tool provider within
>> the description part of
On Tue, 15 Feb 2022 08:25:29 GMT, Lutz Schmidt wrote:
> Hi Claes, I'm working on the s390 implementation.
Awesome, thanks!
>
> Just for clarification: the return value must be the index of the first
> negative byte?
Yes, or the length if there are no such bytes.
I've considered (and am
On Tue, 15 Feb 2022 02:17:00 GMT, Mandy Chung wrote:
>> This patch removes the restriction in the raw library loading mechanism that
>> does not allow mix-n-match of loading a library as a JNI library and as a
>> raw library.
>>
>> The raw library loading mechanism is designed for panama to
On Tue, 15 Feb 2022 01:13:43 GMT, Joe Darcy wrote:
> Retrofitting of Parameter to implement Member, an interface already
> implemented by similar reflective modeling classes.
>
> Since Parameter is final, there is little compatibility impact from adding a
> new method.
>
> Please also review
On Mon, 14 Feb 2022 22:47:53 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Tue, 15 Feb 2022 06:56:51 GMT, Adam Sotona wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 55:
>
>> 53: */
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote:
>> I'm requesting comments and, hopefully, some help with this patch to replace
>> `StringCoding.hasNegatives` with `countPositives`. The new method does a
>> very similar pass, but alters the intrinsic to return the number of leading
>>
45 matches
Mail list logo
