> Please review this PR.
> SDK 10.15 and earlier reports os.version as 10.16 on Big Sur. This fix will
> check if dynamic linker support, which is supported from Big Sur, is
> available or not on the OS even if os.version is reported as 10.16 instead of
> 11. The os.version 10.16 doesn't
On Fri, 10 Jun 2022 17:51:37 GMT, Mandy Chung wrote:
>> Please review this PR.
>> SDK 10.15 and earlier reports os.version as 10.16 on Big Sur. This fix will
>> check if dynamic linker support, which is supported from Big Sur, is
>> available or not on the OS even if os.version is reported as
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Wed, 1 Jun 2022 05:09:42 GMT, ExE Boss wrote:
>> Or `AbstractMethodError`, which is what `Executable::getParameterCount()`
>> does:
>> https://github.com/openjdk/jdk/blob/e751b7b1b6f7269a1fe20c07748c726536388f6d/src/java.base/share/classes/java/lang/reflect/Executable.java#L248-L258
>
>
On Tue, 14 Jun 2022 01:40:53 GMT, liach wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make mask fields final in ModuleDescriptor.
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 300:
>
>>
On Tue, 31 May 2022 17:23:18 GMT, Rémi Forax wrote:
>> For completeness, I think including SUPER is reasonable, even though has
>> been a no-op for some time. (Some time in the future, there could be a class
>> file version aware additions to this enum class.) Well spotted omission.
>
>
On Tue, 14 Jun 2022 01:25:02 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Tue, 31 May 2022 17:20:08 GMT, Rémi Forax wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 32 additional commits
>> since
On Tue, 14 Jun 2022 00:56:47 GMT, Naoto Sato wrote:
> Backing out a fix that is causing a T1 failure.
>
> This reverts commit 9b6d0a7e94fd18d302c559bec6f785d71a919a88.
This pull request has now been integrated.
Changeset: fbe92666
Author:Naoto Sato
URL:
Backing out a fix that is causing a T1 failure.
This reverts commit 9b6d0a7e94fd18d302c559bec6f785d71a919a88.
-
Commit messages:
- 8288378: [BACKOUT] DST not applying properly with zone id offset set with TZ
env variable
Changes: https://git.openjdk.org/jdk/pull/9151/files
On Tue, 14 Jun 2022 00:56:47 GMT, Naoto Sato wrote:
> Backing out a fix that is causing a T1 failure.
>
> This reverts commit 9b6d0a7e94fd18d302c559bec6f785d71a919a88.
Backout looks accurate - thanks.
-
Marked as reviewed by dholmes (Reviewer).
PR:
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Wed, 13 Apr 2022 21:21:25 GMT, liach wrote:
>> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 167:
>>
>>> 165: * but is optional in the dynamic phase, during execution.
>>> 166: */
>>> 167: STATIC(AccessFlag.STATIC.mask()),
>>
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Tue, 15 Feb 2022 09:06:02 GMT, ExE Boss wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 163:
>
>> 161: *
> Allow JDK modules that use preview features (preview language features or
> preview API features from dependent modules) to participate without the need
> to compile with `--enable-preview`.
>
> It's difficult to enable participation using an annotation due to the nature
> in which symbols
On Mon, 13 Jun 2022 14:29:44 GMT, Jaikiran Pai wrote:
> > Hi Daniel, should we maybe better print something like "check for not
> > allowed characters" in the exception ? Do you have an easy and cheap way in
> > mind to the get the unsupported character (in this case "_") to add it to
> > the
On Mon, 13 Jun 2022 07:26:32 GMT, Matthias Baesken wrote:
> Hi Daniel, should we maybe better print something like "check for not allowed
> characters" in the exception ? Do you have an easy and cheap way in mind to
> the get the unsupported character (in this case "_") to add it to the output
JNI is updated in Java 19 so we need to define JNI_VERSION_19 and change
GetVersion to return this version.
test/hotspot/jtreg/native_sanity/JniVersion.java is updated to check that
JNI_VERSION_19 is returned. The native library in the JMX agent, and several
tests, define JNI_OnLoad that
I took a look.
I found a few results odd:
|com.github.coderodde.util.IndexedLinkedList.addLast in (ms): 8
java.util.LinkedList.addLast in (ms): 2 java.util.ArrayList.addLast in
(ms): 157 org.apache.commons.collections4.list.TreeList.addLast in (ms): 38|
Basically, ArrayList's performance
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to adjust.
>
> Currently still supported ("valid") VS version
On Mon, 13 Jun 2022 10:33:24 GMT, Andrey Turbanov wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use round directly
>
> src/hotspot/share/adlc/main.cpp line 491:
>
>> 489: }
>> 490:
>> 491: // VS2005 has
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want
On Wed, 8 Jun 2022 12:09:27 GMT, Severin Gehwolf wrote:
>> Please review this cleanup change in the cgroup subsystem which used to use
>> hard-coded stack allocated
>> buffers for concatenating strings in memory. We can use `stringStream`
>> instead which doesn't have the issue
>> of
On Sun, 15 May 2022 10:31:20 GMT, Andrey Turbanov wrote:
>> TimeUnit.toMillis/toNanos/toMicros/toSeconds is shorter and a bit faster.
>> Compared via JMH benchmark: 150ns -> 125ns/op
>>
>> Benchamark adapted from
>> http://cr.openjdk.java.net/~shade/8152083/TimeUnitBench.java
>>
>>
>>
Hello,
I have this List/Deque implementation [1] that (in a versatile benchmark)
runs much faster than ArrayList/LinkedList. Under mild assumptions, it
accesses an element in O(sqrt(N)) time.
Now, if all we want to do is to add at the tail and read via get(int
index), you are better of using
On Fri, 10 Jun 2022 14:19:27 GMT, Daniel Fuchs wrote:
> I might question whether the added "null:-1" information is really helpful,
> or just as confusing however.
Hi Daniel, should we maybe better print something like "check for not allowed
characters" in the exception ? Do you have an easy
On Fri, 10 Jun 2022 21:04:04 GMT, Phil Race wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use round directly
>
> src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 38:
>
>> 36: # define
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to adjust.
>
> Currently still supported ("valid") VS version
31 matches
Mail list logo