RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-10-12 Thread Langer, Christoph
(Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files Hi Langer, Here are some of my comments. ZipEntry: Optional> getPosixPermissions() (1) Is "Optional" really necessary here. it's a little inconsistent compared to the rest of methods in the c

Re: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-10-10 Thread Xueming Shen
Hi Langer, Here are some of my comments. ZipEntry: Optional> getPosixPermissions() (1) Is "Optional" really necessary here. it's a little inconsistent compared to the rest of methods in the class. a "null" return might be just fine? (2) Needs a to separate the first line of

RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-10-01 Thread Langer, Christoph
Hi Sherman, thanks for getting back and bringing up these points. > (1) There is a "masked" security concern regarding adding the > "ownership/permission" into the jar file. > > "Security concern: > > The current signed jar spec only protects the name and content of the jar > entries. If any

Re: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-28 Thread Xueming Shen
Hi Langer, Thanks for working on this issue. I will take a look into the implementation details next week. Here are two comments regarding the "direction/approach". (1) There is a "masked" security concern regarding adding the "ownership/permission" into the jar file. "Security concern:

RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-28 Thread Langer, Christoph
o-dev ; Xueming > Shen > Cc: Volker Simonis ; Lindenmaier, Goetz > > Subject: RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and > permissions of the files > > Hi Alan, > > thanks for your initial comments. > > > One initial comment i

RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-26 Thread Langer, Christoph
Hi Alan, thanks for your initial comments. > One initial comment is that you should be able to drop the API additions to > PosxFilePermissions - I think all you need there translation from > Set to internal values, it doesn't require bloating the > API. I agree, it doesn't feel right to bloat

Re: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-25 Thread Alan Bateman
On 25/09/2018 15:57, Langer, Christoph wrote: Hi all, I had asked for opinions regarding adding posix permission support to JDK’s zip handling libraries and tools [1]. Since I didn’t get clear “no, you can’t do this” answers, I’m now concretely proposing some enhancements in the area of

RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-09-25 Thread Langer, Christoph
Hi all, I had asked for opinions regarding adding posix permission support to JDK’s zip handling libraries and tools [1]. Since I didn’t get clear “no, you can’t do this” answers, I’m now concretely proposing some enhancements in the area of java.util.zip, jdk.zipfs and jdk.jartool. I have