RFR[9]: 8133719 java.lang.InternalError in java.lang.invoke.MethodHandleImpl$BindCaller.bindCaller

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8133719 http://cr.openjdk.java.net/~srastogi/8133719/webrev.01/ Thanks, Shilpi

Re: RFR[9]: 8158510: Add test cases to validate Annotation

Thanks Alan and Paul !! Added the header http://cr.openjdk.java.net/~srastogi/8158510/webrev.04/ Regards, Shilpi On 7/5/2016 2:18 PM, Alan Bateman wrote: On 05/07/2016 09:44, Paul Sandoz wrote: On 5 Jul 2016, at 08:18, shilpi.rast...@oracle.com wrote: Hi All, Please review updated webrev

Re: RFR[9]: 8158510: Add test cases to validate Annotation

Hi All, Please review updated webrev http://cr.openjdk.java.net/~srastogi/8158510/webrev.03/ Regards, Shilpi On 7/1/2016 5:11 PM, shilpi.rast...@oracle.com wrote: Thanks Paul !! Please see http://cr.openjdk.java.net/~srastogi/8158510/webrev.01/ Regards, Shilpi On 7/1/2016 3:12 PM, Paul

Re: RFR[9]: 8158510: Add test cases to validate Annotation

-sugared method for a lambda. We don’t know if other byte code generators might do something different. So my recommendation is to limit the testing to the current set of possible failures. Paul. On 1 Jul 2016, at 10:15, shilpi.rast...@oracle.com <mailto:shilpi.rast...@oracle.com> wrote:

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Sandoz wrote: Hi, On 27 Jun 2016, at 14:22, shilpi.rast...@oracle.com wrote: Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8158169 http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/ The test you added is not testing the constraints you added

RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8158169 http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/ Thanks, Shilpi

Fwd: RFR[9] 8039955: jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError:

Gentle reminder! Forwarded Message Subject: RFR[9] 8039955: jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: Date: Tue, 7 Jun 2016 14:58:47 +0530 From: shilpi.rast...@oracle.com <shilpi.rast...@oracle.com> To: core-libs-dev <core

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

(@LambdaWithParameter) && method.isAnnotationPresent(@LambdaWithouParameter) if both annotations were put on the same method. Cheers, -Joe On 6/6/2016 12:20 AM, shilpi.rast...@oracle.com wrote: Gentle reminder!! On 6/3/2016 11:40 AM, shilpi.rast...@oracle.com wrote: Thanks Vladimir and Joel!! Pl

RFR[9] 8039955: jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError:

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8039955 http://cr.openjdk.java.net/~srastogi/8039955/webrev.00/ Thanks, Shilpi

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Gentle reminder!! On 6/3/2016 11:40 AM, shilpi.rast...@oracle.com wrote: Thanks Vladimir and Joel!! Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.04/ Added restriction for synthetic methods as well. On 6/2/2016 5:04 PM, Vladimir Ivanov wrote: On 6/2/16 12:02 AM, Joel

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

cases. Regards, Shilpi cheers /Joel On Tue, 31 May 2016 at 17:49 shilpi.rast...@oracle.com <mailto:shilpi.rast...@oracle.com> <shilpi.rast...@oracle.com <mailto:shilpi.rast...@oracle.com>> wrote: Thanks Paul!! Please see http://cr.openjdk.java.net/~srastogi

RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8158171 http://cr.openjdk.java.net/~srastogi/8158171/webrev.00/ Thanks, Shilpi

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Thanks Paul!! Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.03/ Thanks, Shilpi On 5/31/2016 7:57 PM, Paul Sandoz wrote: >"Returns an array containing Method objects reflecting all the declared methods of the class or interface represented by this Class object, including

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Hi All, Please see updated webrev http://cr.openjdk.java.net/~srastogi/8147585/webrev.02/ On 5/31/2016 2:21 PM, Paul Sandoz wrote: On 31 May 2016, at 10:35, shilpi.rast...@oracle.com wrote: Thanks Paul for comments. Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.01/ Now

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

all this, perhaps little or no say. Thus non-public/non-abstract methods could add inconsistent information to the data structures of AnnotationType. Perhaps this is mostly harmless? Perhaps Joel (CC’ed) can she some more light on this? Paul. On 30 May 2016, at 08:00, shilpi.rast...@oracle.co

Re: RFR[9]: 8156868 MethodHandles.zero(Class) doc issues

Thanks Paul!! Please see http://cr.openjdk.java.net/~srastogi/8156868/webrev.02/ On 5/23/2016 9:08 PM, Paul Sandoz wrote: On 23 May 2016, at 08:27, shilpi.rast...@oracle.com wrote: Hi All, Please review small doc changes- http://cr.openjdk.java.net/~srastogi/8156868/webrev.01/ Fixed

RFR[9]: 8156868 MethodHandles.zero(Class) doc issues

Hi All, Please review small doc changes- http://cr.openjdk.java.net/~srastogi/8156868/webrev.01/ Fixed following doc issues in same patch https://bugs.openjdk.java.net/browse/JDK-8138599

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

On 5/17/2016 10:28 PM, Vladimir Ivanov wrote: Could someone please explain why it is not required for this test as i saw we are updating other tests ( http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0e2a2be60453 ) ? The test was fixed in Jigsaw repo [1] in a different way. Before the fix, the

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

On 5/17/2016 7:44 PM, Alan Bateman wrote: On 17/05/2016 14:34, Martin Buchholz wrote: In jdk8 the /othervm is missing. http://mail.openjdk.java.net/pipermail/jtreg-use/2016-May/000478.html Ah, I assumed we were discussing the version in jdk9/dev. BTW: My interest here is to make sure we

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

On 5/17/2016 6:00 PM, Aleksey Shipilev wrote: On 05/17/2016 03:21 PM, shilpi.rast...@oracle.com wrote: Gentle Reminder! https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ Parse Exception: [-esa]: vm option(s) found, need to specify

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

11.05.2016 um 15:55 schrieb shilpi.rast...@oracle.com: Thank You Michael for comments! It was fixed for VarargsArrayTest.java but not fixed for java/lang/invoke/CustomizedLambdaFormTest.java. Boris Molodenkov <https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=bmoloden>added a c

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

null, null); my 2 cents, Rémi - Mail original - De: "Vladimir Ivanov" <vladimir.x.iva...@oracle.com> À: "shilpi rastogi" <shilpi.rast...@oracle.com> Cc: core-libs-dev@openjdk.java.net Envoyé: Vendredi 13 Mai 2016 15:41:33 Objet: Re: RFR

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

Thanks Paul! Please review http://cr.openjdk.java.net/~srastogi/8149574/webrev10.0/ Regards, Shilpi On 5/13/2016 2:09 PM, Paul Sandoz wrote: assert Boolean.TRUE.equals(ok) : ok;

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

Thank you Vladimir for comments. Please review updated webrev http://cr.openjdk.java.net/~srastogi/8149574/webrev.09/ Regards, Shilpi On 5/12/2016 6:12 PM, Vladimir Ivanov wrote: rankly speaking, I'd prefer [2] to be co

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

Thank You Paul for comments. Please review updated webrev http://cr.openjdk.java.net/~srastogi/8149574/webrev.08/ Regards, Shilpi On 5/12/2016 3:41 PM, Paul Sandoz wrote: On 11 May 2016, at 18:31, shilpi.rast...@oracle.com wrote: Hi All, Please review the updated webrev- http

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

2016, at 13:24, shilpi.rast...@oracle.com wrote: Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK-8149574 Solution: Changed anonymous class package name with the package name of its host class. Two approaches to solve this- 1. Parse .class and get the class name

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

in Jake already and that the bug should be closed once the fix from Jake propagates to dev. What is the status of that? Best, Michael Am 11.05.2016 um 13:24 schrieb shilpi.rast...@oracle.com: Hi All, Please review one small fix for https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.

RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK-8149574 Solution: Changed anonymous class package name with the package name of its host class. Two approaches to solve this- 1. Parse .class and get the class name index form constant pool and patch it with new

RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

Hi All, Please review one small fix for https://bugs.openjdk.java.net/browse/JDK-8155791 http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ Thanks, Shilpi

Fwd: RFR 8150829: Enhanced drop-args, identity and default constant, varargs adjustment

Gentle Reminder! Forwarded Message Subject: RFR 8150829: Enhanced drop-args, identity and default constant, varargs adjustment Date: Tue, 22 Mar 2016 17:11:00 +0530 From: shilpi.rast...@oracle.com <shilpi.rast...@oracle.com> To: core-libs-dev@openjdk.java.net, Joh

RFR 8150829: Enhanced drop-args, identity and default constant, varargs adjustment

Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK-8150829 http://cr.openjdk.java.net/~srastogi/8150829/webrev.04 Thanks, Shilpi

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Hi All, Please see the updated webrev http://cr.openjdk.java.net/~srastogi/8144931/webrev.03/ Regards, Shilpi On 2/18/2016 8:33 PM, Paul Sandoz wrote: On 18 Feb 2016, at 15:55, Vladimir Ivanov wrote: P.S.: You could improve the assertion with the Type class,

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

Thank You Vladimir! I have done the changes. Please review the updated patch- http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/ Regards, Shilpi On 2/18/2016 1:58 PM, Vladimir Ivanov wrote: Shilpi, _CLASS suffix looks redundant and you can abbreviate LAMBDA_FORM to LF: LF_HIDDEN_SIG