Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v13]

2022-10-10 Thread Vladimir Kozlov
On Thu, 6 Oct 2022 06:28:04 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Updated

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-10 Thread Stuart Marks
On Sat, 8 Oct 2022 15:35:14 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread David Holmes
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-10 Thread Stuart Marks
On Sat, 8 Oct 2022 15:35:14 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-10 Thread Stuart Marks
On Sat, 8 Oct 2022 15:35:14 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded [v14]

2022-10-10 Thread David Holmes
On Mon, 10 Oct 2022 11:58:33 GMT, Julian Waters wrote: >> src/java.base/windows/native/libjli/java_md.h line 48: >> >>> 46: */ >>> 47: >>> 48: void reportWithLastWindowsError(const char* message, ...); >> >> Why does this need to be exported in the header file? Are you expecting >> other

Re: [External] : Re: Sequenced Collections

2022-10-10 Thread Stuart Marks
It sounds like you're after some generalized notion of "consistency", and the fact that offer*() return a boolean whereas add*() do not seems inconsistent. Unfortunately, the methods have different semantics. After add(obj), obj is *always* a member of the collection, whereas after offer*(obj),

RFR: 8295104: Break VarHandle tests into separate @test to reduce test execution time

2022-10-10 Thread Mandy Chung
This separates `@run` into its own `@test` that they can be run concurrently. - Commit messages: - 8295104: Break VarHandle tests into separate @test to reduce test execution time Changes: https://git.openjdk.org/jdk/pull/10641/files Webrev:

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-10 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
On Mon, 10 Oct 2022 19:47:37 GMT, Naoto Sato wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
On Mon, 10 Oct 2022 19:45:31 GMT, Naoto Sato wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-10 Thread Bill Huang
This task converts 5 manual tests to automated tests. sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java sun/security/provider/PolicyParser/ExtDirsChange.java sun/security/provider/PolicyParser/ExtDirs.java java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v13]

2022-10-10 Thread Vladimir Kozlov
On Thu, 6 Oct 2022 06:28:04 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Updated

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Sean Mullan
On Mon, 10 Oct 2022 19:19:44 GMT, Sean Coffey wrote: >> Agree, and alternatively, it seems cleaner to add a new SharedSecrets class >> for `java.security.Security` and remove the dependency on PD. > > modified code to have Security class hold the initial properties and provided > an accessor

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-10 Thread Brian Burkhalter
On Sun, 9 Oct 2022 14:04:45 GMT, Markus KARG wrote: >>> This is true, but if a broken subclass sets markpos to less than -1 then >>> lots of code lines will work incorrectly -- including `transferTo` which >>> was the starting point of your change proposal. So do you really only want >>> undo

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

2022-10-10 Thread Brian Burkhalter
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Checking explicitly -1 instead of < 0 Isn't a test needed here which fails without but

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

2022-10-10 Thread Smita Kamath
On Fri, 30 Sep 2022 17:24:31 GMT, Vladimir Kozlov wrote: >> @vnkozlov I spoke too soon. All the GHA tests passed in the dummy draft PR I >> created using Smita's patch: >> https://github.com/openjdk/jdk/pull/10500 >> Please take a look. No build failures reported and all tier1 tests passed. >

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Naoto Sato
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote: > The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread Kim Barrett
On Mon, 10 Oct 2022 11:59:55 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Sean Coffey
On Mon, 10 Oct 2022 07:19:30 GMT, Jaikiran Pai wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check for 0 security events > > src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java > line 29:

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Sean Coffey
On Mon, 10 Oct 2022 14:19:18 GMT, Sean Mullan wrote: >> src/java.base/share/classes/java/security/ProtectionDomain.java line 76: >> >>> 74: static class JavaSecurityAccessImpl implements JavaSecurityAccess { >>> 75: /* cache a copy for recording purposes */ >>> 76: static

Re: RFR: 8292177: InitialSecurityProperty JFR event [v4]

2022-10-10 Thread Sean Coffey
> New JFR event to record state of initial security properties. > > Debug output is also now added for these properties via > -Djava.security.debug=properties Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Address Oct 10 review

RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
The jarsigner and keytool are localized into English, German, Japanese and Simplified Chinese. This task is to modify the existing i18n tests to validate i18n compliance in these tools. In addition, this task also contains changes for manual test enhancement and simplification which

Integrated: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited

2022-10-10 Thread Pavel Rappo
On Tue, 27 Sep 2022 11:43:08 GMT, Pavel Rappo wrote: > This adds exception documentation to JDK methods that would otherwise lose > that documentation once JDK-8287796 is integrated. While adding this > exception documentation now does not change [^1] the JDK API Documentation, > it will

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-10 Thread Daniel Fuchs
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-10 Thread Aleksei Efimov
> ### Summary of the change > This change introduces new system and security properties for specifying > factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider > implementations. > > These new properties allow more granular control over the set of object > factories allowed to

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-10 Thread Aleksei Efimov
On Mon, 10 Oct 2022 13:14:34 GMT, Daniel Fuchs wrote: >>> If I'm not mistaken there's no point in checking the specific filter if the >>> global filter state is REJECTED. So instead of switching on the >>> specificResult below, maybe you should change the logic to switch on the >>>

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Sean Mullan
On Mon, 10 Oct 2022 07:31:29 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check for 0 security events > > src/java.base/share/classes/java/security/ProtectionDomain.java line 76: > >> 74:

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Jaikiran Pai
On Mon, 10 Oct 2022 11:29:52 GMT, Erik Gahlin wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java >> line 33: >> >>> 31: @Category({"Java Development Kit", "Security"}) >>> 32: @Label("Initial Security Property") >>> 33: @Name("jdk.InitialSecurityProperty") >>

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-10 Thread Daniel Fuchs
On Mon, 10 Oct 2022 12:07:38 GMT, Aleksei Efimov wrote: >> src/java.naming/share/classes/com/sun/naming/internal/ObjectFactoriesFilter.java >> line 99: >> >>> 97: return globalResult == Status.ALLOWED; >>> 98: } >>> 99: >> >> If I'm not mistaken there's no point in

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-10 Thread Aleksei Efimov
On Mon, 10 Oct 2022 11:16:40 GMT, Daniel Fuchs wrote: > If I'm not mistaken there's no point in checking the specific filter if the > global filter state is REJECTED. So instead of switching on the > specificResult below, maybe you should change the logic to switch on the > globalResult

Withdrawn: 8292016: Cleanup legacy error reporting in the JDK outside of HotSpot

2022-10-10 Thread Julian Waters
On Sun, 14 Aug 2022 16:21:31 GMT, Julian Waters wrote: > A large section of error reporting code in the JDK does not properly handle > WIN32 API errors and instead mixes them with errors originating from C. Since > they can be rather easily replaced and coming up with an elegant solution >

Re: RFR: 8292016: Cleanup legacy error reporting in the JDK outside of HotSpot [v35]

2022-10-10 Thread Julian Waters
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote: >> A large section of error reporting code in the JDK does not properly handle >> WIN32 API errors and instead mixes them with errors originating from C. >> Since they can be rather easily replaced and coming up with an elegant >> solution

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-10 Thread Julian Waters
On Mon, 10 Oct 2022 05:06:00 GMT, David Holmes wrote: >> src/java.base/share/native/libjli/jli_util.h line 91: >> >>> 89: * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference >>> 90: * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170 >>> 91: */ >> >> I don't

Re: RFR: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded [v14]

2022-10-10 Thread Julian Waters
On Mon, 10 Oct 2022 04:35:12 GMT, David Holmes wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-10 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Erik Gahlin
On Mon, 10 Oct 2022 08:04:28 GMT, Jaikiran Pai wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check for 0 security events > > src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java > line 33:

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v2]

2022-10-10 Thread Daniel Fuchs
On Sun, 9 Oct 2022 11:52:18 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-10-10 Thread Andrey Turbanov
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >>

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Erik Gahlin
On Mon, 10 Oct 2022 08:06:45 GMT, Jaikiran Pai wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check for 0 security events > > src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java > line 35:

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Andrey Turbanov
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with one additional

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Jaikiran Pai
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with one additional

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Alan Bateman
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with one additional

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Jaikiran Pai
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with one additional

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-10 Thread Jaikiran Pai
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with one additional