Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Jaikiran Pai
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote: > Here are some benchmarking results: > https://github.com/iii-i/zlib-ng/wiki/Performance-with-dfltcc-patch-applied-and-dfltcc-support-built-on-dfltcc-enabled-machine. > The interesting data is in column `compressed_size` where `level`

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v6]

2023-03-06 Thread Ravali Yatham
On Mon, 6 Mar 2023 17:07:14 GMT, Mandy Chung wrote: >> Ravali Yatham has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added JavaLangAccess::getLoaderNameID(ClassLoader loader) > > Looks good. Thanks for the change. @mlchung

Re: RFR: JDK-8297605 DelayQueue javadoc is confusing

2023-03-06 Thread Martin Buchholz
On Thu, 2 Mar 2023 15:59:33 GMT, Martin Buchholz wrote: > Right. But remove(Object) unlike remove() doesn't consider the expiration > time. Confusing! Actually, confusion extends to **three** methods with the same name: - `Queue.remove()` - `Collection.remove(Object)` - `Iterator.remove()`

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Tue, 7 Mar 2023 01:26:44 GMT, Sandhya Viswanathan wrote: >> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in >> Interpreter and C1 compiler to produce the same results as C2 intrinsics on >> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter [v2]

2023-03-06 Thread Vladimir Kozlov
> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java > methods were implemented originally. > > Replaced

Re: RFR: JDK-8302360 Atomic*.compareAndExchange Javadoc unclear

2023-03-06 Thread David Holmes
On Mon, 6 Mar 2023 13:23:59 GMT, Viktor Klang wrote: > I think the following proposal is very non-invasive and merely draws > attention to the fact that "witness value" is a specific term related to the > notion of these atomic methods. > > It's a small change which I think provides

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Sandhya Viswanathan
On Tue, 7 Mar 2023 01:59:25 GMT, Vladimir Kozlov wrote: >> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 3931: >> >>> 3929: // For results consistency both intrinsics should be enabled. >>> 3930: if >>> (vmIntrinsics::is_intrinsic_available(vmIntrinsics::_float16ToFloat) && >>>

Re: RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-06 Thread Amit Kumar
On Tue, 7 Mar 2023 02:23:52 GMT, David Holmes wrote: >> This PR adds StressStackOverflow.java test to ProblemList. The feature Scope >> Value is not yet implemented on s390x-arch which is Incubating state. >> Whenever fix will be given to >>

Re: RFR: 8303499: [s390x] ProblemList StressStackOverflow

2023-03-06 Thread David Holmes
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 2 Mar 2023 16:22:24 GMT, Amit Kumar wrote:

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Tue, 7 Mar 2023 01:04:00 GMT, Sandhya Viswanathan wrote: >> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in >> Interpreter and C1 compiler to produce the same results as C2 intrinsics on >> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-06 Thread Joe Darcy
On Sun, 5 Mar 2023 17:10:08 GMT, Joe Darcy wrote: > PS Successful Mach 5 job of default builds and tier 1 tests with this make > line present. PPS And for extra measure as suggested by David Holmes, a tier 1 through 5 build job was also successful. - PR:

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Sandhya Viswanathan
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Sandhya Viswanathan
On Tue, 7 Mar 2023 00:52:37 GMT, Vladimir Kozlov wrote: > Note, I removed `ConvF2HFNode::Identity()` optimization because tests show > that it produces different NaN results due to skipped conversion. Yes, removing the Identity optimization is correct. It doesn't hold for NaN inputs.

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Sandhya Viswanathan
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

RFR: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

2023-03-06 Thread Alexander Matveev
- Fixed by increasing test timeout. Fix verified on host which reproduced issue. - Commit messages: - 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out Changes: https://git.openjdk.org/jdk/pull/12896/files Webrev:

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Tue, 7 Mar 2023 00:19:03 GMT, Sandhya Viswanathan wrote: > For x86 32-bit also things are consistent across. Only the SharedRuntime > optimization doesnt happen for x86 32bit as StubRoutines::hf2f() and > StubRoutines::f2hf() are set as null. The fallback is handled correctly in >

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Sandhya Viswanathan
On Mon, 6 Mar 2023 23:54:44 GMT, Vladimir Kozlov wrote: >> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in >> Interpreter and C1 compiler to produce the same results as C2 intrinsics on >> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

Re: RFR: 8217496: Matcher.group() can return null after usePattern

2023-03-06 Thread Stuart Marks
On Thu, 2 Mar 2023 17:13:28 GMT, Ian Graves wrote: > Updates to the documentation to describe behavior in Matcher.group(). LGTM - Marked as reviewed by smarks (Reviewer). PR: https://git.openjdk.org/jdk/pull/12835

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Roger Riggs
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: ZipOutputStream & directories

2023-03-06 Thread Eirik Bjørsnøs
> > Eirik's mail mentions that 7% of Spring Petclinic dependences are > directories. It might be interesting to dig into that to see how they > are generated, is it mostly maven-jar-plugin and if so, which APIs is it > using? > Some stats: Of 109 JAR files, 2 do not have a manifest file, and 28

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Lance Andersen
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo

Re: ZipOutputStream & directories

2023-03-06 Thread Lance Andersen
Adding an API Note will require a CSR. And yes, what we often think as the right change tends to bite us (given this code has been in the wild since the 90s) so best to err on the side of documentation vs. assuming this change would not cause more problems than it is worth. Best Lance On

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote: >> Yes, iff means if-and-only-if and is used for extra precision in formal >> logic, mathematics. As @pavelrappo points out it's a relatively common >> occurrence in the OpenJDK sources, though perhaps not in the public >> javadocs.

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Pavel Rappo
> Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the generated HTML pages) can be summarized as > follows:

Re: ZipOutputStream & directories

2023-03-06 Thread Eirik Bjørsnøs
On Mon, Mar 6, 2023 at 8:45 PM Alan Bateman wrote: > Changing ZOS.putNextEntry to ignore the method/size provided by the > caller would change long standing behavior, and Hyrum's Law has it that > somebody will notice. I was not thinking of changing anything if the caller actually specified a

Re: ZipOutputStream & directories

2023-03-06 Thread Lance Andersen
On Mar 6, 2023, at 2:44 PM, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: On 06/03/2023 19:16, Lance Andersen wrote: : So I guess I do not see a huge downside, however we might want to look at a property to adjust in the unlikely event the unexpected occurs? Alan thoughts? Yeah, the

Re: ZipOutputStream & directories

2023-03-06 Thread Alan Bateman
On 06/03/2023 19:16, Lance Andersen wrote: : So I guess I do not see a huge downside, however we might want to look at a property to adjust in the unlikely event the unexpected occurs? Alan thoughts? Yeah, the jar tool does the right thing and writes directories entries with the STORED

Integrated: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test

2023-03-06 Thread Matthew Donovan
On Mon, 9 Jan 2023 19:54:24 GMT, Matthew Donovan wrote: > Removed SSLSocketParametersTest.sh script (which just called a Java file) and > configured the java code to run directly with jtreg This pull request has now been integrated. Changeset: ccfe1675 Author:Matthew Donovan Committer:

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v43]

2023-03-06 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: ZipOutputStream & directories

2023-03-06 Thread Lance Andersen
Hi Eirik, Please see below On Mar 6, 2023, at 1:43 PM, Eirik Bjørsnøs mailto:eir...@gmail.com>> wrote: Hi, I noticed that ZipOutputStream violates APPNOTE.txt when writing directory entries: You are referring to section: 4.3.8 File data Immediately following the

ZipOutputStream & directories

2023-03-06 Thread Eirik Bjørsnøs
Hi, I noticed that ZipOutputStream violates APPNOTE.txt when writing directory entries: Zero-byte files, directories, and other file types that > contain no content MUST NOT include file data. Nobody seems to have complained about this violation (I searched JBS), so in itself it might not be

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Paul Sandoz
On Mon, 6 Mar 2023 17:34:35 GMT, Adam Sotona wrote: >> The use-case seems fine to me (and that it only makes sense for building >> code). I still think it's a "transform", but with a different source. Subtly >> changing the name makes it seem different and fundamentally it is not >> AFAICT.

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 6 Mar 2023 17:15:25 GMT, Paul Sandoz

Integrated: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id

2023-03-06 Thread Naoto Sato
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 20:51:14 GMT, Naoto Sato wrote:

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
On Thu, 2 Mar 2023 19:56:08 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Paul Sandoz
On Mon, 6 Mar 2023 17:02:46 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 165: >> >>> 163: * @return this builder >>> 164: */ >>> 165: default CodeBuilder transforming(CodeTransform transform, >>> Consumer handler) { >> >>

Re: RFR: 8294982: Implementation of Classfile API [v49]

2023-03-06 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v6]

2023-03-06 Thread Mandy Chung
On Mon, 6 Mar 2023 11:08:42 GMT, Ravali Yatham wrote: >> Added specific class loader object to proxy IllegalArgumentException from >> which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > Ravali Yatham has updated the pull request

Re: RFR: 8294982: Implementation of Classfile API [v36]

2023-03-06 Thread Adam Sotona
On Thu, 2 Mar 2023 23:28:23 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> StackMapFrameInfo extracted to top level from StackMapTableAttribute > >

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

2023-03-06 Thread Roger Riggs
On Sun, 5 Mar 2023 06:14:49 GMT, Thomas Stuefe wrote: > I think to be even more useful it could make sense to print the current > directory the child is started in as well as the env var array, possibly only > with a finer logging level. There are concerns about exposing potentially sensitive

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-06 Thread Jorn Vernee
On Wed, 1 Mar 2023 06:37:45 GMT, Martin Doerr wrote: >>> * Uploaded my simple reproducer to >>> [JDK-8303017](https://bugs.openjdk.org/browse/JDK-8303017) >> >> Thanks! >> >>> * Using oversized load / stores is problematic. Don't forget that >>> OpenJDK still supports Big Endian

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

2023-03-06 Thread Roger Riggs
On Mon, 6 Mar 2023 12:44:57 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add javadoc @implNote to Runtime.exec and ProcessBuilder methods > >

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v3]

2023-03-06 Thread Lance Andersen
On Sat, 4 Mar 2023 02:22:39 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Integrated: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-06 Thread Doug Simon
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 15:40:01 GMT, Doug Simon wrote:

Re: RFR: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-06 Thread Doug Simon
On Fri, 3 Mar 2023 18:05:51 GMT, Vladimir Kozlov wrote: >> JDK-8297431 added code for special handling of OutOfMemoryError when >> translating an exception between libjvmci and HotSpot[1]. >> Unfortunately, this code was deleted by JDK-8298099 when moving the >> exception translation mechanism

Re: RFR: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-06 Thread Tom Rodriguez
On Fri, 3 Mar 2023 15:40:01 GMT, Doug Simon wrote: > JDK-8297431 added code for special handling of OutOfMemoryError when > translating an exception between libjvmci and HotSpot[1]. > Unfortunately, this code was deleted by JDK-8298099 when moving the exception > translation mechanism to

Re: RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote: > Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in > Interpreter and C1 compiler to produce the same results as C2 intrinsics on > x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java >

RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

2023-03-06 Thread Vladimir Kozlov
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- Implemented `Float.floatToFloat16` and

Re: RFR: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id [v3]

2023-03-06 Thread Roger Riggs
On Sat, 4 Mar 2023 02:22:39 GMT, Naoto Sato wrote: >> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is

Re: RFR: JDK-8302360 Atomic*.compareAndExchange Javadoc unclear

2023-03-06 Thread Martin Buchholz
On Mon, 6 Mar 2023 13:23:59 GMT, Viktor Klang wrote: > I think the following proposal is very non-invasive and merely draws > attention to the fact that "witness value" is a specific term related to the > notion of these atomic methods. > > It's a small change which I think provides

Re: UUID creation performance

2023-03-06 Thread Roger Riggs
Hi Brett, You might be trying to over optimize, making the source more complex than is useful or necessary. I think it is likely that on most architectures the varhandles take advantage of appropriate machine instructions and both have the same performance. I expect the performance difference

Integrated: 8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-03-06 Thread Leonid Mesnik
On Wed, 1 Mar 2023 20:50:38 GMT, Leonid Mesnik wrote: > It is the 2nd attempt to fix > [JDK-8303133](https://bugs.openjdk.org/browse/JDK-8303133) Update > ProcessTools.startProcess(...) to exit early if the process exit before > linePredicate is printed. > > The first fix failed because it

Integrated: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)

2023-03-06 Thread Jorn Vernee
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 19:27:24 GMT, Jorn Vernee

Re: Testing no memory leak occurs via references

2023-03-06 Thread Aleksei Ivanov
On 06/03/2023 13:51, Albert Yang wrote: Upon a cursory inspection of ForceGC.java, it seems that the fundamental logic involves waiting for a certain duration and relying on chance. However, I am of the opinion that utilizing the WhiteBox API can provide greater determinism and potentially

Re: RFR: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline) [v2]

2023-03-06 Thread Jorn Vernee
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > Port of:

Re: Testing no memory leak occurs via references

2023-03-06 Thread Roger Riggs
Hi Albert, The only  downside of the WhiteBox API is the need to link and run with native code. It make adhoc testing more difficult. I would not say ForceGC relies on chance, since it is testing the specific condition as requested by the caller. It uses mechanisms available to normal

Integrated: 8303582: Reduce duplication in jdk/java/foreign tests

2023-03-06 Thread Jorn Vernee
On Fri, 3 Mar 2023 15:08:01 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/804 which reduces > duplication in the test code by switching test value generation over to a > common method in `NativeTestHelper`. This pull request has now been integrated.

Re: RFR: 8303582: Reduce duplication in jdk/java/foreign tests

2023-03-06 Thread Maurizio Cimadamore
On Fri, 3 Mar 2023 15:08:01 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/804 which reduces > duplication in the test code by switching test value generation over to a > common method in `NativeTestHelper`. Looks good (already reviewed in the panama repo)

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-06 Thread Adam Sotona
On Wed, 1 Mar 2023 10:05:27 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/ChainedFieldBuilder.java >> line 48: >> >>> 46: this.consumer = consumer; >>> 47: FieldBuilder b = downstream; >>> 48: while (b instanceof ChainedFieldBuilder

Re: RFR: 8294982: Implementation of Classfile API [v48]

2023-03-06 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
On Sat, 4 Mar 2023 19:34:36 GMT, Marius Volkhart wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tighten up reporting of string template errors (fewer messages) > >

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 20:17:24 GMT, Roger Riggs

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v42]

2023-03-06 Thread Jim Laskey
On Fri, 3 Mar 2023 19:42:53 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tighten up reporting of string template errors (fewer messages) > >

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 22:35:48 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v47]

2023-03-06 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: Testing no memory leak occurs via references

2023-03-06 Thread Albert Yang
Upon a cursory inspection of ForceGC.java, it seems that the fundamental logic involves waiting for a certain duration and relying on chance. However, I am of the opinion that utilizing the WhiteBox API can provide greater determinism and potentially strengthen some of the assertions. > I

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Jaikiran Pai
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote: > P.S. Here we are compressing random data, if I read the testcase correctly > (rnd.nextBytes(dataIn);), Yes, you read it right. - PR: https://git.openjdk.org/jdk/pull/12283

RFR: JDK-8302360 Atomic*.compareAndExchange Javadoc unclear

2023-03-06 Thread Viktor Klang
I think the following proposal is very non-invasive and merely draws attention to the fact that "witness value" is a specific term related to the notion of these atomic methods. It's a small change which I think provides additional clarity, see JBS for the discussion on the topic.

Re: Testing no memory leak occurs via references

2023-03-06 Thread Aleksei Ivanov
Thank you, Stuart and Roger, for the suggestion. I didn't know about ForceGC class. We should use the common library, I have updated my PR [7] with ForceGC. Albert and Thomas suggested using WhiteBox API. It would probably work too, however, I decided ForceGC is simpler and easier to use,

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Ilya Leoshkevich
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Jaikiran Pai
On Mon, 6 Mar 2023 13:10:57 GMT, Ilya Leoshkevich wrote: >> Amit Kumar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change acc to Alan comments > >> Finally, are you or someone in your team, in contact with the author(s) of >> the

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Fri, 3 Mar 2023 23:12:17 GMT, Paul Sandoz

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Ilya Leoshkevich
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

2023-03-06 Thread Daniel Fuchs
On Sat, 4 Mar 2023 14:22:33 GMT, Roger Riggs wrote: >> Runtime.exec and ProcessBuilder.start methods create a new operating system >> process with the program and arguments. Many applications configure a >> logging subsystem to monitor application events. Logging a process start >> message

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:44:24 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v46]

2023-03-06 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Amit Kumar
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Jaikiran Pai
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Amit Kumar
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Jaikiran Pai
On Thu, 2 Feb 2023 08:27:55 GMT, Amit Kumar wrote: >> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v6]

2023-03-06 Thread Ravali Yatham
> Added specific class loader object to proxy IllegalArgumentException from > which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 Ravali Yatham has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v4]

2023-03-06 Thread Ravali Yatham
On Thu, 2 Mar 2023 20:00:24 GMT, Mandy Chung wrote: >>> Thanks @AlanBateman. Regarding the separator, Have seen this being used in >>> ClassLoader.java for nameAndId method. Hence used the same for consistency. >>> I've reformatted L886 now, Please kindly check. >> >> Thanks for checking, the

Re: RFR: 8294982: Implementation of Classfile API [v43]

2023-03-06 Thread Adam Sotona
On Fri, 3 Mar 2023 21:56:39 GMT, Paul Sandoz wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed AccessFlags javadoc >> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform >> - removed

Re: RFR: 8294982: Implementation of Classfile API [v45]

2023-03-06 Thread Adam Sotona
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- > This is root pull request with Classfile API

Re: RFR: 8294982: Implementation of Classfile API [v44]

2023-03-06 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Re: RFR: 8297605: DelayQueue javadoc is confusing

2023-03-06 Thread Viktor Klang
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 2 Mar 2023 20:00:56 GMT, Martin Buchholz

Re: RFR: 8299748: java/util/zip/Deinflate.java failing on s390x [v2]

2023-03-06 Thread Amit Kumar
On Mon, 6 Mar 2023 06:54:27 GMT, Jaikiran Pai wrote: >After running the test you can share with us the logs. We could provide more >suggestions what to debug further, but I think you or someone with access to >that system will have to do the actual investigation.. Output for above patch, I

Integrated: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-03-06 Thread Andrey Turbanov
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote: > `LinkedList` is used as a field > `jdk.tools.jimage.JImageTask.OptionsValues#jimages` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred as more