Integrated: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed This pull request has now been

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread David Holmes
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Hotspot change is trivially fine, but too insignificant to hit the Approve button. Thanks - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1752152672

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread David Holmes
On Mon, 27 Nov 2023 23:44:25 GMT, Sandhya Viswanathan wrote: >> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors > > Yes, Vamsi is part of Intel Java team. He also has the author status > (https://openjdk.org/census#sparasa). @sviswa7 I am asking about the copyright holder

RFR: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS

2023-11-27 Thread Alexander Matveev
Looks like the test timed out due to slow/loaded host. Failure log similar to [JDK-8296489](https://bugs.openjdk.org/browse/JDK-8296489) and [JDK-8298735](https://bugs.openjdk.org/browse/JDK-8298735). Fixed by increasing test timeout. - Commit messages: - 8320681: [macos] Test

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-27 Thread Serguei Spitsyn
On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote: > The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since > JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to > throw UnsupportedOperationException unconditionally in Java 19/20. Early in > Java

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Xiaohong Gong
On Mon, 27 Nov 2023 16:43:09 GMT, Andrew Haley wrote: >> Apparently the situation is this: If your build machine happens to have SVE, >> then you will get SVE support in the vmath library. The SVE support will be >> used during runtime if the machine you run on has SVE support. >> >> If your

Re: RFR: 8320759: Creation of random BigIntegers can be made faster [v2]

2023-11-27 Thread Brian Burkhalter
On Mon, 27 Nov 2023 22:52:36 GMT, fabioromano1 wrote: >> src/java.base/share/classes/java/math/BigInteger.java line 754: >> >>> 752: // numInts >= 1, since numBits > 0 >>> 753: >>> 754: int firstInt = rnd.nextInt() & (-1 >>> -numBits); // Mask out >>> any excess bits >> >>

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-11-27 Thread Srinivas Vamsi Parasa
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Srinivas Vamsi Parasa
On Tue, 28 Nov 2023 00:04:55 GMT, Sandhya Viswanathan wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >>

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Sandhya Viswanathan
On Sat, 18 Nov 2023 01:21:09 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX2 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v35]

2023-11-27 Thread Joe Darcy
On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-27 Thread Sandhya Viswanathan
On Tue, 21 Nov 2023 15:14:28 GMT, Dalibor Topic wrote: >> src/java.base/linux/native/libsimdsort/avx2-32bit-qsort.hpp line 3: >> >>> 1: /* >>> 2: * Copyright (c) 2021, 2023, Intel Corporation. All rights reserved. >>> 3: * Copyright (c) 2021 Serge Sans Paille. All rights reserved. >> >> Is

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v13]

2023-11-27 Thread Svein Otto Solem
I tried to understand the GathererOp class and came over a small detail concering Gatherer.Integrator. The two gatheres below are equivalent, both are greedy. Gatherer.Integrator.Greedy voidStringIntegerGreedy = (v, s, downStream) -> downStream.push(s.length()); var greedy1 =

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v2]

2023-11-27 Thread Joe Darcy
On Thu, 2 Nov 2023 17:42:48 GMT, Jim Laskey wrote: >> `UNNAMED_CLASSES` should probably be removed, as I think it is fully >> replaced with `IMPLICIT_CLASSES`, and I don't think there are bootstrap >> problems here (unlike in `jdk.internal.java.PreviewFeature`). I would say it >> would make

Re: RFR: 8320759: Creation of random BigIntegers can be made faster [v2]

2023-11-27 Thread fabioromano1
> A faster and simpler way to generate random BigIntegers, avoiding eventually > trimming of leading zeros in magnitude array. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update BigInteger(int, Random) Update a comment

Re: RFR: 8320759: Creation of random BigIntegers can be made faster

2023-11-27 Thread fabioromano1
On Mon, 27 Nov 2023 22:34:12 GMT, Brian Burkhalter wrote: >> A faster and simpler way to generate random BigIntegers, avoiding eventually >> trimming of leading zeros in magnitude array. > > src/java.base/share/classes/java/math/BigInteger.java line 754: > >> 752: // numInts >= 1,

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Iris Clark
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1751551968

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-27 Thread Hans Boehm
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote: > Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]

2023-11-27 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Revert 2 lines in method scan - Changes: - all:

Re: RFR: 8320759: Creation of random BigIntegers can be made faster

2023-11-27 Thread Brian Burkhalter
On Sun, 26 Nov 2023 16:52:40 GMT, fabioromano1 wrote: > A faster and simpler way to generate random BigIntegers, avoiding eventually > trimming of leading zeros in magnitude array. src/java.base/share/classes/java/math/BigInteger.java line 732: > 730: */ > 731: public BigInteger(int

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-27 Thread Hans Boehm
On Tue, 21 Nov 2023 22:58:09 GMT, Roger Riggs wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-27 Thread Hans Boehm
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote: > Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A

Integrated: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update

2023-11-27 Thread Alexey Semenyuk
On Thu, 23 Nov 2023 16:36:28 GMT, Alexey Semenyuk wrote: > Fix uninstallation scripts in Linux installers to take action on desktop > files only if these desktop files are not owned by another package. This > prevents `xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from >

Re: [External] : Re: Automatic modules and jpackage

2023-11-27 Thread Alexey Semenyuk
On 11/27/2023 4:43 PM, Mark Raynsford wrote: On Mon, 2023-11-27 at 15:51 -0500, Alexey Semenyuk wrote: Hi Mark, Good to know you've sorted out the issue. I replied to your email last week, but didn't send it to the right recipients and it got lost. Resending once again just in case: If you

Re: RFR: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update

2023-11-27 Thread Alexander Matveev
On Thu, 23 Nov 2023 16:36:28 GMT, Alexey Semenyuk wrote: > Fix uninstallation scripts in Linux installers to take action on desktop > files only if these desktop files are not owned by another package. This > prevents `xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from >

Re: RFR: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update

2023-11-27 Thread Alexey Semenyuk
On Thu, 23 Nov 2023 16:36:28 GMT, Alexey Semenyuk wrote: > Fix uninstallation scripts in Linux installers to take action on desktop > files only if these desktop files are not owned by another package. This > prevents `xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from >

Integrated: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux

2023-11-27 Thread Alexey Semenyuk
On Fri, 24 Nov 2023 16:33:13 GMT, Alexey Semenyuk wrote: > 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux This pull request has now been integrated. Changeset: 726f854b Author:Alexey Semenyuk URL:

Re: RFR: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux

2023-11-27 Thread Alexander Matveev
On Fri, 24 Nov 2023 16:33:13 GMT, Alexey Semenyuk wrote: > 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16810#pullrequestreview-1751469146

Re: RFR: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux

2023-11-27 Thread Alexey Semenyuk
On Fri, 24 Nov 2023 16:33:13 GMT, Alexey Semenyuk wrote: > 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux @sashamatveev please review - PR Comment: https://git.openjdk.org/jdk/pull/16810#issuecomment-1828514026

Integrated: 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently on Windows in verifyDescription

2023-11-27 Thread Alexey Semenyuk
On Fri, 24 Nov 2023 22:20:20 GMT, Alexey Semenyuk wrote: > 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently > on Windows in verifyDescription This pull request has now been integrated. Changeset: 5f7f2c4e Author:Alexey Semenyuk URL:

Re: Automatic modules and jpackage

2023-11-27 Thread Mark Raynsford
On Mon, 2023-11-27 at 15:51 -0500, Alexey Semenyuk wrote: > Hi Mark, > > Good to know you've sorted out the issue. I replied to your email > last > week, but didn't send it to the right recipients and it got lost. > Resending once again just in case: > > If you want your app's modules in app

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-11-27 Thread Vladimir Yaroslavskiy
On Mon, 27 Nov 2023 21:17:24 GMT, Srinivas Vamsi Parasa wrote: > > Hello Vamsi (@vamsi-parasa), > > Do you have the new results? > > Hi Vladimir (@iaroslavski), > > Sorry for the delay as I was on vacation the whole of last week. Will provide > the data today by EOD (US pacific time). (Looks

Re: RFR: 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently on Windows in verifyDescription [v2]

2023-11-27 Thread Alexey Semenyuk
On Fri, 24 Nov 2023 22:31:18 GMT, Alexey Semenyuk wrote: >> 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently >> on Windows in verifyDescription > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently on Windows in verifyDescription [v2]

2023-11-27 Thread Alexander Matveev
On Fri, 24 Nov 2023 22:31:18 GMT, Alexey Semenyuk wrote: >> 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently >> on Windows in verifyDescription > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-11-27 Thread Srinivas Vamsi Parasa
On Fri, 17 Nov 2023 23:14:18 GMT, Srinivas Vamsi Parasa wrote: >> Hello Vamsi (@vamsi-parasa), >> >> Thank you very much for benchmarking, I appreciate your efforts! >> >> I looked at non-parallel sorting when radix sort is switched off >> (DualPivotQuicksort_RadixForParallel) and cannot

Re: RFR: JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing [v2]

2023-11-27 Thread Lance Andersen
On Mon, 27 Nov 2023 21:12:17 GMT, Justin Lu wrote: >> Please review this PR which fixes timeouts for the two tests: >> _java/util/Locale/LocaleProvidersRun.java_ and >> _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_. >> >> These tests were updated to accept VM flags in >>

Re: RFR: JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing [v2]

2023-11-27 Thread Justin Lu
> Please review this PR which fixes timeouts for the two tests: > _java/util/Locale/LocaleProvidersRun.java_ and > _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_. > > These tests were updated to accept VM flags in > [JDK-8319569](https://bugs.openjdk.org/browse/JDK-8319569),

Re: RFR: JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing

2023-11-27 Thread Brian Burkhalter
On Mon, 27 Nov 2023 19:32:04 GMT, Justin Lu wrote: > Please review this PR which fixes timeouts for the two tests: > _java/util/Locale/LocaleProvidersRun.java_ and > _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_. > > These tests were updated to accept VM flags in >

Re: Automatic modules and jpackage

2023-11-27 Thread Alexey Semenyuk
Hi Mark, Good to know you've sorted out the issue. I replied to your email last week, but didn't send it to the right recipients and it got lost. Resending once again just in case: If you want your app's modules in app directory, you can specify external runtime to jpackage with

Re: RFR: JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing

2023-11-27 Thread Naoto Sato
On Mon, 27 Nov 2023 19:32:04 GMT, Justin Lu wrote: > Please review this PR which fixes timeouts for the two tests: > _java/util/Locale/LocaleProvidersRun.java_ and > _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_. > > These tests were updated to accept VM flags in >

Re: RFR: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless [v2]

2023-11-27 Thread Mandy Chung
On Tue, 21 Nov 2023 17:30:20 GMT, Tim Prinzing wrote: >> Marked as flagless. > > Tim Prinzing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v4]

2023-11-27 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword [v2]

2023-11-27 Thread Phil Race
> Many printing tests do not have the @printer keyword. This adds them to those > that need it. > I also found one test that has nothing to do with printing in the print > folder and moved it out. Phil Race has updated the pull request incrementally with one additional commit since the last

RFR: JDK-8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing

2023-11-27 Thread Justin Lu
Please review this PR which fixes timeouts for the two tests: _java/util/Locale/LocaleProvidersRun.java_ and _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_. These tests were updated to accept VM flags in [JDK-8319569](https://bugs.openjdk.org/browse/JDK-8319569), which is

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword

2023-11-27 Thread Phil Race
On Thu, 23 Nov 2023 20:39:50 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/print/PageFormat/SetOrient.java line 28: >> >>> 26: * @summary Confirm that the clip and transform of the Graphics2D is >>> 27: * affected by the landscape orientation of the PageFormat. >>> 28: */ >> >>

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword

2023-11-27 Thread Phil Race
On Thu, 23 Nov 2023 07:02:54 GMT, Alan Bateman wrote: >> Many printing tests do not have the @printer keyword. This adds them to >> those that need it. >> I also found one test that has nothing to do with printing in the print >> folder and moved it out. > > test/jdk/TEST.ROOT line 15: > >>

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword

2023-11-27 Thread Phil Race
On Thu, 23 Nov 2023 11:10:35 GMT, Alexey Ivanov wrote: >> Many printing tests do not have the @printer keyword. This adds them to >> those that need it. >> I also found one test that has nothing to do with printing in the print >> folder and moved it out. > >

Re: RFR: 8320440: Implementation of Structured Concurrency (Second Preview)

2023-11-27 Thread Mandy Chung
On Mon, 20 Nov 2023 19:48:20 GMT, Alan Bateman wrote: > This API is sitting out JDK 22, meaning no API/implementation changes in this > PR. We expect this API to do a third preview in JDK 23 with some API changes. > > So for now, we just need to bump JEP number/title that shows up in the >

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v13]

2023-11-27 Thread Roger Riggs
> Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during construction that might invalidate internal invariants for the > correct

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
On Mon, 27 Nov 2023 18:14:53 GMT, Iris Clark wrote: > Verified `synchronized` keyword removed from method declaration as in > upstream source. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/16829#issuecomment-1828441202

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
On Mon, 27 Nov 2023 18:17:50 GMT, Lance Andersen wrote: > This looks OK. > > Please add a the appropriate label given there is no test included with this > change so that you do not get asked later where is the test ;-) Added a label and note. Thanks! - PR Comment:

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Nothing exception in this batch of start-of-release updates. Clean local testing results on tier 1. The symbol files correspond to JDK 22 build 25 and will be updated with subsequent builds as

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Chen Liang
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Changes requested by liach (Author). src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 1: > 1: /* `latestMajorVersion` below should be updated to return `JAVA_23_VERSION` as

RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
Time to start making preparations for JDK 23. - Commit messages: - Add symbol files for JDK 22 build 25. - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into JDK-8319413 - Adjust expected release date. - Fix omission in Classfile.java - JDK-8319413: Start of

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
On Fri, 3 Nov 2023 23:52:45 GMT, Chen Liang wrote: >> Time to start making preparations for JDK 23. > > src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 1: > >> 1: /* > > `latestMajorVersion` below should be updated to return `JAVA_23_VERSION` as > well. Good catch;

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Lance Andersen
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed This looks OK. Please add a the

Re: RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Iris Clark
On Mon, 27 Nov 2023 17:24:35 GMT, Joe Wang wrote: > Applying an update from the upstream source, quote: "Removing synchronized > from the getInstance() methods". As the reporter noted, this change was made > 16 years ago. > > Tests: SQE & unit tests passed Verified `synchronized` keyword

Re: RFR: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets

2023-11-27 Thread Brian Burkhalter
On Mon, 27 Nov 2023 16:17:14 GMT, Eirik Bjorsnos wrote: > Please review this trivial, formatting and documentation-only change which > adds missing whitespace around a few `if` statements, `while` statements and > assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`. > >

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v12]

2023-11-27 Thread Claes Redestad
On Mon, 27 Nov 2023 17:28:34 GMT, Roger Riggs wrote: >> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8584: >> >>> 8582: evpcmpuw(mask1, tmp1Reg, tmp2Reg, Assembler::le, >>> Assembler::AVX_512bit); >>> 8583: kortestdl(mask1, mask1); >>> 8584: jcc(Assembler::carryClear,

Re: RFR: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets

2023-11-27 Thread Joe Darcy
On Mon, 27 Nov 2023 16:17:14 GMT, Eirik Bjorsnos wrote: > Please review this trivial, formatting and documentation-only change which > adds missing whitespace around a few `if` statements, `while` statements and > assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`. > >

Integrated: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy

2023-11-27 Thread Steve Dohrmann
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote: > Update: the XorTest::xor results shown in this message used test code from PR > commit 7cc272e862791 which was based on Maurizio Cimadamore's commit > a788f066af17. The XorTest has since been updated and XorTest::copy is no > longer

RFR: 8320602: Lock contention in SchemaDVFactory.getInstance()

2023-11-27 Thread Joe Wang
Applying an update from the upstream source, quote: "Removing synchronized from the getInstance() methods". As the reporter noted, this change was made 16 years ago. Tests: SQE & unit tests passed - Commit messages: - 8320602: Lock contention in SchemaDVFactory.getInstance()

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v12]

2023-11-27 Thread Roger Riggs
On Mon, 27 Nov 2023 13:43:52 GMT, Damon Fenacci wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply StringUTF16.coderFromArrayLen > > src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8584: > >> 8582:

Re: Automatic modules and jpackage

2023-11-27 Thread Mark Raynsford
On Mon, 2023-11-27 at 16:09 +, Mark Raynsford wrote: > > As I mentioned in the blog, I feel like almost all of the > functionality might already be there (minus a way to get the runtime > to use -p instead of -cp internally), it's just that there doesn't > appear to be a way to get jpackage

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v12]

2023-11-27 Thread Damon Fenacci
On Wed, 22 Nov 2023 05:03:41 GMT, Roger Riggs wrote: >> Strings, after construction, are immutable but may be constructed from >> mutable arrays of bytes, characters, or integers. >> The string constructors should guard against the effects of mutating the >> arrays during construction that

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh [v2]

2023-11-27 Thread Gaurav Chaudhari
On Sat, 25 Nov 2023 16:45:07 GMT, Eirik Bjorsnos wrote: >>> Reviewer time is a scarce resource. It would be wasteful to spend review >>> cycles on getting a fix of this `.sh` test integrated now and then >>> immediately follow up with a delete in the rewrite PR. >>> >>> I think we should

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Andrew Haley
On Mon, 27 Nov 2023 15:22:32 GMT, Magnus Ihse Bursie wrote: > In fact, I am not even sure why it seems to the PR author to be a good idea > to let the default be dependent on the build machine at all. My personal > opinion is that it would be better to select either "SVE enabled" or "SVE >

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v13]

2023-11-27 Thread Viktor Klang
On Tue, 21 Nov 2023 10:11:28 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Javadoc clarifications for Gatherer type

Re: RFR: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets

2023-11-27 Thread Lance Andersen
On Mon, 27 Nov 2023 16:17:14 GMT, Eirik Bjorsnos wrote: > Please review this trivial, formatting and documentation-only change which > adds missing whitespace around a few `if` statements, `while` statements and > assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`. > >

RFR: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets

2023-11-27 Thread Eirik Bjorsnos
Please review this trivial, formatting and documentation-only change which adds missing whitespace around a few `if` statements, `while` statements and assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`. While there are many similar issues in the OpenJDK code base, these

Re: Automatic modules and jpackage

2023-11-27 Thread Mark Raynsford
On Mon, 2023-11-27 at 14:42 +, Alan Bateman wrote: > On 27/11/2023 11:44, Mark Raynsford wrote: > > I'm not entirely convinced that discussion on this list doesn't get > > lost in the endless sea of "RFR: " messages. :) > > It was originally sent to jigsaw-dev, then Alan Synder sent it here.

Re: RFR: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-11-27 Thread Kevin Walls
On Mon, 27 Nov 2023 15:10:52 GMT, Daniel Fuchs wrote: >> Have you considered naming it "socketConnectTimeout" instead? Or possibly >> "tcpConnectTimeout"? > > If you named it "tcpConnectTimeout" then you could name the (future) property > for

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Magnus Ihse Bursie
On Mon, 27 Nov 2023 15:11:32 GMT, Andrew Haley wrote: >> You still need to separate out the SVE detection from the libsleef code, and >> provide a way to enable/disable it from the configure command line. It is >> not okay to auto-detect if features should be turned on or off by default, >>

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Andrew Haley
On Mon, 27 Nov 2023 14:59:23 GMT, Magnus Ihse Bursie wrote: > You still need to separate out the SVE detection from the libsleef code, and > provide a way to enable/disable it from the configure command line. Why? I don't think this should be a build-time option at all, because it puts the

Re: RFR: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-11-27 Thread Daniel Fuchs
On Mon, 27 Nov 2023 15:00:54 GMT, Daniel Fuchs wrote: >> On the Property name: there is an existing System Property >> "sun.rmi.transport.connectionTimeout" which is a 15-second idle timeout. >> Having a "connectionTimeout" and this new one as "connectTimeout" could be >> confusing, even in

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Magnus Ihse Bursie
On Mon, 27 Nov 2023 10:28:45 GMT, Andrew Haley wrote: >> We have to use this c-compiler option to build out the SVE ABIs (e.g. >> `svfloat32_t sinfx_u10sve(svfloat32_t input)`) in `libvmath.so`. Without >> this option, at build time, all the sve related featues like `arm_sve.h / >>

Re: RFR: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-11-27 Thread Daniel Fuchs
On Mon, 27 Nov 2023 14:35:07 GMT, Kevin Walls wrote: >> wrt to the property name initialConnectTimeout might infer that it is an >> initial value which can be subsequentually modified, but that is not >> possible. As such, would sun.rmi.transport.tcp.connectTimeout be more >> appropriate --

RFR: 8320759: Creation of random BigIntegers can be made faster

2023-11-27 Thread fabioromano1
A faster and simpler way to generate random BigIntegers, avoiding eventually trimming of leading zeros in magnitude array. - Commit messages: - Optimized randomBits(int, Random) - Removed trailing whitespaces - Correct randomBits(int, Random) - Update BigInteger.java - Merge

Re: Automatic modules and jpackage

2023-11-27 Thread Alan Bateman
On 27/11/2023 11:44, Mark Raynsford wrote: I'm not entirely convinced that discussion on this list doesn't get lost in the endless sea of "RFR: " messages. :) It was originally sent to jigsaw-dev, then Alan Synder sent it here. As you know, automatic modules are to support migration without

Re: RFR: 8316649: JMX connection timeout cannot be changed and uses the default of 0 (infinite)

2023-11-27 Thread Kevin Walls
On Fri, 24 Nov 2023 16:28:38 GMT, Mark Sheppard wrote: >> Thanks, yes so JMX SSL clients are without socket connect timeout, good to >> have that documented. I logged a parallel RFE for >> SslRMIClientSocketFactory, which should wait for now as it seems wrong to go >> changing that right now

RFR: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules

2023-11-27 Thread Alan Bateman
This is update to the specification of the j.l.module.ResolvedModule.reads method to clarify that the set of resolved modules returned does not include itself. There is a small implementation change to align with the specification and fix an anomaly that arises with configurations that contain

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-27 Thread Serguei Spitsyn
On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote: > The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since > JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to > throw UnsupportedOperationException unconditionally in Java 19/20. Early in > Java

Re: Automatic modules and jpackage

2023-11-27 Thread Mark Raynsford
I'm not entirely convinced that discussion on this list doesn't get lost in the endless sea of "RFR: " messages. :) For reference, here are the adventures I undertook that got me stuck on jpackage's hard requirements for named modules:

Re: RFR: 8310644: Make panama memory segment close use async handshakes [v5]

2023-11-27 Thread Maurizio Cimadamore
On Fri, 24 Nov 2023 18:30:17 GMT, Erik Österlund wrote: >> The current logic for closing memory in panama today is susceptible to live >> lock if we have a closing thread that wants to close the memory in a loop >> that keeps failing, and a bunch of accessing threads that want to perform >>

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-27 Thread Andrew Haley
On Mon, 27 Nov 2023 01:06:21 GMT, Xiaohong Gong wrote: >> make/autoconf/lib-vmath.m4 line 94: >> >>> 92: # Check the ARM SVE feature >>> 93: SVE_CFLAGS="-march=armv8-a+sve" >>> 94: >> >> What's this about? We're building a standard binary, and all SVE detection >> is to

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-27 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Re: RFR: 8308753: Class-File API transition to Preview [v31]

2023-11-27 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Re: RFR: 8320699: Add parameter to skip progress logging of OutputAnalyzer

2023-11-27 Thread Stefan Karlsson
On Fri, 24 Nov 2023 17:01:29 GMT, Jaikiran Pai wrote: > Hello Stefan, I agree with David that I have found these logs to be useful - > it shows that process launched by the test hasn't yet finished and is being > waited upon. The log message when written will have a timestamp and can then >

Re: RFR: 8320699: Add parameter to skip progress logging of OutputAnalyzer

2023-11-27 Thread Stefan Karlsson
On Fri, 24 Nov 2023 17:13:30 GMT, Jaikiran Pai wrote: > Other than a quick local test run, I haven't tested it for anything else. It > did improve the situation in one of my test and it now only logs it once. In > the setup that you are seeing this large amount of logging, would you be able >

Integrated: 8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null

2023-11-27 Thread Adam Sotona
On Thu, 23 Nov 2023 11:52:05 GMT, Adam Sotona wrote: > ClassFile API StackMapGenerator caused a NPE for a test case with invalid > sequence of instructions. > This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack > > Please review. > > Thanks, > Adam This pull request

Integrated: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

2023-11-27 Thread Christoph Langer
On Wed, 22 Nov 2023 15:59:38 GMT, Christoph Langer wrote: > java/lang/invoke/lambda/LambdaFileEncodingSerialization.java is already > problem listed on linux-x64. However, the issue is not processor specific. We > see the failure on linux on other architectures as well. This pull request has

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-27 Thread Alan Bateman
On Fri, 24 Nov 2023 11:28:23 GMT, Ivan Šipka wrote: > > I use the jdk_core test group. I know the split doesn't impact users of > > this test group but it's not clear why the change is being done. Would it > > be possible to explain why you are doing this? There is nothing in the JBS > >