On Sun, 26 Nov 2023 18:18:10 GMT, Alan Bateman wrote:
> This is update to the specification of the j.l.module.ResolvedModule.reads
> method to clarify that the set of resolved modules returned does not include
> itself. There is a small implementation change to align with the
> specification
On Fri, 1 Dec 2023 02:48:42 GMT, Brian Burkhalter wrote:
>> The only other alternative would be to walk `((FilterOutputStream)out).out`
>> and if everything in the out chain is in the "java." package then the out
>> can be trusted.
>>
>> byte[] tmp = null;
>> for (OutputStream os = out; os !=
On Fri, 1 Dec 2023 01:19:32 GMT, jmehrens wrote:
>> Changed in 176d5165f7d8f3fa4814c9838abb5d18d9f3c338 not to trust
>> `FilterOutputStream`s.
>
> The only other alternative would be to walk `((FilterOutputStream)out).out`
> and if everything in the out chain is in the "java." package then the
On Thu, 30 Nov 2023 14:14:56 GMT, Alexey Semenyuk wrote:
> Add tests to make sure jpackage emits meaningful error messages when used
> with invalid app images.
>
> Added `JPackageCommand.nullableOutputBundle()` function that returns an empty
> `Optional` instance if it fails to deduce a path
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote:
> Description of problem and propsed fix from @plummercj
> '
> In test/failure_handler/src/share/conf/mac.properties we have:
>
> process.top.app=top
> process.top.args=-l 1
>
> So top is run with the "-l 1" args, causing it to do one
On Thu, 30 Nov 2023 16:23:39 GMT, Stefan Karlsson wrote:
>> Tests using ProcessTools.executeProcess gets the following output written to
>> stdout:
>> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
>> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ensureOpen()
Thank you for the update Naoto. The
On Thu, 30 Nov 2023 20:13:06 GMT, Magnus Ihse Bursie wrote:
> Not having a build time dependency on libsleef means you cannot really verify
> that the functions you want to call are correct, but maybe you feel secure
> that they will never change?
I'm not sure. The main reason that we add
On Thu, 30 Nov 2023 23:27:13 GMT, Brian Burkhalter wrote:
>> Good catch: that in fact defeats the protection.
>
> Changed in 176d5165f7d8f3fa4814c9838abb5d18d9f3c338 not to trust
> `FilterOutputStream`s.
The only other alternative would be to walk `((FilterOutputStream)out).out` and
if
On Thu, 30 Nov 2023 11:13:14 GMT, Andrew Haley wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename vmath to sleef in configure
>
> make/autoconf/lib-sleef.m4 line 56:
>
>> 54: AC_MSG_CHECKING([for the
Description of problem and propsed fix from @plummercj
'
In test/failure_handler/src/share/conf/mac.properties we have:
process.top.app=top
process.top.args=-l 1
So top is run with the "-l 1" args, causing it to do one iteration and then
exit. Unfortunately the first iteration always shows all
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update symbol files to JDK 22 b26.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16505/files
- new:
On Thu, 30 Nov 2023 17:21:50 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 211:
>>
>>> 209: if (len > 0) {
>>> 210: byte[] tmp;
>>> 211: if ("java.io".equals(out.getClass().getPackageName()))
>>
>> Isn't this
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: Trust
On Thu, 30 Nov 2023 12:34:24 GMT, Sergey Tsypanov wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8321053: Trust non-FilterOutputStreams in "java." packages
>
>
On Wed, 15 Nov 2023 22:45:46 GMT, Stuart Marks wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
This pull request has now been integrated.
On Thu, 30 Nov 2023 21:51:19 GMT, Naoto Sato wrote:
>> Removing the unnecessary array assignments.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill()
LGTM
-
Marked as reviewed by rriggs
On Tue, 21 Nov 2023 22:58:09 GMT, Roger Riggs wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Thu, 30 Nov 2023 14:14:56 GMT, Alexey Semenyuk wrote:
> Add tests to make sure jpackage emits meaningful error messages when used
> with invalid app images.
>
> Added `JPackageCommand.nullableOutputBundle()` function that returns an empty
> `Optional` instance if it fails to deduce a path
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' into JDK-8319413
> -
On Thu, 30 Nov 2023 21:47:27 GMT, Naoto Sato wrote:
> > Is that "XXX" reminder at line 58 in MergeCollation still pertinent or
> > could it be removed?
>
> Maybe, but not 100% sure, so I just left it.
If unsure, better to leave it.
-
PR Comment:
On Thu, 30 Nov 2023 21:51:19 GMT, Naoto Sato wrote:
>> Removing the unnecessary array assignments.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill()
Marked as reviewed by bpb (Reviewer).
-
PR
On Tue, 21 Nov 2023 09:13:59 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 505:
>>
>>> 503: * to return this reference even though the referent is still
>>> strongly
>>> 504: * reachable. That is, before the referent has reached the
> Removing the unnecessary array assignments.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Use Arrays.fill()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16912/files
- new:
On Thu, 30 Nov 2023 21:17:57 GMT, Brian Burkhalter wrote:
> Is that "XXX" reminder at line 58 in MergeCollation still pertinent or could
> it be removed?
Maybe, but not 100% sure, so I just left it.
-
PR Comment: https://git.openjdk.org/jdk/pull/16912#issuecomment-1834615018
On Thu, 30 Nov 2023 21:26:20 GMT, Brett Okken wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Arrays.fill()
>
> src/java.base/share/classes/sun/text/CompactByteArray.java line 83:
>
>> 81: for (i =
On Thu, 30 Nov 2023 20:59:01 GMT, Jorn Vernee wrote:
> Need to use `jlong_to_ptr` instead of raw cast.
>
> I've also fixed another latent issue in `CLayouts` where we were initializing
> `C_LONG_LONG` with the `long` layout. This was resulting in a class cast
> exception when running the
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
src/java.base/share/classes/sun/text/CompactByteArray.java line 83:
> 81: for (i = 0; i < UNICODECOUNT; ++i) {
> 82: values[i] = defaultValue;
> 83: }
Need to use `jlong_to_ptr` instead of raw cast.
I've also fixed another latent issue in `CLayouts` where we were initializing
`C_LONG_LONG` with the `long` layout. This was resulting in a class cast
exception when running the XorTest benchmark. The size of `long` on Linux x86
32-bits is 4
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
Looks fine.
Is that "XXX" reminder at line 58 in MergeCollation still pertinent or could it
be removed?
-
Marked as reviewed by bpb (Reviewer).
PR Review:
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
Looks good
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16912#pullrequestreview-1758458649
On Tue, 28 Nov 2023 00:35:48 GMT, Srinivas Vamsi Parasa
wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add @SuppressWarnings (serial)
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
>
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request incrementally with one additional
On Thu, 30 Nov 2023 10:17:23 GMT, Jaikiran Pai wrote:
>> I like the new wording (have no oppinion if absolute path is better).
>
> Hello Justin,
>
>> I am not sure if you have a preference one way or another regarding
>> providing the full path versus just the file name, but I can switch the
PR submitted. I was pleasantly surprised how quickly bugreport.java.com
turned reports into issues.
Naoto
On 11/29/23 2:18 PM, Anthony Goubard wrote:
Thanks for the answers.
I've created an issue in bugreport.java.com
Removing the unnecessary array assignments.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16912/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16912=00
Issue: https://bugs.openjdk.org/browse/JDK-8321059
Stats: 8 lines in 2 files changed: 2
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains eight commits:
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into JDK-8319413
- Add symbol files for JDK
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 22:58:17 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug
On Thu, 30 Nov 2023 19:50:00 GMT, Sergey Bylokhov wrote:
> probably we can link this from our wiki page where we describe the usage of
> keywords?:
> https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements
Good idea, once this is pushed, I'll add
On Thu, 30 Nov 2023 20:07:19 GMT, Magnus Ihse Bursie wrote:
> But you are saying that you want to skip building this library unless you
> have a gcc version that supports c++17?
>
Yes, the request is to skip building the simdsort library if GCC version is < 8
as only GCC >= 8 supports C++17
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 14:50:24 GMT, Andrew Haley wrote:
>> Do this, but with the name vect_math.S. Don't use SLEEF headers in the
>> build. I think you can do this with no build-time dependency on SLEEF at all
>> if you load the library lazily at runtime.
>>
>>
On Thu, 30 Nov 2023 18:19:51 GMT, Srinivas Vamsi Parasa
wrote:
>> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
>> just CXXFLAGS?
>>
>> Also @vamsi-parasa, did you check into if this really was needed and why? To
>> be clear, I basically consider this an
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
> This is update to the specification of the j.l.module.ResolvedModule.reads
> method to clarify that the set of resolved modules returned does not include
> itself. There is a small implementation change to align with the
> specification and fix an anomaly that arises with configurations that
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 23 Oct 2023 13:58:27 GMT, Jorn Vernee wrote:
> Explicitly handle UpcallStub allocation failures by terminating. We currently
> might try to use the returned `nullptr` which would fail sooner or later.
> This patch just makes the termination explicit.
This pull request has now been
On Thu, 30 Nov 2023 17:25:26 GMT, Mandy Chung wrote:
>> I haven't looked into the details, but the common case is for jlink users to
>> use the default module path (`jmods` folder of the JDK install) and the
>> prime use-case for this is to get away with performing a link without the
>>
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev wrote:
>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.
@shipilev @AlanBateman @dcubed-ojdk I'm on it.
-
PR Comment:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
since the last
On Thu, 30 Nov 2023 17:08:21 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PrinterJob/EmptyFill.java line 72:
>
>> 70:return;
>> 71:}
>>
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa,
On Thu, 30 Nov 2023 15:41:28 GMT, Alexey Ivanov wrote:
>> "Should not" is strong. Why ? There's no requirement do to this even though
>> you can.
>> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files
>
> That's the reason why I prefer you keep the `@run` tag in
On Thu, 30 Nov 2023 15:59:29 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PageFormat/SmallPaperPrinting.java line 73:
>
>> 71: job.print();
>> 72:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Created an equivalent issue for
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
remove ensureOpen()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new:
On Thu, 30 Nov 2023 10:58:13 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 293:
>
>> 291:
>> 292:
On Thu, 30 Nov 2023 04:26:44 GMT, jmehrens wrote:
>> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
>> `BAIS.transferTo` only if the target stream is in the `java.io` package.
>
> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 211:
>
>> 209:
On Thu, 30 Nov 2023 10:13:39 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 286:
>>
>>> 284: }
>>> 285:
>>> 286: boolean useModulePath = !options.modulePath.isEmpty();
>>
>> Is there any reason why the run-time
On Thu, 30 Nov 2023 09:47:05 GMT, Vladimir Sitnikov
wrote:
>>> You have to know that it is in the java.io package and it doesn't wrap
>>> another stream.
>>
>> That is a good point. In the previous work on this override, we converged on
>> the current implementation to not leak the internal
On Thu, 30 Nov 2023 10:00:48 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 88:
>>
>>> 86:
>>> 87: // Run time based link internal resources files
>>> 88: private static final String OTHER_RESOURCES_FILE =
>>>
On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race wrote:
>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added
>> `@key printer`.
>>
>> Since both files contain all the tags except for `@test` in the .java file,
>> you should not remove the `@run` tag from the .java file and
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote:
> File.mkdirs() occasionally fails to create folders on Windows shared folders.
> It turned out that Windows API FindFirstFileW created the error
> ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error
> still returns
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:53:24 GMT, Phil Race wrote:
> I can .. but I am not aware of even a convention to do that ordering.
It's not written anywhere as far as I know. There's [an ongoing
discussion](https://github.com/openjdk/jdk/pull/16674#discussion_r1402082665)
about it in #16674.
On Thu, 30 Nov 2023 09:57:33 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 621:
>>
>>> 619: String resName = String.format(OTHER_RESOURCES_FILE, modName);
>>> 620: try {
>>> 621: InputStream inStream =
>>>
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa,
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
> Explicitly handle UpcallStub allocation failures by terminating. We currently
> might try to use the returned `nullptr` which would fail sooner or later.
> This patch just makes the termination explicit.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a
On Thu, 30 Nov 2023 12:19:33 GMT, Jaikiran Pai wrote:
> Hello Stefan,
>
> > The test were I want to use this is a long-running stress test that is
> > known to be good at shaking out JVM hangs. It has been written to provide
> > its own output about spawned processes and what they are doing,
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 16:14:37 GMT, Aleksey Shipilev wrote:
> Hold on, can we figure out if Zero can actually be fixed before we go and
> disable the test? I think we only disable the tests like this if there is an
> intrinsic reason why the test does not apply to a platform.
I would problem
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
> [2023-11-24T09:58:23.071045055Z] Waiting for completion
On Thu, 30 Nov 2023 16:18:42 GMT, Jorn Vernee wrote:
> > Hold on, can we figure out if Zero can actually be fixed before we go and
> > disable the test? I think we only disable the tests like this if there is
> > an intrinsic reason why the test does not apply to a platform.
>
> I would
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
This pull request has now been integrated.
Changeset: c6a82783
Author:Daniel D. Daugherty
URL:
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev wrote:
>> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
>
> All right! Hope it would be fixed soon. Trivial.
@shipilev and @AlanBateman - Thanks for the fast reviews.
-
PR Comment:
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
All right! Hope it would be fixed soon. Trivial.
-
Marked as reviewed by shade (Reviewer).
PR Review:
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16909#pullrequestreview-1757847283
A trivial fix to ProblemList java/util/stream/GatherersTest.java.
-
Commit messages:
- 8321127: ProblemList java/util/stream/GatherersTest.java
Changes: https://git.openjdk.org/jdk/pull/16909/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16909=00
Issue:
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
On Thu, 30 Nov 2023 15:48:11 GMT, Jorn Vernee wrote:
> This test is problematic on Zero due to
> https://bugs.openjdk.org/browse/JDK-8321064
>
> Disable it for now on that platform, until a Zero maintainer has a chance to
> look into it.
>
> Testing: running TestHandshake on zero to see that
This test is problematic on Zero due to
https://bugs.openjdk.org/browse/JDK-8321064
Disable it for now on that platform, until a Zero maintainer has a chance to
look into it.
Testing: running TestHandshake on zero to see that it is skipped.
-
Commit messages:
- disable
On Thu, 30 Nov 2023 15:00:00 GMT, Pavel Rappo wrote:
> Please review this PR to correctly rename "Unnamed Class" to "Implicitly
> Declared Class", not "Implicit Class".
>
> Renaming is fixed where it affects documentation or the end-user. Renaming is
> not fixed where it only affects code:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Wed, 22 Nov 2023 07:05:21 GMT, Eric Liu wrote:
>> Vector API defines zero-extend operations [1], which are going to be
>> intrinsified and generated to `VectorUCastNode` by C2. This patch adds
>> backend implementation for `VectorUCastNode` on AArch64.
>>
>> The micro benchmark shows
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by
Please review this PR to correctly rename "Unnamed Class" to "Implicitly
Declared Class", not "Implicit Class".
Renaming is fixed where it affects documentation or the end-user. Renaming is
not fixed where it only affects code: it's perfectly okay to derive an internal
element name from
On Thu, 2 Nov 2023 23:19:24 GMT, Jorn Vernee wrote:
>> Explicitly handle UpcallStub allocation failures by terminating. We
>> currently might try to use the returned `nullptr` which would fail sooner or
>> later. This patch just makes the termination explicit.
>
> Jorn Vernee has updated the
On Thu, 30 Nov 2023 11:46:58 GMT, Andrew Haley wrote:
> [vect_math.S.txt](https://github.com/openjdk/jdk/files/13512306/vect_math.S.txt)
I guess this will live only in os_linux and os_bsd because the Windows compiler
won't like it AFAIK.
-
PR Comment:
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
This pull request has now been integrated.
Changeset: 33b26f79
Author:Viktor Klang
Committer: Alan Bateman
URL:
On Thu, 30 Nov 2023 14:30:25 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 32 commits:
>
> - Lowering upper
1 - 100 of 141 matches
Mail list logo
