On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Tue, 9 Apr 2024 12:01:49 GMT, Claes Redestad wrote:
> This patch suggests a workaround to an issue with huge SCF MH expression
> trees taking excessive JIT compilation resources by reviving (part of) the
> simple bytecode-generating strategy that was originally available as an
>
On Fri, 12 Apr 2024 00:10:22 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing yet more review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2521:
>
On Fri, 12 Apr 2024 00:07:56 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall
On Fri, 12 Apr 2024 00:00:38 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2751:
>>
>>> 2749: UnsafeSetMemoryMark usmm(this, true, true);
>>> 2750:
>>> 2751: __ generate_fill(T_BYTE, false, c_rarg0, c_rarg1, r11, rax,
>>> xmm0);
>>
On Fri, 12 Apr 2024 00:03:10 GMT, Scott Gibbons wrote:
>> test/jdk/sun/misc/CopyMemory.java line 214:
>>
>>> 212: random.setSeed(seed);
>>> 213: System.out.println("Seed set to "+ seed);
>>> 214:
>>
>> Looks like these lines were added for debugging, could be removed.
>
> Yes,
On Thu, 11 Apr 2024 23:30:07 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing more review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2751:
>
>>
On Thu, 11 Apr 2024 22:00:01 GMT, Sandhya Viswanathan
wrote:
>> No. Reviewing the code I saw this as a potential error, as
>> `arraycopy_avx3_large` could cause a SIGBUS which wouldn't be caught. It
>> conforms to the other instances of copy in the code. I think it was missed
>> by the
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Thu, 11 Apr 2024 21:47:01 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall
On Thu, 11 Apr 2024 20:58:00 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 735:
>>
>>> 733:
>>> 734: if (MaxVectorSize == 64) {
>>> 735: UnsafeCopyMemoryMark ucmm(this, !is_oop && !aligned, false,
>>> ucme_exit_pc);
>>
>> This is not related
On Tue, 9 Apr 2024 12:01:49 GMT, Claes Redestad wrote:
> This patch suggests a workaround to an issue with huge SCF MH expression
> trees taking excessive JIT compilation resources by reviving (part of) the
> simple bytecode-generating strategy that was originally available as an
>
On Thu, 11 Apr 2024 20:55:11 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Wed, 10 Apr 2024 15:38:22 GMT, Jorn Vernee wrote:
> Please review this simple cleanup which removes the
> `AbstractLinker::linkerByteOrder` method. It was only used in
> `AixPPC64Linker`, where we know it will always return `ByteOrder.BIG_ENDIAN`
> so we can just replace the call with
On Thu, 11 Apr 2024 20:08:18 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix whitespace error.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8343:
>
>> 8341:
On Thu, 11 Apr 2024 01:46:06 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 14 additional commits
>> since
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
> parsing for NumberFormat.
>
> The concrete subclasses that will utilize this leniency value are
> `DecimalFormat` and `CompactNumberFormat`. Strict leniency allows for parsing
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when
On Thu, 11 Apr 2024 18:42:56 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall
On Thu, 11 Apr 2024 10:15:54 GMT, Maurizio Cimadamore
wrote:
>> This PR removes support for the string template feature from the Java
>> compiler and the Java SE API, as discussed here:
>>
>> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
>
> Maurizio Cimadamore
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Thu, 11 Apr 2024 17:08:49 GMT, Suchismith Roy wrote:
> > Thanks! This looks like a good idea. Only the directory handling needs some
> > modification. This version tries to load
> > "test-support/jtreg_test_jdk_java_lang_RuntimeTests_loadLibrary_aix/scratch/0/native/libawt_headless.so",
> >
On Thu, 11 Apr 2024 18:17:01 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Wed, 10 Apr 2024 18:02:38 GMT, Volodymyr Paprotski wrote:
> > In `ECOperations.java`, if I understand this correctly, it is to replace
> > the existing `PointMultiplier` with montgomery-based PointMuliplier. But
> > when I look at the code, I see both are still options. If I read this
> >
On Sun, 18 Feb 2024 16:52:15 GMT, Chen Liang wrote:
>> This patch aims to correct handling of annotations on parameters with the
>> help of `MethodParameters` attribute, which will be always available once
>> #9862 is integrated.
>>
>> It utilizes and expands upon the existing parameter
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Thu, 11 Apr 2024 16:08:31 GMT, Alan Bateman wrote:
>> We should probably find a way to not emit the event if n == 0 and the
>> operation was interrupted by `Selector.wakeUp`. Since we have another issue
>> logged to emit a spin event, I wonder if we should only commit the event
>> here if
On Thu, 11 Apr 2024 09:12:30 GMT, Daniel Fuchs wrote:
>>> Maybe that's OK - and maybe in that case the onus is on the user to set a
>>> threshold greater than 1500ms?
>>
>> The threshold is 20ms so these timed-select ops in the HTTP client will
>> record an event when they timeout.
>
> We
On Thu, 11 Apr 2024 10:15:54 GMT, Maurizio Cimadamore
wrote:
>> This PR removes support for the string template feature from the Java
>> compiler and the Java SE API, as discussed here:
>>
>> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
>
> Maurizio Cimadamore
On Mon, 2 Oct 2023 23:05:29 GMT, Shaojin Wen wrote:
> In the current version, FMT."v =%d{1}" will call the
> StringConcatHelper.prepend(long/byte[]/long) method, which should behave the
> same as STR."v ={1}". Call StringConcatHelper.prepend(long/byte[]/int),
> should not convert int to long
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Thu, 7 Mar 2024 05:33:16 GMT, Korov wrote:
>> When the specified key did not associated with a value, should check the
>> `key` and `value` type.
>
> Korov has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Use testNG builtin
On Thu, 11 Apr 2024 00:38:11 GMT, Sandhya Viswanathan
wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add movq to locate_operand
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 5988:
>
>> 5986:
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote:
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this PR:
>
> Benchmark(size) Mode Cnt
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this PR:
>
> Benchmark(size) Mode Cnt
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote:
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
>
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote:
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
>
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
While `SymbolLookup` correctly uses an `Optional` return to denote whether a
symbol has been found by the lookup or not (which enables composition of symbol
lookups), many clients end up just calling `Optional::get`, or
`Optional::orElseThrow()` on the result.
This PR proposes to add a
On Wed, 10 Apr 2024 12:49:11 GMT, Per Minborg wrote:
> This PR proposes to add two overloads `MemorySegment::reinterpretate` to
> allow aligned reinterpretation.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/18717
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit
On Thu, 11 Apr 2024 09:12:06 GMT, Jan Lahoda wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix issues in digit classes
>
> test/langtools/jdk/jshell/CompletionSuggestionTest.java line 327:
>
>> 325:
On Thu, 11 Apr 2024 09:54:53 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>
On Thu, 11 Apr 2024 09:26:27 GMT, Jaikiran Pai wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 301:
>
>>
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote:
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu
On Thu, 11 Apr 2024 09:07:10 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>
On Thu, 11 Apr 2024 09:07:10 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>
On Wed, 10 Apr 2024 10:59:25 GMT, Maurizio Cimadamore
wrote:
>> This PR removes support for the string template feature from the Java
>> compiler and the Java SE API, as discussed here:
>>
>> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
>
> Maurizio Cimadamore
On Mon, 26 Feb 2024 17:40:59 GMT, Alan Bateman wrote:
>> Is n == 0 intended to detect a spinning condition where the selector goes
>> back into select when the event has not been handled?
>>
>> In that case should we still emit an event if a timeout is present and the
>> duration is greater
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
On Wed, 10 Apr 2024 10:57:33 GMT, Jaikiran Pai wrote:
>> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 286:
>>
>>> 284: OutputAnalyzer outputAnalyzer =
>>> ProcessTools.executeCommand(commands.toArray(new String[commands.size()]));
>>> 285:
On Wed, 10 Apr 2024 10:40:55 GMT, Jaikiran Pai wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
>
On Wed, 14 Feb 2024 23:37:03 GMT, Stuart Marks wrote:
>> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and
>> will thus fall back to slower default method of `List.sort()` instead of
>> sorting a range of the array in-place in its backing root `ArrayList`.
>>
>> This
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
64 matches
Mail list logo
