On Mon, 29 Apr 2024 23:22:21 GMT, Naoto Sato wrote:
>> Proposing new overloaded methods in `java.io.Console` class that explicitly
>> take a `Locale` argument. Existing methods rely on the default locale, so
>> the users won't be able to format their prompts/outputs in a certain locale
>>
On Mon, 29 Apr 2024 20:01:38 GMT, Tim Prinzing wrote:
>> Currently the JFR event FileForceEvent is generated by instrumenting the
>> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
>> mirror events with static methods.
>>
>> Added the event at
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/Console.java line 193:
>
>> 191: * {@code locale}.
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote:
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
>
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the pull request
> Get JDK 24 underway.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains seven additional commits since the
last revision:
- Update
On Sat, 27 Apr 2024 11:58:52 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> new section for finalizer memviz
>
> src/java.base/share/classes/java/lang/ref/package-info.java line 157:
>
>>
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote:
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
>
On Thu, 11 Apr 2024 16:39:24 GMT, Daniel Fuchs wrote:
>> I think it's okay for now. If there is another phase of this work to help
>> diagnose spinning issues then it will need to re-visited. I'm very concerned
>> about the possible changes for that second phase, but this first phase of
>>
On Mon, 29 Apr 2024 21:32:16 GMT, Naoto Sato wrote:
>> A new method on Instant to return the duration `until` another Instant is
>> suggested per the following discussion thread:
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>>
>> A CSR has also been drafted.
>
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
On Sat, 27 Apr 2024 11:57:23 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> new section for finalizer memviz
>
> src/java.base/share/classes/java/lang/ref/package-info.java line 137:
>
>>
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
On Mon, 29 Apr 2024 19:52:17 GMT, Bernd wrote:
> Of course the question is if it should write to stderr or /dev/tty like
> mechanism..
I was wondering the same thing. My understanding of the definition of "console"
is a bidirectional byte channel with a keyboard & screen on the other end. It
On Mon, 29 Apr 2024 18:55:24 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
> Currently the JFR event FileForceEvent is generated by instrumenting the
> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
> mirror events with static methods.
>
> Added the event at jdk.internal.event.FileForceEvent, and changed
> jdk.jfr.events.FileForceEvent to
> Currently the JFR event FileForceEvent is generated by instrumenting the
> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
> mirror events with static methods.
>
> Added the event at jdk.internal.event.FileForceEvent, and changed
> jdk.jfr.events.FileForceEvent to
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
A new method on Instant to return the duration `until` another Instant is
suggested per the following discussion thread:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
A CSR has also been drafted.
-
Commit messages:
- Prefer until over between
- nonnull
On Mon, 29 Apr 2024 17:45:55 GMT, Mandy Chung wrote:
> The changes look good to me but I wonder if the non-zero length check before
> calling `arraycopy` really needed? That seems to add some noise to the code.
I recall benchmarking similar code in `MethodType` extensively, and found that
it
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Mon, 22 Apr 2024 19:07:04 GMT, Brian Burkhalter wrote:
> Prevent blocking due to a carrier thread not being released when
> `ByteArrayOutputStream.writeTo` is invoked from a virtual thread.
This pull request has now been integrated.
Changeset: 819f3d6f
Author:Brian Burkhalter
URL:
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote:
> There are further updates to this test in the pipeline (new deprecated flags
> in 23) so you will need to keep updating to reflect that.
Thanks @dholmes-ora ; acknowledged.
-
PR Review Comment:
On Mon, 29 Apr 2024 17:09:24 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update
>> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>>
>> Co-authored-by: Mandy
On Mon, 29 Apr 2024 17:09:24 GMT, ExE Boss wrote:
> This doesn’t fix the case where the lambda is created from an instance
> method, e.g.:
>
Yes, unfortunately the fix is limited to invokeStatic (see the comments above).
-
PR Comment:
On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Sat, 27 Apr 2024 00:14:23 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> code refactoring
>
> src/java.base/share/classes/java/lang/reflect/Executable.java line 348:
>
>> 346:
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release
On Mon, 29 Apr 2024 14:45:07 GMT, Joachim Kern wrote:
> Since ~ end of March, after
> [JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
> tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
>
> stdout: [];
> stderr: [Error: could not find libjava.so
> Error: Could not
On Mon, 29 Apr 2024 14:22:22 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/constant/ConstantDescs.java line 178:
>>
>>> 176:
>>> 177: private static final ClassDesc[] INDY_BOOTSTRAP_ARGS = {
>>> 178: CD_MethodHandles_Lookup,
>>
>> Can these fields be
> Consider code like:
>
> public class ConsoleTest {
> public static void main(String... args) {
> System.console().printf("Hello!");
> }
> }
>
>
> When run as:
>
> $ java ConsoleTest.java >/dev/null
>
>
> it prints `Hello!` to stderr, instead of to stdout (where it would be
Since ~ end of March, after
[JDK-8329131](https://bugs.openjdk.org/browse/JDK-8329131),
tools/launcher/JliLaunchTest.java fails on AIX. Failure is :
stdout: [];
stderr: [Error: could not find libjava.so
Error: Could not find Java SE Runtime Environment.
]
exitValue = 2
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
On Mon, 29 Apr 2024 14:16:34 GMT, Per Minborg wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplified void check
>
> src/java.base/share/classes/java/lang/constant/ConstantDescs.java line 178:
>
>> 176:
>>
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
On Wed, 3 Apr 2024 07:13:13 GMT, Jan Lahoda wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java
>> line 1415:
>>
>>> 1413:
>>> canonicalConstructorTypes,
>>> 1414:
On Mon, 29 Apr 2024 12:39:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
> I'm looking at ways at reducing/eliminating startup overheads the classfile
> API in preparation of #17108, and have pushed a series of enhancements to
> that effect already. This PR is a collection of minor improvements which add
> up to a 1.5% reduction in retired instructions - or a 5%
On Mon, 29 Apr 2024 12:18:15 GMT, Chen Liang wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Descriptors can't be empty, optimize isArray and isClassOrInterface with
>> descriptorString().charAt(0) ==
>
>
On Mon, 29 Apr 2024 12:14:17 GMT, Claes Redestad wrote:
>> I'm looking at ways at reducing/eliminating startup overheads the classfile
>> API in preparation of #17108, and have pushed a series of enhancements to
>> that effect already. This PR is a collection of minor improvements which add
> I'm looking at ways at reducing/eliminating startup overheads the classfile
> API in preparation of #17108, and have pushed a series of enhancements to
> that effect already. This PR is a collection of minor improvements which add
> up to a 1.5% reduction in retired instructions - or a 5%
On Fri, 26 Apr 2024 23:54:17 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
Consider code like:
public class ConsoleTest {
public static void main(String... args) {
System.console().printf("Hello!");
}
}
When run as:
$ java ConsoleTest.java >/dev/null
it prints `Hello!` to stderr, instead of to stdout (where it would be
redirected).
The proposed
On Sun, 28 Apr 2024 11:34:57 GMT, Andrew Haley wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add vectorized and scalar version Float tests checking full 32 bits range
>
>
> HI,
> Can you have a look at this patch adding some tests for Math.round
> instrinsics?
> Thanks!
>
> ### FYI:
> During the development of RoundVF/RoundF, we faced the issues which were only
> spotted by running test exhaustively against 32/64 bits range of int/long.
> It's helpful to add
On Fri, 26 Apr 2024 23:24:19 GMT, Jonathan Gibbons wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
On Wed, 24 Apr 2024 21:59:02 GMT, Jonathan Gibbons wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest
This checker checks the values of the `@since` tag found in the documentation
comment for an element against the release in which the element first appeared.
Real since value of an API element is computed as the oldest release in which
the given API element was introduced. That is:
- for
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
>
I'm looking at ways at reducing/eliminating startup overheads the classfile API
in preparation of #17108, and have pushed a series of enhancements to that
effect already. This PR is a collection of minor improvements which add up to a
1.5% reduction in retired instructions - or a 5% reduction
On Tue, 23 Apr 2024 07:39:47 GMT, Adam Sotona wrote:
> ClassFile API dives into the nested constant pool entries without type
> restrictions, while parsing a class file. Validation of the entry is
> performed post-parsing. Specifically corrupted constant pool entry may cause
> infinite loop
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
64 matches
Mail list logo
