On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes
On Wed, 14 Feb 2024 11:03:07 GMT, Christian Stein wrote:
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the
On Thu, 15 Feb 2024 08:53:12 GMT, Alan Bateman wrote:
>> `String jarname` is filled by the caller with the value of `String what`,
>> and therefore contains the entire path to the executable JAR file. Using
>> only `jarFile.getName()` will prevent any parent directories from being
>> noted in
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian Stein
On Mon, 19 Feb 2024 07:32:31 GMT, Jaikiran Pai wrote:
> Both the files will need a copyright year update.
Right. Updating both files.
> The JBS issue would need an appropriate noreg label too
> https://openjdk.org/guide/#noreg
Added `noreg-cleanup` to the issue.
-
PR Comment:
On Mon, 19 Feb 2024 10:41:03 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 821:
>>
>>> 819: // In LM_JAR mode, put the underlying file in the
>>> JarFile/ZipFile cache.
>>> 820: // This will avoid needing to re-parse the manifest
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian Stein
On Wed, 14 Feb 2024 11:41:43 GMT, Alan Bateman wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
On Wed, 14 Feb 2024 11:40:16 GMT, Alan Bateman wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
Please review this PR that makes the launcher helper keep a reference to the
executable JAR file active after extracting the name of the main class and
returning it as Class instance. Now, when loading classes from the JAR file, it
hasn't to be re-opened.
-
Commit messages:
-
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by cstein (Committer).
German translations read OK.
Nit: some layouts get lost in translated files - it would be great to have
similar usage of `\n` and `` in the translated files.
For
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
Seems to be a different issue with "linux-x86" (32-bit host) and
`GathererTest::testMassivelyComposedGatherers`.
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/stream/GatherersTest.java.
Off by one "s"?
Or does `java/util/stream/GathererTest` (without "s") fail in addition?
On Mon, 20 Nov 2023 13:50:45 GMT, Alan Bateman wrote:
> [...] it does make the java launcher code much simpler.
Yes. That's a very nice effect of surfacing the launch protocol directyl in
`java.lang.Class`
> So I'm not sure about the naming, it feels more like a `findMainMethod` to
>
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote:
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
Instead of adding those directives to all 11 files, can you please try adding
`modules = ...` line to the
dk/test/lib/format/ArrayDiffTest.java
>
>Co-authored-by: Christian Stein
Looks good to me.
Tested with `--test test/lib-test/jdk/test/lib`.
-
Marked as reviewed by cstein (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15131#pullrequestreview-1635286817
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
On Tue, 15 Aug 2023 08:07:09 GMT, Christian Stein wrote:
>> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
>>> rights reserved.
>>
>> S
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.3,1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
Please review the change to update to using jtreg 7.3,1.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the `requiredVersion` has been updated in the various `TEST.ROOT` files.
This change
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
Please only keep first and last/latest year of changes.
test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2019, 2020, 2023, Oracle and/or its
On Tue, 15 Aug 2023 08:03:59 GMT, John Jiang wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
>> rights reserved.
>
> Should it
On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao wrote:
> Modified all tests under lib-test/jdk to use JUnit
Marked as reviewed by cstein (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/15131#pullrequestreview-1578082673
On Wed, 9 Aug 2023 10:45:56 GMT, Christian Stein wrote:
> Please review this change to remove Unit-based tests in `java/lang/invoke`
> from `jdk`'s problem list. The underlying race condition in jtreg was fixed
> in release 7.3; which is now the default version used in JDK
Please review this change to remove Unit-based tests in `java/lang/invoke` from
`jdk`'s problem list. The underlying race condition in jtreg was fixed in
release 7.3; which is now the default version used in JDK mainline development.
-
Commit messages:
- Update ProblemList.txt
On Wed, 26 Jul 2023 07:25:20 GMT, Christian Stein wrote:
> Problem list some JUnit-based tests in
> `test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
> `jtreg` 7.3 with a fix for the underlying race condition is released. That
> fix is track
Problem list some JUnit-based tests in
`test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
`jtreg` 7.3 with a fix for the underlying race condition is released. That fix
is tracked via https://bugs.openjdk.org/browse/CODETOOLS-7903507
-
Commit messages:
-
On Fri, 23 Jun 2023 11:32:04 GMT, Christian Stein wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
Hi all,
This pull request contains a backport of commit
[4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Christian Stein on 23 Jun 2023
On Tue, 20 Jun 2023 13:54:15 GMT, Christian Stein wrote:
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
This pull re
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
Christian Stein has updated the pull request incrementally with one additi
Please review this update to `java`'s help output for `--module-path`/`-p`.
This PR also updates the output for the closely related `--upgrade-module-path`
option.
Thanks in advance!
-
Commit messages:
- Update `--upgrade-module-path` description
- 8309670: java -help output for
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote:
> This pull request addresses the open ends left by
> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
> - #11272
>
> Changes:
> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Up
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.2.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
On Sat, 22 Apr 2023 12:15:38 GMT, Christian Stein wrote:
>> This pull request addresses the open ends left by
>> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
>> - #11272
>>
>> Changes:
>> - [x] Extend list of targeted exports o
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request incrementally with five additional
commits since the last revision:
- F
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request incrementally with one additional
commit since the last revisio
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Upda
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request incrementally with one additional
commit since the last r
On Fri, 21 Apr 2023 21:42:58 GMT, Mandy Chung wrote:
>> Christian Stein has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
shared `CommandLine.java` in `jdk.compiler` module
> - [x] Use shared `CommandLine.java` in `jdk.javadoc` module
> - [x] Remove `CommandLine.java` from `jdk.compiler` module
Christian Stein has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote:
> This pull request addresses the open ends left by
> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
> - #11272
>
> Changes:
> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`
On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs wrote:
> Create an internal Version record to hold and compare versions of the form
> (major, minor, micro).
> Add `OperatingSystem.version()` to return the version of the running OS.
> Replace uses of os.version in java.base.
> Subsequent PRs will
On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs wrote:
> Create an internal Version record to hold and compare versions of the form
> (major, minor, micro).
> Add `OperatingSystem.version()` to return the version of the running OS.
> Replace uses of os.version in java.base.
> Subsequent PRs will
Please review the change to update to using jtreg 7.2.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
-
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are
This pull request addresses the open ends left by
[JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
- #11272
Changes:
- [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` to
`jdk.compiler` and `jdk.javadoc`
- [x] Use shared `CommandLine.java` in `jdk.compiler`
On Wed, 8 Feb 2023 09:32:49 GMT, Jaikiran Pai wrote:
> I wonder if testng (and junit) can be configured to fail the test if no test
> methods were present, to flag such mistakes.
JUnit's CLI tool has:
`--fail-if-no-tests Fail and return exit status code 2 if no tests are
found.`
We can
On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman wrote:
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> -
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote:
> The ModuleReader implementation for exploded modules maps resource names to
> file paths. A small oversight is that it doesn't handle InvalidPathException
> which is thrown when the resource name maps to something that can't be parsed
>
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.1.1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
On Tue, 6 Dec 2022 17:45:06 GMT, Christian Stein wrote:
>> Please review the change to update to using jtreg 7.1.1.
>>
>> The primary change is to the `jib-profiles.js` file, which specifies the
>> version of jtreg to use, for those systems that rely on th
.ROOT`
> files.
>
> This pull request was created by copying the following and using 7.1.1 at
> appropriate places:
> - https://github.com/openjdk/jdk/pull/11416
Christian Stein has refreshed the contents of this pull request, and previous
commits have been removed. Incremental vie
.ROOT`
> files.
>
> This pull request was created by copying the following and using 7.1.1 at
> appropriate places:
> - https://github.com/openjdk/jdk/pull/11416
Christian Stein has updated the pull request incrementally with two additional
commits since the last revision:
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.1.1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.1.1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
Please review the change to update to using jtreg 7.1.1.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
This pull
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
Please review the change to update to using jtreg `7.1`.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
This pull
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote:
> This PR copies the `CommandLine.java` file from module `jdk.compiler`
> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
> creating a new package with name `jdk.internal.opt`. That new
> `jdk.
rule".
> - [x] Remove `CommandLine.java` from `jdk.jartool` module
> - [x] Remove `CommandLine.java` from `jdk.jlink` module
> - [x] Remove `CommandLine.java` from `jdk.jpackage` module
> - [x] Check for related but renamed(?) usages of `CommandLine.java` in other
> JDK tools: `js
rule".
> - [x] Remove `CommandLine.java` from `jdk.jartool` module
> - [x] Remove `CommandLine.java` from `jdk.jlink` module
> - [x] Remove `CommandLine.java` from `jdk.jpackage` module
> - [x] Check for related but renamed(?) usages of `CommandLine.java` in other
> JDK tools: `js
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote:
> This PR copies the `CommandLine.java` file from module `jdk.compiler`
> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
> creating a new package with name `jdk.internal.opt`. That new
> `jdk.
This PR copies the `CommandLine.java` file from module `jdk.compiler` (package
`com.sun.tools.javac.main`) into the `jdk.internal.opt` module, creating a new
package with name `jdk.internal.opt`. That new `jdk.internal.opt` package is
then exported to the following modules:
- `jdk.jartool`
-
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `
On Mon, 5 Sep 2022 07:38:33 GMT, Thomas Stuefe wrote:
> So I guess at the minimum we would have to downport those test changes to be
> able to test older JDKs with the new jtreg, right?
Yes. Otherwise those tests will fail as they still do depend on hard-coded
names of 3rd-party JAR files.
On Mon, 5 Sep 2022 06:36:04 GMT, Thomas Stuefe wrote:
> Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, down
> to which version?
Yes, down to JDK 11.
Quote from [Coming soon: jtreg
7](https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006869.html)
> Also
.ROOT`
> files.
Christian Stein has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Update configure to
On Tue, 30 Aug 2022 09:14:12 GMT, Jaikiran Pai wrote:
> Hello Christian, is it intentional that in some file the minimum required
> jtreg version is represented as `7` (`lib-tests.m4`) and in some other files
> as `7+1` (GitHub actions config file, then the TEST.ROOT files)?
Yes. Some systems
.ROOT`
> files.
Christian Stein has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Update configure to check for jtreg 7 or later
- Merge branch 'openjdk:master
.ROOT`
> files.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Update configure to check for jtreg 7 or later
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9393/files
- new: https://git.openjdk.org/jdk/pull/9
.ROOT`
> files.
Christian Stein has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 11 commits:
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Revert junit.java
.ROOT`
> files.
Christian Stein has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
- Merge branch 'openjdk:master' into JDK-8289798-jtreg-7
- Revert junit.java
Commit
https://github.com/
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `
Please review the change to update to using jtreg 7.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the `requiredVersion` has been updated in the various `TEST.ROOT` files.
-
On Fri, 12 Aug 2022 16:26:30 GMT, Christian Stein wrote:
> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
> accept version information in JAR file names.
>
> Find details in https://bugs.openjdk.org/browse/JDK-8292182
This pull request has now bee
> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
> accept version information in JAR file names.
>
> Find details in https://bugs.openjdk.org/browse/JDK-8292182
Christian Stein has updated the pull request incrementally with one additional
commit si
On Sat, 13 Aug 2022 03:41:04 GMT, Jaikiran Pai wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused import statement
>
> test/jaxp/javax/xml/jaxp/libs/jaxp/library/J
On Fri, 12 Aug 2022 20:18:50 GMT, Naoto Sato wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused import statement
>
> test/jaxp/javax/xml/jaxp/libs/jaxp/library/
Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
accept version information in JAR file names.
Find details in https://bugs.openjdk.org/browse/JDK-8292182
-
Commit messages:
- 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions
for
On Fri, 10 Jun 2022 18:28:46 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
86 matches
Mail list logo
