Widen acceptable error bound of Math.tan to accommodate the worst-case observed
error which is slightly outside of the allowable range.
-
Commit messages:
- JDK-8326530: Widen allowable error bound of Math.tan
Changes: https://git.openjdk.org/jdk/pull/17973/files
Webrev:
On Thu, 22 Feb 2024 03:01:58 GMT, Chris Hennick wrote:
> Update: confirmed that the new test fails without the fix.
Thanks for verifying the test checks the fix; I'll let others who have worked
more directly on the random code review the actual fix.
-
PR Comment:
On Mon, 5 Feb 2024 04:25:16 GMT, Chris Hennick wrote:
> This provides a slightly more accurate bounding limit for
> `computeNextExponentialSoftCapped` when the computed bound is greater than
> `(1.0p53 - 1.0) * DoubleZigguratTables.exponentialX0`. This could cause the
> `while
On Wed, 7 Feb 2024 19:06:21 GMT, Weijun Wang wrote:
> Security changes look fine. Although I don't know how to remove those
> annotations later. A lot of compatibility impact.
In case you didn't see it, the warning message are listed in an attachment on
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the b
On Wed, 7 Feb 2024 19:28:11 GMT, Joe Darcy wrote:
>> After the "this-escape" lint warning was added to javac (JDK-8015831), the
>> base module was not updated to be able to compile with this warning enabled.
>> This PR makes the necessary changes to al
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warning enabled.
Joe Darcy has up
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warning enabled.
Joe Darcy has up
On Thu, 1 Feb 2024 01:32:42 GMT, Joe Darcy wrote:
> A double quote character doesn't need to be escaped when it is a char literal
> and single quote character doesn't need to be escaped when it is in a string.
> This change updates the toString() output of annotations t
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the b
On Tue, 6 Feb 2024 14:35:52 GMT, Daniel Fuchs wrote:
>> After the "this-escape" lint warning was added to javac (JDK-8015831), the
>> base module was not updated to be able to compile with this warning enabled.
>> This PR makes the necessary changes to allow the base module to build with
>>
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote:
> This update drops the "ea" from the version string.
>
> We also propagate the following fixes from the markdown sources to the troff
> manpage file:
>
> JDK-8322478: Update java manpage for multi-file source-code launcher
> JDK-8302233:
On Fri, 2 Feb 2024 23:38:41 GMT, Joe Darcy wrote:
> In its initial form, the changes are tested on Linux. Later on, I'll do
> cross-platform builds to make sure there aren't any, say, windows-specific
> changes that are needed as well.
>
> I can file a follow-up umbrella bug wi
On Fri, 2 Feb 2024 23:38:41 GMT, Joe Darcy wrote:
> In its initial form, the changes are tested on Linux. Later on, I'll do
> cross-platform builds to make sure there aren't any, say, windows-specific
> changes that are needed as well.
>
PS Builds pass on all platforms
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the b
After the "this-escape" lint warning was added to javac (JDK-8015831), the base
module was not updated to be able to compile with this warning enabled. This PR
makes the necessary changes to allow the base module to build with the warning
enabled.
-
Commit messages:
-
> The restricted javac warning is disabled for java.base, but could be enabled
> by suppressing the warning in a handful of files.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes b
On Thu, 1 Feb 2024 21:10:48 GMT, Joe Darcy wrote:
> The restricted javac warning is disabled for java.base, but could be enabled
> by suppressing the warning in a handful of files.
This pull request has now been integrated.
Changeset: adc36040
Author: Joe Darcy
URL:
On Thu, 1 Feb 2024 22:01:49 GMT, Jorn Vernee wrote:
> This looks good to me. It will be easier to find where we are doing
> restricted operations like this.
Right; follows the recommended approach of minimizing the scope of the
SuppressWarnings annotations too. Thanks.
-
PR
> The restricted javac warning is disabled for java.base, but could be enabled
> by suppressing the warning in a handful of files.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add comment highlighting restricted method
The restricted javac warning is disabled for java.base, but could be enabled by
suppressing the warning in a handful of files.
-
Commit messages:
- JDK-8325148: Enable restricted javac warning in java.base
Changes: https://git.openjdk.org/jdk/pull/17677/files
Webrev:
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial
A double quote character doesn't need to be escaped when it is a char literal
and single quote character doesn't need to be escaped when it is in a string.
This change updates the toString() output of annotations to account for the
different escaping requirements of strings and characters.
On Tue, 30 Jan 2024 17:21:07 GMT, Aleksey Shipilev wrote:
> Can we maybe see if we can fix these tests without exclusive-accessing them?
> I find it surprising that `java/lang/StringBuilder` tests are problematic,
> but `java/lang/StringBuffer` tests are not. Which tests fail?
I agree it
On Mon, 29 Jan 2024 23:53:08 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Fri, 26 Jan 2024 21:52:37 GMT, Joe Darcy wrote:
>> A trivial fix for validate-source.
>
> Marked as reviewed by darcy (Reviewer).
> @jddarcy - Thanks for the lightning fast review!
>
> /integrate auto
Sorry for missing that before pushing.
---
On Fri, 26 Jan 2024 21:51:04 GMT, Daniel D. Daugherty
wrote:
> A trivial fix for validate-source.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17599#pullrequestreview-1846604299
On Wed, 24 Jan 2024 18:14:11 GMT, Aggelos Biboudis
wrote:
> I have this regarding numeric values. Is it the kind of test you have in mind?
>
>
On Wed, 24 Jan 2024 15:55:51 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request
On Thu, 18 Jan 2024 17:39:47 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to the copyright line in
> test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java.
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Wed, 17 Jan 2024 21:22:07 GMT, Pavel Rappo wrote:
> Please review this trivial PR to reorder the `sealed` class or interface
> modifier. For context of this change see:
> https://github.com/openjdk/jdk/pull/17242#issuecomment-1887338396.
Marked as reviewed by darcy (Reviewer).
On Mon, 15 Jan 2024 09:49:53 GMT, Alan Bateman wrote:
> > With my CSR hat on, JDK-8301341 should never have made the changes it did
> > without going through a CSR request. We have been bitten by this kind of
> > problem many times. Unless a public method is specified to utilise another
> >
On Wed, 10 Jan 2024 06:00:18 GMT, Joe Darcy wrote:
> Add a few apiNote concerning source-level modifiers that are not represented
> in java.lang.reflect.Modifier.
This pull request has now been integrated.
Changeset: 9e9c05f0
Author: Joe Darcy
URL:
https://git.openjdk.o
> Add a few apiNote concerning source-level modifiers that are not represented
> in java.lang.reflect.Modifier.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Reflow paragraph.
-
Changes:
- all: https://git.openj
> Add a few apiNote concerning source-level modifiers that are not represented
> in java.lang.reflect.Modifier.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Refine wording per review feedback.
-
Changes:
- all:
On Wed, 10 Jan 2024 17:02:05 GMT, Eirik Bjørsnøs wrote:
> > Sounds like a CSR is needed for the behavioral change proposed here.
>
> Thanks for flagging this @jddarcy
>
> I'm personally not 100% convinced a CSR is warranted in this case, but I'm of
> course happy to extend the following into
> Add a few apiNote concerning source-level modifiers that are not represented
> in java.lang.reflect.Modifier.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Implement review feedback.
-
Changes:
- all:
On Wed, 3 Jan 2024 06:43:22 GMT, Joe Darcy wrote:
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
>
On Wed, 10 Jan 2024 18:27:45 GMT, Pavel Rappo wrote:
> > /contributor add @pavelrappo
>
> Thanks, Joe. Making me an "overriding author" was a bit over the top. :)
Skimmed the docs too quickly when looking for a "co-author" command :-)
-
PR Comment:
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase.
Add a few apiNote concerning source-level modifiers that are not represented in
java.lang.reflect.Modifier.
-
Commit messages:
- JDK-8322979: Add informative discussion to Modifier
Changes: https://git.openjdk.org/jdk/pull/17338/files
Webrev:
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Expand test cases.
-
Changes:
- all: https://git.openjdk.o
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update spec; test sealed class structures.
-
Changes:
- a
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update non-sealed computation.
-
Changes:
- all: https:/
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Improve regression test.
-
Changes:
- all: https://git.o
needed for that
> change. If there is consensus this is a reasonable direction, I'll create the
> CSR, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add non-seal'ing support.
-
Changes:
- all: https://git.o
On Wed, 3 Jan 2024 19:44:51 GMT, Pavel Rappo wrote:
>> I think the best place, or least-bad place, to discuss the "modifier"
>> ordering of sealed/non-sealed would be an informative note on
>> Modifier.toString(int) -- "The sealed/non-sealed Java language modifiers are
>> not represented in
On Fri, 22 Dec 2023 07:55:24 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data
On Wed, 3 Jan 2024 22:20:15 GMT, Joe Darcy wrote:
>>> Since it doesn't seem possible to do so, I did not attempt to relay
>>> "non-sealed" information in this PR :-)
>>
>> Naively, I thought that something like this is possible _in principle_; I
>&g
On Wed, 3 Jan 2024 19:44:51 GMT, Pavel Rappo wrote:
>> I think the best place, or least-bad place, to discuss the "modifier"
>> ordering of sealed/non-sealed would be an informative note on
>> Modifier.toString(int) -- "The sealed/non-sealed Java language modifiers are
>> not represented in
On Wed, 3 Jan 2024 06:43:22 GMT, Joe Darcy wrote:
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
>
On Wed, 3 Jan 2024 16:40:32 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/Class.java line 264:
>>
>>> 262: /**
>>> 263: * Returns a string describing this {@code Class}, including
>>> 264: * information about modifiers, {@linkplain #isSealed() sealing},
>>> and
On Wed, 3 Jan 2024 14:52:48 GMT, Roger Riggs wrote:
>> As recently discussed on core libs, sealed-ness information could be
>> included in the Class.toGenericString() output, analagous to how "modifiers"
>> that also correspond to JVM access flags are handled.
>>
>> This is the initial spec,
As recently discussed on core libs, sealed-ness information could be included
in the Class.toGenericString() output, analagous to how "modifiers" that also
correspond to JVM access flags are handled.
This is the initial spec, implementation, and test updated needed for that
change. If there is
On Tue, 12 Dec 2023 04:26:25 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
On Tue, 12 Dec 2023 22:30:02 GMT, Joe Darcy wrote:
> It may be helpful to link to javax.lang.model.util.Elements.Origin.MANDATED
> and javax.lang.model.util.Elements.Origin.SYNTHETIC to give the reader some
> more context here. If you do that, you may need to add some Suppres
On Tue, 12 Dec 2023 04:26:25 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>>
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZi
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote:
> Time to start making preparations for JDK 23.
This pull request has now been integrated.
Changeset: 519ecd35
Author: Joe Darcy
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/com
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16505/files
- new: https://git.openjdk.org/
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 21 commits:
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into JDK-8319413
- Merge branch 'mas
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 18 commits:
- Regenerate JDK 22 symbol files.
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into
On Mon, 4 Dec 2023 21:30:44 GMT, Tom Rodriguez wrote:
> I guess that sort of makes sense. The default timeout factor is 4 I think so
> I guess I descale the existing total wait of 1000 ms so that the total wait
> is now Utils.adjustTimeout(250)? Maybe others might offer an opinion? Since
>
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into JDK-8319413
- Add symbol files.
- Merge branch 'master' into JDK-8319413
- Me
On Mon, 4 Dec 2023 17:46:18 GMT, Tom Rodriguez wrote:
> This slightly increases the wait for reference processing to complete to
> accommodate long Xcomp compile times. Testing is underway.
test/jdk/java/lang/Object/FinalizationOption.java line 92:
> 90: System.gc();
> 91:
On Fri, 1 Dec 2023 08:54:06 GMT, Alan Bateman wrote:
> Looks good. I assume you'll bump the copyright header on the files that need
> it before integration, e.g. JavacTestingAbstractProcessor.
Right; I run a script to update the years of modified files.
-
PR Comment:
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update symbol files to JDK 22 b26.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16505/files
- new: ht
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains eight commits:
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into JDK-8319413
- Add symbol files for
On Tue, 28 Nov 2023 15:00:43 GMT, Jim Laskey wrote:
>> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:
>>
>>> 33: import java.lang.reflect.Modifier;
>>> 34:
>>> 35: public class TestImplicitClass {
>>
>> The test looks to be testing core reflection behavior (i.e.
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains seven commits:
- Merge branch 'master' into JDK-8319413
- Add symbol files for JDK 22 build 25.
- Merge branch 'mas
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
This pull request has now been integrated.
Changeset: d783aa31
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/d783aa31a9c20f5ac2ee52c55bdc9be2388b1705
Stats: 1 l
Typo fix to to the new text added in JDK-8295391.
-
Commit messages:
- JDK-8320940: Fix typo in java.lang.Double
Changes: https://git.openjdk.org/jdk/pull/16872/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16872=00
Issue: https://bugs.openjdk.org/browse/JDK-8320940
On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 17:42:48 GMT, Jim Laskey wrote:
>> `UNNAMED_CLASSES` should probably be removed, as I think it is fully
>> replaced with `IMPLICIT_CLASSES`, and I don't think there are bootstrap
>> problems here (unlike in `jdk.internal.java.PreviewFeature`). I would say it
>> would make
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote:
> Time to start making preparations for JDK 23.
Nothing exception in this batch of start-of-release updates. Clean local
testing results on tier 1.
The symbol files correspond to JDK 22 build 25 and will be updated with
subsequent bui
Time to start making preparations for JDK 23.
-
Commit messages:
- Add symbol files for JDK 22 build 25.
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into JDK-8319413
- Adjust expected release date.
- Fix omission in Classfile.java
- JDK-8319413: Start of
On Fri, 3 Nov 2023 23:52:45 GMT, Chen Liang wrote:
>> Time to start making preparations for JDK 23.
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 1:
>
>> 1: /*
>
> `latestMajorVersion` below should be updated to return `JAVA_23_VERSION` as
> well.
Good catch;
On Mon, 27 Nov 2023 16:17:14 GMT, Eirik Bjorsnos wrote:
> Please review this trivial, formatting and documentation-only change which
> adds missing whitespace around a few `if` statements, `while` statements and
> assigments in `@snippet` code in `j.l.Double` and `j.u.z.ZipInputStream`.
>
>
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote:
>> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3
>> Compilation Units.
>>
>> - It is not abstract (8.1.1.1 ⇗).
>> - It is final (8.1.1.2 ⇗).
>> - It is a member of an unnamed package (7.4.2 ⇗) and **has package
On Wed, 8 Nov 2023 17:29:28 GMT, Joe Darcy wrote:
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
This pull request has now been integrated.
Changeset: 8ff7d6ea
Author: Joe Darcy
URL:
https://git.openjdk.or
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix link.
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Minor tweaks.
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Wed, 8 Nov 2023 18:41:53 GMT, Eirik Bjorsnos wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Small clean ups.
>
> src/java.base/share/classes/java/lang/Double.java line 209:
>
>
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Small clean ups.
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Minor rewordings.
-
Changes:
- all: https://git.openjdk.org/jd
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull requ
On Wed, 15 Nov 2023 21:59:56 GMT, Brian Burkhalter wrote:
> Clean up HTML error due to nested anchor (``) elements.
Looks good; thanks for fixing this.
-
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16679#pullrequestreview-1733118262
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull requ
On Sun, 8 Oct 2023 17:01:37 GMT, Joe Darcy wrote:
>> @liach , thank you for working on this fix. I've given the changes an
>> initial skim, but will need to do a more thorough review before approving or
>> offering suggestions for changes. My top priority for the next few wee
On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti
wrote:
>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
>> improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Wed, 8 Nov 2023 19:40:11 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switch to parseFloat from valueOf, add links.
>
> src/java.base/share/classes/
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Switch to parseFloat from valueOf, add links.
-
Changes:
On Wed, 8 Nov 2023 18:17:00 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/D
On Wed, 8 Nov 2023 18:09:52 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/D
On Wed, 8 Nov 2023 17:54:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/D
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Address issues found by reviewers.
-
Changes:
- all: https://git
Add discussion of some of the common pitfalls related to decimal <-> binary
conversion.
-
Commit messages:
- Appease jcheck.
- JDK-8295391: Add discussion of binary <-> decimal conversion issues
Changes: https://git.openjdk.org/jdk/pull/16566/files
Webrev:
101 - 200 of 754 matches
Mail list logo
