On Wed, 1 May 2024 17:21:20 GMT, Naoto Sato wrote:
>> A new method on Instant to return the duration `until` another Instant is
>> suggested per the following discussion thread:
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>>
On Wed, 1 May 2024 20:35:10 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote:
>> Please review this PR which converts _TestEncodingDecodingLength.java_ into
>> a whitebox test which allows for testing to be done without memory usage
>> issues.
>>
>> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte
On Tue, 30 Apr 2024 15:02:21 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Wed, 1 May 2024 17:10:53 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java li
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull req
On Mon, 29 Apr 2024 21:54:55 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> src/java.base/share/classes/java/io/Console.java line 193:
&
On Tue, 23 Apr 2024 20:35:43 GMT, Naoto Sato wrote:
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certa
> Proposing new overloaded methods in `java.io.Console` class that explicitly
> take a `Locale` argument. Existing methods rely on the default locale, so the
> users won't be able to format their prompts/outputs in a certain locale
> explicitly.
Naoto Sato has updated the
> A new method on Instant to return the duration `until` another Instant is
> suggested per the following discussion thread:
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
>
> A CSR has also been drafted.
Naoto Sato has updated the pull req
A new method on Instant to return the duration `until` another Instant is
suggested per the following discussion thread:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/122131.html
A CSR has also been drafted.
-
Commit messages:
- Prefer until over between
- nonnull
On Mon, 29 Apr 2024 14:56:23 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class ConsoleTest {
>> public static void main(String... args) {
>> System.console().printf("Hello!");
>> }
>> }
>>
>>
>> When run as:
>>
>> $ java ConsoleTest.java >/dev/null
>>
>>
>>
On Fri, 26 Apr 2024 18:15:12 GMT, Justin Lu wrote:
>> Correct a misleading example in the DateFormat parse documentation.
>>
>> Common usage is to use a factory instance. The original example provided
>> assumes a pattern provided by a COMPAT factory instance.
>>
>> The pattern itself should
On Thu, 25 Apr 2024 21:32:03 GMT, Joe Darcy wrote:
> Remove unnecessary setting of variable y, found by an IDE inspection noted in
> the bug report.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18963#pullrequestreview-2023687212
On Mon, 22 Apr 2024 18:44:33 GMT, Naoto Sato wrote:
> Upgrading the CLDR to version 45.0. We now have versions specified in the
> javadoc (`LocaleServiceProvider`), a corresponding CSR has also been drafted.
This pull request has now been integrated.
Changeset: 1c238d43
Author: Naot
Proposing new overloaded methods in `java.io.Console` class that explicitly
take a `Locale` argument. Existing methods rely on the default locale, so the
users won't be able to format their prompts/outputs in a certain locale
explicitly.
-
Commit messages:
- Not using System.err
Upgrading the CLDR to version 45.0. We now have versions specified in the
javadoc (`LocaleServiceProvider`), a corresponding CSR has also been drafted.
-
Commit messages:
- .md files
- release-45
- Fix tests for CLDR-17482 Fix million compact number issue in Italian
-
On Mon, 22 Apr 2024 14:11:41 GMT, Claes Redestad wrote:
>> This switch expression in `Locale::createLocale` is causing a somewhat large
>> startup regression on my local system. Desugaring to if statements seem like
>> the right thing to do while we investigate ways to further reduce overheads
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before
On Thu, 18 Apr 2024 21:54:26 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>> jaxp-compat.properties: used to regain compatibility from any
On Wed, 17 Apr 2024 17:16:55 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability
On Tue, 16 Apr 2024 22:30:47 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 78:
>>
>>> 76: * installed. Thus, to use an instance method defined by {@code
>>> CompactNumberFormat},
>>> 77: * the {@code NumberFormat} returned by the factory method
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
Marked as reviewed by
On Tue, 16 Apr 2024 17:06:50 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt
On Tue, 16 Apr 2024 17:12:06 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability
On Tue, 16 Apr 2024 06:08:00 GMT, Jaikiran Pai wrote:
> Naoto, Roger, should we consider a release note for this change or is the CSR
> itself enough?
I think CSR is enough, as users' chance of encountering any issue is very slim.
My $0.02
-
PR Comment:
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
This pull request has now been integrated.
Changeset: 2ede1433
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/2ede14335a2c9133bf4f356189cfbd5839361d17
Stats: 2 lines in 1 file chan
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18788#issuecomment-2059441642
Fixing a typo in the javadoc
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18788/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18788=00
Issue: https://bugs.openjdk.org/browse/JDK-8330279
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote:
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for
On Thu, 11 Apr 2024 20:55:11 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Wed, 10 Apr 2024 20:20:36 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Wed, 10 Apr 2024 01:31:36 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/time/temporal/ChronoField.java line 590:
>>
>>> 588: * This is necessary to ensure interoperation between calendars.
>>> 589: *
>>> 590: * Range of {@code InstantSeconds} is between {@link
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a
On Tue, 9 Apr 2024 00:52:43 GMT, Jaikiran Pai wrote:
>> The code should reference the constants in Instant.java (though may need to
>> make them package private.)
>>
>> The javadoc can/should reference Instant.MIN and Instant.MAX (as the test
>> does).
>
> Hello Roger,
>
>> The code should
On Mon, 8 Apr 2024 09:52:39 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>
> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
> initialized to have a minimum
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
This pull request has now been integrated.
Changeset: dd930c57
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18662#issuecomment-2043177032
On Fri, 5 Apr 2024 21:57:15 GMT, Roger Riggs wrote:
> The test doesn't run quickly already due to the large chunks of memory used.
OK, never mind then, if it would take considerable time.
-
PR Comment: https://git.openjdk.org/jdk/pull/18663#issuecomment-2040706486
On Fri, 5 Apr 2024 17:44:38 GMT, Roger Riggs wrote:
> When encoding a vary large string in String.getBytes(StandardCharset.UTF_8)
> computation of the buffer size may exceed the range of a positive 32-bit
> Integer.
> If the estimated size for the result byte array is too large, pre-compute
Fix a file/class name in the `CLDRConverter` build tool, with some clean-up for
a switch statement.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18662=00
Issue:
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote:
> Updated following tests to use ProcessTools methods:
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
> test/jdk/java/lang/annotation/LoaderLeakTest.java
> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
Marked as reviewed by naoto (Reviewer).
-
PR Review:
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote:
> Hi all,
>
> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
> machines.
> I'm not an expert in this area and just guess it can be fixed like this.
> Please review it.
>
> Thanks.
> Best regards,
> Jie
LGTM. Thanks
On Wed, 27 Mar 2024 19:58:17 GMT, Naoto Sato wrote:
> Clarifying the behavior for non-ASCII digits in Double/Float.valueOf(String)
> method descriptions. A draft CSR has also been created.
This pull request has now been integrated.
Changeset: 8a0ef811
Author: Naoto Sato
URL:
Clarifying the behavior for non-ASCII digits in Double/Float.valueOf(String)
method descriptions. A draft CSR has also been created.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18526/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18526=00
On Tue, 26 Mar 2024 23:32:34 GMT, Justin Lu wrote:
>> Please review this PR which updates two MessageFormat sub format related
>> tests to be guaranteed to run under the `en_US` locale.
>>
>> There exists locale that do not provide distinct instances for separate
>> styles. For example, the
On Tue, 26 Mar 2024 23:02:34 GMT, Justin Lu wrote:
>> Please review this PR which updates two MessageFormat sub format related
>> tests to be guaranteed to run under the `en_US` locale.
>>
>> There exists locale that do not provide distinct instances for separate
>> styles. For example, the
On Tue, 26 Mar 2024 22:23:45 GMT, Justin Lu wrote:
>> test/jdk/java/text/Format/MessageFormat/CompactSubFormats.java line 29:
>>
>>> 27: * @summary Test MessageFormatPattern ability to recognize and produce
>>> 28: * appropriate FormatType and FormatStyle for
>>>
On Tue, 26 Mar 2024 20:49:48 GMT, Justin Lu wrote:
> Please review this PR which updates two MessageFormat sub format related
> tests to be guaranteed to run under the `en_US` locale.
>
> There exists locale that do not provide distinct instances for separate
> styles. For example, the
On Tue, 26 Mar 2024 20:50:10 GMT, Justin Lu wrote:
> Please review this PR which advises ChoiceFormat subclasses throw
> `UnsupportedOperationException` for unused inherited methods.
>
> The CSR covers the proposed wording, and the reasons as to why this is a
> specification and not an
On Fri, 22 Mar 2024 17:58:25 GMT, Raffaello Giulietti
wrote:
> Make use of an unused local variable probably intended to replace later casts.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18460#pullrequestreview-1955528280
On Tue, 19 Mar 2024 17:02:36 GMT, Nizar Benalla wrote:
>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in
>> JDK 10
>>
>> I changed the @\since tags to better accurately show when the methods and
>> constructors were introduced.
>
> Nizar Benalla has
Vote: yes
Naoto
On 3/19/24 8:19 AM, Daniel Fuchs wrote:
Hi,
I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the
Core Libraries Group [4].
Per-Ake is an OpenJDK Reviewer, a committer in the
Leyden and Panama projects, and a member of Oracle’s
Java Core Libraries team.
On Tue, 12 Mar 2024 18:47:37 GMT, Naoto Sato wrote:
> Will let the doc people know. It is at least good that the latest doc for
> JDK21 is correct.
Now the previous releases' supported locales docs have been updated.
-
PR Comment: https://git.openjdk.org/jdk/pull
On Tue, 12 Mar 2024 16:26:48 GMT, Naoto Sato wrote:
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
This pull request has now been integrated.
Changeset: 7f6b7ebb
Author: Naoto Sato
URL:
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Further refinement
-
Changes:
- all:
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing further comments
-
Changes:
On Tue, 12 Mar 2024 19:41:03 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/spi/LocaleServicePro
> Adding a table that maps JDK versions and corresponding CLDR releases as an
> implNote. A draft CSR has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
Changes:
On Tue, 12 Mar 2024 18:13:28 GMT, Joe Wang wrote:
> Irrelevant to this doc change, I happen to notice some of the
> jdk``-suported-locales docs might have not been updated. For
> example,
> https://www.oracle.com/java/technologies/javase/jdk20-suported-locales.html
> had "CLDR release 39"
Adding a table that maps JDK versions and corresponding CLDR releases as an
implNote. A draft CSR has also been created.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18243/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18243=00
Issue:
On Fri, 8 Mar 2024 19:54:31 GMT, Naoto Sato wrote:
> Removing left over "applet" mention in the package-info doc.
This pull request has now been integrated.
Changeset: 586396cb
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/586396cbb55a318fd6a2b4f1d8738258c
On Sat, 9 Mar 2024 11:12:35 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/text/package-info.java
> Removing left over "applet" mention in the package-info doc.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18173/files
On Sat, 9 Mar 2024 13:18:14 GMT, SendaoYan wrote:
>> Date.toString() uses Locale.US explicitly for printing the time zone, so
>> replace Locale.ROOT to Locale.US in this testcase for fix the test failure.
>>
>> This testcase fixed has been verified.
>>
>> Only change the testcase, risk is
Removing left over "applet" mention in the package-info doc.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18173/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18173=00
Issue: https://bugs.openjdk.org/browse/JDK-8327705
Stats: 2 lines in 1
On Thu, 7 Mar 2024 23:31:46 GMT, Justin Lu wrote:
> Please review this PR which is a trivial update to the IANA sub tag registry
> to version 2024-03-07. Tests pass as expected after update.
>
> Associated announcement ->
>
On Thu, 7 Mar 2024 19:28:13 GMT, Naoto Sato wrote:
> A simple doc update to include a leap day example in the `Calendar` class.
This pull request has now been integrated.
Changeset: 87b40c6a
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/com
On Fri, 8 Mar 2024 02: 41: 06 GMT, SendaoYan wrote: >> Date. toString() uses Locale. US explicitly for printing the time zone, so replace Locale. ROOT to Locale. US in this testcase for fix the test failure. >>
ZjQcmQRYFpfptBannerStart
This Message Is From an External
On Thu, 7 Mar 2024 16:47:01 GMT, SendaoYan wrote:
> The DATE_FORMAT_PATTERN is set to "EEE MMM dd HH:mm:ss zzz ", is the time
> format of US. So, creates a formatter should using Locale.US, rather than
> Locale.ROOT, which means empty.
Thanks for the fix. Although setting `Locale.US` to
A simple doc update to include a leap day example in the `Calendar` class.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18158/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18158=00
Issue: https://bugs.openjdk.org/browse/JDK-8327167
Stats:
On Wed, 6 Mar 2024 21:32:11 GMT, Naoto Sato wrote:
> Fixing timeout failures in the test case. Time zone names that are missing
> (chiefly for minor locales) are now calculated at runtime after the fix to
> JDK-8174269. This extra calculation time was multiplied in the
Fixing timeout failures in the test case. Time zone names that are missing
(chiefly for minor locales) are now calculated at runtime after the fix to
JDK-8174269. This extra calculation time was multiplied in the test case as it
iterated over all locales x timezones, which caused timeouts in
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
This pull request has now been integrated.
Changeset: 9f709407
Author: Naoto Sato
URL:
https://git.openjdk.org/jdk/
On Tue, 5 Mar 2024 17:26:11 GMT, Naoto Sato wrote:
>> Fixing test cases. For bad test cases, only the first case was run, and the
>> rest were ignored.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
&
On Tue, 5 Mar 2024 21:27:09 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which prevents an
>> OutOfMemoryError by restricting the initial maximum fraction digits for an
>> empty pattern DecimalFormat.
>>
>> For an empty String pattern DecimalFormat, the maximum
On Tue, 5 Mar 2024 21:23:48 GMT, Justin Lu wrote:
>> test/jdk/java/text/Format/DecimalFormat/ToPatternTest.java line 60:
>>
>>> 58: dFmt.setMinimumFractionDigits(minFrac);
>>> 59:
>>> 60: String[] patterns = dFmt.toPattern().split("\\.");
>>
>> Instead of assuming/hardcoding
On Fri, 23 Feb 2024 21:24:10 GMT, Naoto Sato wrote:
> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The
> `COMPAT` locale data was introduced for applications' migratory purposes
> transitioning to `CLDR`. It is becoming a technical debt and now is
On Tue, 5 Mar 2024 00:32:47 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which prevents an
>> OutOfMemoryError by restricting the initial maximum fraction digits for an
>> empty pattern DecimalFormat.
>>
>> For an empty String pattern DecimalFormat, the maximum
On Tue, 5 Mar 2024 06:44:52 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 44 additional
JVM startup since JDK21, if
> the app is using `COMPAT`). A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
Changes:
- all: https://git.openjdk.org
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
Thanks for the reviews. Updated as suggested
-
PR Comment: https://git.openjdk.org/jdk/pull/18113#issuecomment-1979271823
> Fixing test cases. For bad test cases, only the first case was run, and the
> rest were ignored.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
Changes:
- all: https://git.openjdk.o
Fixing test cases. For bad test cases, only the first case was run, and the
rest were ignored.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18113/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18113=00
Issue:
JVM startup since JDK21, if
> the app is using `COMPAT`). A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull requ
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote:
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
aleOfavgt 20 62564.079 ± 406.697 ns/op
>
> (w/ fix)
> Benchmark Mode Cnt Score Error Units
> LocaleCache.testForLanguageTag avgt 20 4801.175 ± 371.830 ns/op
> LocaleCache.testLocaleOf avgt 20 60394.652 ± 352.471 ns/op
Naoto
aleOfavgt 20 62564.079 ± 406.697 ns/op
>
> (w/ fix)
> Benchmark Mode Cnt Score Error Units
> LocaleCache.testForLanguageTag avgt 20 4801.175 ± 371.830 ns/op
> LocaleCache.testLocaleOf avgt 20 60394.652 ± 352.471 ns/op
Naoto
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote:
> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve
> property. Also slightly improved the error msg with the catalog name.
>
> Test: new test added
> existing test CatalogSupport5 would fail without the Null
On Thu, 29 Feb 2024 20:07:14 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
>> which defines the behavior for creating ChoiceFormats with incorrect
>> patterns. The wording is added to both the ChoiceFormat constructor and
>>
On Tue, 27 Feb 2024 11:24:08 GMT, Magnus Ihse Bursie wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> This looks good from a build perspective. Actually, i
On Mon, 26 Feb 2024 22:38:50 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java
>>
>&g
On Mon, 26 Feb 2024 22:11:31 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/sun/util/locale/provider/Fall
JVM startup since JDK21, if
> the app is using `COMPAT`). A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addressing review comments
-
Changes:
- all: https://git.openjdk.org
101 - 200 of 1222 matches
Mail list logo
