Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Jaikiran Pai
On Wed, 7 Feb 2024 11:31:05 GMT, Alan Bateman wrote: >> Given that subclasses could set these fields lazily (however remote the case >> might be), do you think we should then not specify the >> `NullPointerException` for the read methods on these 2 classes. In which >> case I can exclude

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Alan Bateman
On Wed, 7 Feb 2024 11:14:06 GMT, Jaikiran Pai wrote: >>> These 2 classes, the `CheckedInputStream` and the `CheckedOutputStream` are >>> slightly different from the rest of the classes in this changeset. This >>> javadoc here is for the constructor of the `CheckedInputStream`. The >>>

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Jaikiran Pai
On Wed, 7 Feb 2024 10:47:31 GMT, Alan Bateman wrote: >> These 2 classes, the `CheckedInputStream` and the `CheckedOutputStream` are >> slightly different from the rest of the classes in this changeset. This >> javadoc here is for the constructor of the `CheckedInputStream`. The >>

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Alan Bateman
On Wed, 7 Feb 2024 10:13:00 GMT, Jaikiran Pai wrote: > These 2 classes, the `CheckedInputStream` and the `CheckedOutputStream` are > slightly different from the rest of the classes in this changeset. This > javadoc here is for the constructor of the `CheckedInputStream`. The > implementation

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Jaikiran Pai
On Wed, 7 Feb 2024 09:44:25 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make usage consistent with other similar usages in the file > >

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Jaikiran Pai
On Wed, 7 Feb 2024 09:41:40 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make usage consistent with other similar usages in the file > >

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-07 Thread Alan Bateman
On Wed, 7 Feb 2024 01:52:06 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which updates the javadoc >> of several classes in `java.util.jar` and `java.util.zip` to specify their >> behaviour when `null` arguments are passed to the constructor or methods of >>

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-06 Thread Jaikiran Pai
On Wed, 7 Feb 2024 01:52:06 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which updates the javadoc >> of several classes in `java.util.jar` and `java.util.zip` to specify their >> behaviour when `null` arguments are passed to the constructor or methods of >>

Re: RFR: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments [v5]

2024-02-06 Thread Jaikiran Pai
> Can I please get a review of this doc-only change which updates the javadoc > of several classes in `java.util.jar` and `java.util.zip` to specify their > behaviour when `null` arguments are passed to the constructor or methods of > those classes? > > For these updated classes, I have