Re: RFR: 8328481: Implement Module Imports [v4]

2024-04-10 Thread Jan Lahoda
On Wed, 10 Apr 2024 08:41:19 GMT, Christian Stein wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding more tests for ambiguities. > >

Re: RFR: 8328481: Implement Module Imports [v4]

2024-04-10 Thread Jan Lahoda
On Wed, 10 Apr 2024 11:52:31 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding more tests for ambiguities. > > src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java line

Re: RFR: 8328481: Implement Module Imports [v4]

2024-04-10 Thread Maurizio Cimadamore
On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote: >> This is an implementation of JEP JDK-8315129: Module Import Declarations >> (Preview). Please see the JEP for details: >> https://bugs.openjdk.org/browse/JDK-8315129 >> >> It is mostly straightforward - the module imports are parsed, and

Re: RFR: 8328481: Implement Module Imports [v4]

2024-04-10 Thread Christian Stein
On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote: >> This is an implementation of JEP JDK-8315129: Module Import Declarations >> (Preview). Please see the JEP for details: >> https://bugs.openjdk.org/browse/JDK-8315129 >> >> It is mostly straightforward - the module imports are parsed, and

Re: RFR: 8328481: Implement Module Imports [v4]

2024-04-09 Thread Jan Lahoda
> This is an implementation of JEP JDK-8315129: Module Import Declarations > (Preview). Please see the JEP for details: > https://bugs.openjdk.org/browse/JDK-8315129 > > It is mostly straightforward - the module imports are parsed, and then > expanded to import-on-demand in `TypeEnter`. > There