Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-04 Thread David Holmes
On Tue, 2 Apr 2024 02:16:07 GMT, David Holmes wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use non-sse fill (old left in) > > This looks like it is still a Draft/work-in-progress. There is only code for > x64

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-04 Thread Scott Gibbons
On Tue, 2 Apr 2024 08:09:44 GMT, Doug Simon wrote: > Wouldn't it be better to do this intrinsification directly in the JIT without > calling out to a stub? I believe the code size is too large for a direct JIT intrinsic. A lot of registers are also used, which may be an issue. -

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-04 Thread Scott Gibbons
On Tue, 2 Apr 2024 02:16:07 GMT, David Holmes wrote: >> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use non-sse fill (old left in) > > This looks like it is still a Draft/work-in-progress. There is only code for > x64

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-02 Thread ExE Boss
On Mon, 1 Apr 2024 21:30:19 GMT, Scott Gibbons wrote: >> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this >> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this >> change. >> >> Overall, making this an intrinsic improves overall performance of >>

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-02 Thread Doug Simon
On Mon, 1 Apr 2024 21:30:19 GMT, Scott Gibbons wrote: >> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this >> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this >> change. >> >> Overall, making this an intrinsic improves overall performance of >>

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-01 Thread David Holmes
On Mon, 1 Apr 2024 21:30:19 GMT, Scott Gibbons wrote: >> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this >> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this >> change. >> >> Overall, making this an intrinsic improves overall performance of >>

Re: RFR: 8329331: Intrinsify Unsafe::setMemory [v2]

2024-04-01 Thread Scott Gibbons
> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this > PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this > change. > > Overall, making this an intrinsic improves overall performance of > `Unsafe::setMemory` by up to 4x for all buffer sizes. > >