On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote:
>> I have not seen this used in any other tests. It is a good learning, I
>> didn't knew that multiple tests in single file are run in parallel. It seems
>> like good option. Do you know of any other regression test written this way?
>
> I
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote:
>> Multiple "run" in a single test fails the whole test when one test run fails
>> and all subsequent test run get terminated. Multiple tests with only one
>> "run" each allows all test run to be excused, and they can be run in
>>
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote:
>> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>>
>>> 31:
>>> 32: /*
>>> 33: * @test
>>
>> Why are these tags duplicated here?
>
> Multiple "run" in a single test fails the whole test when one test run fails
> and all
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33:
>
>> 31:
>> 32: /*
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote:
>> Are you saying that we don't need to run the ExtDir2.policy and
>> ExtDir3.policy?
>
> Its fine, ignore my previous comment.
you can add multiple run tags under same test tag, no need to repeat tag, bug,
and summary tags.
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Tue, 20 Dec 2022 19:05:13 GMT, Bill Huang wrote:
>> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 52:
>>
>>> 50: private static final String JDK_HOME =
>>> System.getProperty("test.jdk");
>>> 51: private static final String TEST_SRC =
>>>
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
On Fri, 16 Dec 2022 12:06:14 GMT, Sibabrata Sahoo wrote:
>> Bill Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Fri, 16 Dec 2022 11:48:54 GMT, Sibabrata Sahoo wrote:
>> Bill Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Mon, 5 Dec 2022 19:52:18 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote:
>> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4:
>>
>>> 2: permission javax.crypto.CryptoAllPermission;
>>> 3: permission javax.crypto.CryptoPermission "DES", 64;
>>> 4: }
>>
>> please remove extra line.
>
> I
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AssertThrows an exception in InconsistentEntries test.
>
>
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
On Fri, 14 Oct 2022 15:50:30 GMT, Bill Huang wrote:
>> test/jdk/java/security/Policy/Root/Root.java line 48:
>>
>>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy");
>>> 47: public static void main(String[] args) throws Exception {
>>> 48:
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
On Fri, 14 Oct 2022 11:00:44 GMT, Mahendra Chhipa wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>>
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote:
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
>
This task converts 5 manual tests to automated tests.
sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
sun/security/provider/PolicyParser/ExtDirsChange.java
sun/security/provider/PolicyParser/ExtDirs.java
java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java
26 matches
Mail list logo
