Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote: >> I have not seen this used in any other tests. It is a good learning, I >> didn't knew that multiple tests in single file are run in parallel. It seems >> like good option. Do you know of any other regression test written this way? > > I

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Bill Huang
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote: >> Multiple "run" in a single test fails the whole test when one test run fails >> and all subsequent test run get terminated. Multiple tests with only one >> "run" each allows all test run to be excused, and they can be run in >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote: >> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: >> >>> 31: >>> 32: /* >>> 33: * @test >> >> Why are these tags duplicated here? > > Multiple "run" in a single test fails the whole test when one test run fails > and all

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Bill Huang
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: > >> 31: >> 32: /*

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Sibabrata Sahoo
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >>

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java >