Re: RFR: JDK-8326951 Missing @since Tags [v2]

2024-03-19 Thread Jaikiran Pai
On Tue, 19 Mar 2024 11:21:14 GMT, Nizar Benalla wrote: >> I added `@since` tags for methods/constructors that do not match the >> `@since` of the enclosing class. >> >> The `write` method already existed in `PrintStream` in earlier versions and >> instances of it could always call this

Re: RFR: JDK-8326951 Missing @since Tags [v2]

2024-03-19 Thread Jaikiran Pai
On Mon, 18 Mar 2024 14:02:20 GMT, Jan Lahoda wrote: >> Hello Jaikiran, >> in jdk21 DHPPublicKey did have a >> [getParams()](https://github.com/openjdk/jdk21/blob/890adb6410dab4606a4f26a942aed02fb2f55387/src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java#L244) >> method, so it

Re: RFR: JDK-8326951 Missing @since Tags [v2]

2024-03-19 Thread Jan Lahoda
On Sun, 17 Mar 2024 01:20:17 GMT, Nizar Benalla wrote: >> src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java line 68: >> >>> 66: * >>> 67: * @return {@inheritDoc java.security.AsymmetricKey} >>> 68: * @since 22 >> >> Hello Nizar, are the removal of `@since` in

Re: RFR: JDK-8326951 Missing @since Tags [v2]

2024-03-19 Thread Nizar Benalla
> I added `@since` tags for methods/constructors that do not match the `@since` > of the enclosing class. > > The `write` method already existed in `PrintStream` in earlier versions and > instances of it could always call this method, since it extends > `FilterOutputStream` [which has the >

Re: RFR: JDK-8326951 Missing @since Tags [v2]

2024-03-19 Thread Nizar Benalla
On Sat, 16 Mar 2024 00:20:51 GMT, Jaikiran Pai wrote: >> Nizar Benalla has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Revert "fix rest of private/public since tags" >> >>This reverts commit