Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-12-01 Thread Andrew Haley
On Wed, 30 Nov 2022 21:47:47 GMT, Dean Long wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unused variable > > src/hotspot/share/prims/jvm.cpp line 1385: > >> 1383: vframeStream vfst(thread); >> 1384: for(;

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-12-01 Thread Andrew Haley
On Wed, 30 Nov 2022 21:39:40 GMT, Dean Long wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unused variable > > src/hotspot/share/classfile/javaClasses.cpp line 1731: > >> 1729: } >> 1730: >> 1731: void

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-12-01 Thread Andrew Haley
On Wed, 30 Nov 2022 21:34:59 GMT, Dean Long wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unused variable > > src/hotspot/cpu/aarch64/aarch64.ad line 3635: > >> 3633: } >> 3634: } else if

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-30 Thread Dean Long
On Tue, 29 Nov 2022 11:49:10 GMT, Andrew Haley wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unused variable > > src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java > line 385:

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-30 Thread Dean Long
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote: >> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Unused variable I made a few minor suggestions, but overall the HotSpot changes look good.

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-30 Thread Dean Long
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote: >> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Unused variable src/hotspot/share/prims/jvm.cpp line 1385: > 1383: vframeStream

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-30 Thread Dean Long
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote: >> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Unused variable src/hotspot/share/classfile/javaClasses.cpp line 1731: > 1729: } > 1730: >

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-30 Thread Dean Long
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote: >> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Unused variable src/hotspot/cpu/aarch64/aarch64.ad line 3635: > 3633: } > 3634: }

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-29 Thread Andrew Haley
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote: >> JEP 429 implementation. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Unused variable

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v33]

2022-11-24 Thread Andrew Haley
> JEP 429 implementation. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Unused variable - Changes: - all: https://git.openjdk.org/jdk/pull/10952/files - new: